1 | -*-*- END -*-*-
|
---|
2 |
|
---|
3 | *** Version <cvs>
|
---|
4 |
|
---|
5 | - general: added new tutorial macro macros/tutorials/threshold.C:
|
---|
6 | how to calculate the threshold
|
---|
7 |
|
---|
8 | - general: added a new game. Start it from the interpreter with
|
---|
9 | MagicJam j; (other games are: MineSweeper, MagicSnake, MagicDomino
|
---|
10 | and MagicReversi)
|
---|
11 |
|
---|
12 | - callisto: MBadPixelsCalc now raises an error instead of simply stopping
|
---|
13 | the eventloop if something went wrong. This is necessary for the
|
---|
14 | automatic processing
|
---|
15 |
|
---|
16 | - callisto: Fixed a bug in the treatment of times in the bad pixel
|
---|
17 | treatment. No neighbors have been taken into account, the new
|
---|
18 | arrival time was always calculated by the pixels 0 to 5.
|
---|
19 |
|
---|
20 | - callisto: The status "unmapped" (for pixel which cannot be interpolated)
|
---|
21 | got lost when the events were stored by the calibration... fixed.
|
---|
22 | (This was no problem for normal image cleaning because the pixel
|
---|
23 | content was artificially set to 0 not surviving standard cleaning
|
---|
24 | algorithm)
|
---|
25 |
|
---|
26 | - callisto: Fixed a bug which caused the random and peak-search pedestal
|
---|
27 | extracted with an extractor to be exchanged for the first (roughly)
|
---|
28 | 500 events. (They were simply exchanged in callisto.cc) This bug might
|
---|
29 | have been introduced in Mars 0.9.4 when the order of calculation of the
|
---|
30 | two types of pedestal in callisto got exchanged. The bug only effects
|
---|
31 | the first seconds of data of each sequence.
|
---|
32 |
|
---|
33 |
|
---|
34 |
|
---|
35 | *** Version 0.9.4.1 (2005/08/18)
|
---|
36 |
|
---|
37 | - callisto: fixed some problems with the calibration in case of
|
---|
38 | inteleaved events. Therefor the final and some intermediate
|
---|
39 | fits are skipped which would take place on partly filled #
|
---|
40 | histograms and gave wrong results or failed completely.
|
---|
41 |
|
---|
42 | - callisto: If the intermediate finalization of the histograms
|
---|
43 | calculating the mean charge of the calibration signal fails
|
---|
44 | it is counted now and printed in PostProcess of MCalibCalcFromPast.
|
---|
45 |
|
---|
46 | - ganymed: Fixed some bugs which caused problems in On-only mode.
|
---|
47 | Still the false source plot doesn't give reasonable results.
|
---|
48 |
|
---|
49 |
|
---|
50 |
|
---|
51 | *** Version 0.9.4 (2005/08/05)
|
---|
52 |
|
---|
53 | - general: Fixed the ZA binning. It did not correctly fit the
|
---|
54 | MC binning
|
---|
55 |
|
---|
56 | - general: Added a class to correct for the missfocussing in
|
---|
57 | April (MSrcPosCorrect)
|
---|
58 |
|
---|
59 | - general: Random Forest energy estimator should now work properly
|
---|
60 |
|
---|
61 | - general: MHCamera now displays the profiles in deg instead of mm
|
---|
62 |
|
---|
63 | - general: MH::SetPalette offers a lot of new palettes
|
---|
64 |
|
---|
65 | - general: MHillas - the case of CorrXY==0 is now handled properly
|
---|
66 |
|
---|
67 | - general: implemented the possibility to change the line and
|
---|
68 | marker style of a sky-grid drawn by MAstroCatalog
|
---|
69 |
|
---|
70 | - general: Runs in sequences and datasets are now automatically
|
---|
71 | ordered (it is assumed that the order of their filenames correctly
|
---|
72 | represents the order of observations) to ensure correct reading
|
---|
73 | of the subsystem data
|
---|
74 |
|
---|
75 | - general: Runs cannot be added to a sequence twice anymore. Also
|
---|
76 | Sequences cannot be added twice anymore to a dataset.
|
---|
77 |
|
---|
78 | - general: fixed a bug in MAstro::Deg2Hms reported by Abelardo.
|
---|
79 | It gave wrong results by 1./2pi
|
---|
80 |
|
---|
81 | - showplot: got a new option to start a root interpreter, too
|
---|
82 |
|
---|
83 | - mars: now displays a rough estimate of Disp and the third moment
|
---|
84 |
|
---|
85 | - mars: now displays the event time MTime if available
|
---|
86 |
|
---|
87 | - mars: show muon parameters graphically
|
---|
88 |
|
---|
89 | - mars: now the file to open can be given as commandline
|
---|
90 | argument
|
---|
91 |
|
---|
92 | - merpp: Added support for new arehucas version >= 200507190
|
---|
93 | implementing values for three temperature sensors in the
|
---|
94 | counting house (MCameraAUX) and the name of the HV settings file
|
---|
95 | (MCameraHV).
|
---|
96 |
|
---|
97 | - merrp: Also fixed some problems with wrong versions numbers stated
|
---|
98 | by arehucas and implemented some fixed for old versions (<200407070)
|
---|
99 |
|
---|
100 | - callisto: MCalibrationHiLoCam can now be printed from its context
|
---|
101 | menu, eg in the TBrowser
|
---|
102 |
|
---|
103 | - callisto: fixed logain offset (fgOffsetLoGain) from 1.7 to
|
---|
104 | - 1.39 (MExtractTimeAndChargeSpline)
|
---|
105 | - 1.40 (MExtractTimeAndChargeDigitalFilter)
|
---|
106 | This is important mainly for timing studies.
|
---|
107 |
|
---|
108 | - callisto: Changed limits in MHCalibrationChargeCalc from
|
---|
109 | - -100.125 to -98 (fgChargeHiGainFirst)
|
---|
110 | - 1899.875 to 1902. (fgChargeHiGainLast)
|
---|
111 | - -100.25 to -99 (fgChargeLoGainFirst)
|
---|
112 | - 899.75 to 901. (fgChargeLoGainLast)
|
---|
113 | Introduced new limits:
|
---|
114 | - fgNumLoGainBlackoutLimit: 0.05
|
---|
115 | - fgLoGainBlackoutLimit: 3.5
|
---|
116 | - fgLoGainPickupLimit: 3.5
|
---|
117 |
|
---|
118 | - callisto: The handling of automatic weights for the digital filter
|
---|
119 | has been improved. There are now new calibration weights special
|
---|
120 | for Monte Carlo calibrations.
|
---|
121 |
|
---|
122 | - callisto: Updated Muon scale with latest results (1% difference
|
---|
123 | for most data, 5% for Mar/Apr'05)
|
---|
124 |
|
---|
125 | - callisto: use a new criterium to exclude bad pixels: If the high-gain
|
---|
126 | was saturated and the blackout-events in the low-gain exceed the
|
---|
127 | fNumLoGainBlackoutLimit, the pixel is declared unsuitable.
|
---|
128 | This excludes those pixels which have a saturating high-gain
|
---|
129 | channel, but the low-gain switch does not switch often enough
|
---|
130 | to make the distribution reliable.
|
---|
131 |
|
---|
132 | - callisto: fix a bug counting the number of saturated events. Up to now,
|
---|
133 | the number of saturated slices was counted (which is one for a not too
|
---|
134 | high number), but for some (pathological) pixels, many more slices
|
---|
135 | saturated and produced wrong limits.
|
---|
136 |
|
---|
137 | - callisto: New options in in callisto.rc for MCalibrationRelTimeCalc:
|
---|
138 | + MCalibrationRelTimeCam.CheckFitResults: Yes
|
---|
139 | + MCalibrationRelTimeCam.CheckDeviatingBehavior: Yes
|
---|
140 | + MCalibrationRelTimeCam.CheckHistOverflow: Yes
|
---|
141 | + MCalibrationRelTimeCam.CheckOscillations: Yes
|
---|
142 |
|
---|
143 | - callisto: introduce max. number of events for intercalibration,
|
---|
144 | the rest gets skipped. Default: 4096
|
---|
145 | The calibration causes too many un-reliable pixels if more
|
---|
146 | than about 5000 events are treated (@500 Hz) because of the
|
---|
147 | mode hopping of the VCSels. However, in the past, some
|
---|
148 | calibration runs have been taken (erroneously) with more
|
---|
149 | than 5000 events, especially the intensity scans where
|
---|
150 | a good precision is needed.
|
---|
151 |
|
---|
152 | - callisto: Set UseExtractorRes to kTRUE, will raise the number of
|
---|
153 | photo-electrons for the spline extractor by 1-2% (correctly).
|
---|
154 |
|
---|
155 | - callisto: The intercalibration is now done using a full f-factor
|
---|
156 | method instead of a simple update. This makes things slower but
|
---|
157 | more reliable in terms of gain-fluctuations and sudden VCSEL gain
|
---|
158 | changes.
|
---|
159 |
|
---|
160 | - callisto: MPedestalY3 now uses the same extraction range as the data
|
---|
161 | as calculated by MPedestalY2
|
---|
162 |
|
---|
163 | - callisto: A check of the fraction of allowed unsuitable (10%) and
|
---|
164 | unreliable (30%) pixels has been addded when the conversion is
|
---|
165 | calculated from interleaved events
|
---|
166 |
|
---|
167 | - star: fixed a bug which caused MEffectiveOnTime containers not to
|
---|
168 | be written. In the worst case they were skipped almost all, in the
|
---|
169 | best case they were all ok. It depends on how often the new value
|
---|
170 | was assigned just with an event which was skipped later by another
|
---|
171 | task
|
---|
172 |
|
---|
173 | - star: new histograms MHPointing and MHRate
|
---|
174 |
|
---|
175 | - star: New tab (Currents) displaying the time evolution of the mean
|
---|
176 | DC currents
|
---|
177 |
|
---|
178 | - star: New tab (MeanRms) displaying the time volution of the mean
|
---|
179 | Pedestal Rms
|
---|
180 |
|
---|
181 | - star: Output now contains MReportStarguider
|
---|
182 |
|
---|
183 | - star: Improved muon analysis. Due to the absense of a constant
|
---|
184 | for the gaus fit for arc width and the fact that the arcwidth
|
---|
185 | plot was a histogram instead of a profile the resulting psf
|
---|
186 | became pedestal rms dependant
|
---|
187 |
|
---|
188 | - ganymed: added new plot (MHPhi) for wobble mode as described in
|
---|
189 | http://www.astro.uni-wuerzburg.de/results/ringmethod/
|
---|
190 |
|
---|
191 | - ganymed: corrects now (correctly?) for the misspointing in
|
---|
192 | May/April 05
|
---|
193 |
|
---|
194 | - ganymed: Two new default templates for ganymed.rc are avilable:
|
---|
195 | ganymed_onoff.rc and ganymed_wobble.rc
|
---|
196 |
|
---|
197 | - ganymed: The first version of MFMagicCuts has been released
|
---|
198 |
|
---|
199 | - ganymed: the Conc1 plot was incorrectly scaled in MHVsSize
|
---|
200 |
|
---|
201 | - ganymed, sponde: There are two new options to determin the number
|
---|
202 | of bins for the signal region (NumBinsSignal) and the number of
|
---|
203 | total bins (NumBinsTotal) in the MHThetaSq histogram
|
---|
204 |
|
---|
205 | - ganymed: optimized palettes for MHDisp
|
---|
206 |
|
---|
207 | - ganymed: Fixed an important bug when using ThetaSq as fit function:
|
---|
208 | The result for the sigma of the gauss(sqrt(x)) fit was a factor
|
---|
209 | sqrt(2) to large
|
---|
210 |
|
---|
211 | - ganymed: The false source plot (MHDisp) is now based on Disp
|
---|
212 | and a background model determined in the first loop is
|
---|
213 | subtracted
|
---|
214 |
|
---|
215 | - ganymed: MFMagicCuts are now available in the cvs. The correct
|
---|
216 | solution for the disp ambiguity problem is now calculated using
|
---|
217 | the third moment. The third moment cut therefor is skipped.
|
---|
218 |
|
---|
219 | - ganymed: Output now contains "Disp [MParameterD]" which sign is
|
---|
220 | already determined by the third moment along the major axis and
|
---|
221 | so its actual sign is aligned along the major axis of the shower.
|
---|
222 |
|
---|
223 | - ganymed: If starguider data is available it is taken into account
|
---|
224 | when calculating the source position. This is especially important
|
---|
225 | for wobble data at high zenith angles and culmination data.
|
---|
226 |
|
---|
227 | - ganymed: If available the starguider data is taken into account as
|
---|
228 | good as it is possible without a starguider calibration. To switch
|
---|
229 | it off add
|
---|
230 | MPointingDevCalc.MaxAbsDev: -1
|
---|
231 | to your ganymed.rc
|
---|
232 |
|
---|
233 | - sponde: the zenith angle distribution is now weighted instead of
|
---|
234 | choosen by default. This gurantees higher statistics in the highest
|
---|
235 | and lowest energy bins. To switch this behaviour off use...
|
---|
236 |
|
---|
237 | - sponde: now automatically displays the energy threshold
|
---|
238 |
|
---|
239 |
|
---|
240 |
|
---|
241 | *** Version 0.9.3 (2005/06/03)
|
---|
242 |
|
---|
243 | - general: MMcEvt now derived from MMcEvtBasic which should
|
---|
244 | have no influence on compatibility with older camera files
|
---|
245 |
|
---|
246 | - general: Implemented a new option to MReadReports which allows
|
---|
247 | to force reading of the first event of some trees (eg. Drive-tree)
|
---|
248 | before any other tree.
|
---|
249 |
|
---|
250 | - general: Made a fix to MPointingPosCalc which assumes that the
|
---|
251 | run-type is real-data if Process is called before ReInit, such
|
---|
252 | that also the very first Drive-events in a run are treated
|
---|
253 | correctly.
|
---|
254 |
|
---|
255 | - shoplot now displays the filename in the title bar of the window
|
---|
256 |
|
---|
257 | - merpp: new options: --auto-time-start --auto-time-stop which
|
---|
258 | allow to cut updating with slow-control at the start- or
|
---|
259 | (previousle --auto-time only allowed: and) stop-time of
|
---|
260 | the run stored in the runheader.
|
---|
261 |
|
---|
262 | - callisto: changed default of fgFallTimeHiGain in
|
---|
263 | MExtractTimeAndChargeSpline from 1.5 to 0.5. 0.5 was
|
---|
264 | already set as default in callisto_Dec04Jan05.rc
|
---|
265 |
|
---|
266 | - callisto: the digital filter (MExtractTimeAndChargeDigitalFilter)
|
---|
267 | now changes the filename for new weights automatically for
|
---|
268 | cosmics, MC and for different calibration colors.
|
---|
269 |
|
---|
270 | - callisto: a problem with the order of some code cause the
|
---|
271 | name of the weights file in MPedestalY2 to be ignored.
|
---|
272 | Wrongly the calibration_UV weights were used instead
|
---|
273 | of the cosmics weights set in callisto.rc.
|
---|
274 |
|
---|
275 | - callisto: should allow ct1 pulser data when the color is
|
---|
276 | explicitly set also for pretty new runs
|
---|
277 |
|
---|
278 | - callisto: a new option (MCalibrateData.ScaleFactor) allows
|
---|
279 | to introduce an additional scale factor (should be around 1)
|
---|
280 | to adapt for slight deviations in different extractors from
|
---|
281 | the MC calibration. For MC calibrations the scale factor
|
---|
282 | is fixed to 1
|
---|
283 |
|
---|
284 | - callisto: MFCosmics should handle very high signals a bit
|
---|
285 | more accurate now
|
---|
286 |
|
---|
287 | - callisto: when calculating the mean pedestal rms for different
|
---|
288 | pixel sizes or sectors also kUnsuitableEvt is now taken into
|
---|
289 | account - not only kUnsuitableRun
|
---|
290 |
|
---|
291 | - callisto: '-raw' option is now the default
|
---|
292 |
|
---|
293 | - callisto: A dead pixel check has been implemented in MJPedestalC2.
|
---|
294 | This has the advantage that mean values in the calibration (eg
|
---|
295 | arrival times) are calculated more accuratly.
|
---|
296 |
|
---|
297 | - callisto: In the resource file callisto_Dec04Jan05.rc
|
---|
298 | MJPedestalY2.ExtractWinRight has been reduced from 4.0 to 2.0
|
---|
299 |
|
---|
300 | - callisto: new Hi-/Lo-Gain intercalibration constants
|
---|
301 | hilocalib_sp1.root and hilocalib_sp1_mc.root
|
---|
302 |
|
---|
303 | - callisto: changed default for MJPedestalY2.MaxEvents
|
---|
304 | from 2000 to 5000 like in callisto_Dec04Jan05.txt
|
---|
305 |
|
---|
306 | - callisto: in MCalibrationChargeCalc the limit fgPheErrLowerLimit
|
---|
307 | has changed from 9.0 to 6.0. This is necessary to exclude two very
|
---|
308 | ringing pixels in September which - when kept - destroy the image
|
---|
309 | cleaning around them (Markus G.)
|
---|
310 |
|
---|
311 | - callisto: (!) The Muon analysis of all data taken so far has
|
---|
312 | suggested that different extractors give slightly different
|
---|
313 | absolute results after calibration, due to there different
|
---|
314 | handling of the calibration- and cosmics pulse shape. Although
|
---|
315 | the over all calibration seems to be a bit to pesimistic (or
|
---|
316 | the MC seems to be a little bit - 3-5% - too much attenuated).
|
---|
317 | There for correction factors have been introduced which correct
|
---|
318 | the calibration constants by
|
---|
319 | 0.956937799 for Digital Filter (callisto.rc)
|
---|
320 | and
|
---|
321 | 0.904159132 for Spline (callisto_Dec04Jan05.rc)
|
---|
322 | calibration. The main advantage is, that both data types can
|
---|
323 | be easily analysed together and compared to the same MC sample.
|
---|
324 | The factors are choosen such, that the reference is now a
|
---|
325 | Monte Carlo sample calibrated with Digital Filter (callisto.rc)
|
---|
326 |
|
---|
327 | - star: fixed a bug which caused the first bin of the histograms
|
---|
328 | vs time to disapear in PostProcess. This gave wrong results
|
---|
329 | on the screen. The output and all following programs not
|
---|
330 | directly accessing the histograms haven't been affected
|
---|
331 |
|
---|
332 | - star, ganymed: Made sure that always the first Drive-tree event
|
---|
333 | is read and Processed before the first data event was read.
|
---|
334 |
|
---|
335 | - ganymed: implemented the possibility to replace the standard
|
---|
336 | false source plot with a different one. For example: If
|
---|
337 | you want to use a Disp based FS plot use the resource:
|
---|
338 | NameHistFS: MHDisp
|
---|
339 | For details about the requirements of these plots look
|
---|
340 | at the corresponding classes
|
---|
341 |
|
---|
342 | - MJOptimize: For On/Off and Wobble optimization MJOptimize
|
---|
343 | has been replaced by MJOptimizeCuts. To use MHThetaSq instead
|
---|
344 | of MHAlpha call MJOptimizeCuts("MHThetaSq"). Make sure in this
|
---|
345 | case MAlphaFitter is setup correctly. For On-Only optimization
|
---|
346 | MJOptimize has been Replaced by MJOptimizeCuts, too. Call
|
---|
347 | RunOn() instead of Run(). For energy estimation MJOptimize
|
---|
348 | has been replaced by MJOptimizeEnergy
|
---|
349 |
|
---|
350 | - sponde: The input MC spectrum can now be weighted to fake a
|
---|
351 | different spectrum. This is done via MMcSpectrumWeight. For
|
---|
352 | more details see the class description and sponde.rc
|
---|
353 |
|
---|
354 | - sponde: The paremeter comparsion plots are not scaled by
|
---|
355 | their entries anymore. Instead the MC plot is scaled by using
|
---|
356 | the result spectrum of the analysis. If the input MC spectrum
|
---|
357 | and the result spectrum has different slopes the absolut
|
---|
358 | normalization is normally wrong.
|
---|
359 |
|
---|
360 |
|
---|
361 |
|
---|
362 | *** Version 0.9.2 (2005/05/20)
|
---|
363 |
|
---|
364 | - general: Changed the default paths for calibrated data and image
|
---|
365 | files. (The implemented access to these files doesn't yet exist)
|
---|
366 |
|
---|
367 | - general: support for MRunIter has been removed from the job classes
|
---|
368 | (use the setter functions of MSeqeunce instead)
|
---|
369 |
|
---|
370 | - general: ProcessFile has been renamed to Process in all job classes,
|
---|
371 | because ProcessFile is missleading
|
---|
372 |
|
---|
373 | - general: The storage of the palette in MHCamera is now possible
|
---|
374 |
|
---|
375 | - general: new bits describing unsuitable and unreliable pixels have
|
---|
376 | been introduced in MBadPixelsPix: kPreviouslyExcluded,
|
---|
377 | kDeadPedestalRms, kFluctuatingArrivalTimes
|
---|
378 |
|
---|
379 | - general: fixed reading of CC-REPORTS (weather data) for Arehucas file
|
---|
380 | versions newer than V200404070
|
---|
381 |
|
---|
382 | - general: support for cc file versions newer than V200504130. Added
|
---|
383 | support for active loads (MCameraActiveLoad) and central pixel
|
---|
384 | (MCameraCentralPixel)
|
---|
385 |
|
---|
386 | - general: added new histograms for image parameters versus size
|
---|
387 | (MHVsSize)
|
---|
388 |
|
---|
389 | - general: The eventloop now automatically calls PrintStatistics
|
---|
390 |
|
---|
391 | - Status Display: Improved support for printing:
|
---|
392 | + A default can now be set in .rootrc (for more details see
|
---|
393 | MStatusDisplay::PrintPS)
|
---|
394 | + A print dialog is opened so that printer and command line
|
---|
395 | can be canged
|
---|
396 |
|
---|
397 | - showlog: improved such that it handles different verbosity levels
|
---|
398 | more accurate now. This mean you can suppress output when
|
---|
399 | using showlog.
|
---|
400 |
|
---|
401 | - showplot: improved
|
---|
402 | + The new graphics formats have been implemented
|
---|
403 | (pdf, svg, png, jpg and xpm)
|
---|
404 | + Implemented an interface for printing. Because you can change
|
---|
405 | the printing command from the command line you can use all
|
---|
406 | the nice postscript tool. To print a booklet for example call:
|
---|
407 | showplot -b --print --print-cmd="cat %f" filename.root | lpr
|
---|
408 | showplot -b --print --print-cmd="psbook %f | psnup -2 | lpr" filename.root
|
---|
409 | showplot -b --null --print --print-cmd="psbook %f" filename.root > book.ps
|
---|
410 |
|
---|
411 | - callisto: fixed a bug in the recognition of the calibration bit
|
---|
412 | pattern. Concerns only intensity calibration. (The strength of the
|
---|
413 | intensity has been updated in some cases)
|
---|
414 |
|
---|
415 | - callisto: add a filter against PIN Diode events when running over
|
---|
416 | calibration runs since some of the recent calibration runs have
|
---|
417 | been taken with Pin Diode.
|
---|
418 |
|
---|
419 | - callisto: added support for the runs 39942, 39944, 44834, 39941,
|
---|
420 | 39943, 44833 in the calibration (MCalibColorSet)
|
---|
421 |
|
---|
422 | - callisto: MJCalibration.MHCalibrationChargeCam.ProbLimit has
|
---|
423 | been set to 1e-18 in callisto_Dec04_Jan05.rc
|
---|
424 |
|
---|
425 | - callisto: in callisto_Dec04Jan05.rc: set value for
|
---|
426 | MJPedestalY2.MaxEvents from 2000 to 5000 to get better
|
---|
427 | statistics for the calculation of the mean pulse time
|
---|
428 | of the cosmisc
|
---|
429 |
|
---|
430 | - callisto: the charge limit in the calibration has been raised
|
---|
431 | from 2.5 to 4.5
|
---|
432 |
|
---|
433 | - callisto: new setup read from callisto.rc
|
---|
434 | + MCalibCalcFromPast.fNumEventsDump
|
---|
435 | + MHCalibrationChargeCam.NumHiGainSaturationLimit
|
---|
436 | + MHCalibrationChargeCam.NumLoGainSaturationLimit
|
---|
437 |
|
---|
438 | - callisto: MExtractTimeAndChargeSpline extractor:
|
---|
439 | + The integration ranges were shifted by 0.2 FADC slices to the right.
|
---|
440 | + unreliable handling of floating point values caused different
|
---|
441 | results on different platform or with different compiler options:
|
---|
442 | The new algorithm is numerically exact and more accurate because
|
---|
443 | it doesn't calculate the integration position by multiple times
|
---|
444 | adding the step-size (which results in numerical uncertanties
|
---|
445 | exspecially if multiplied with large numbers)
|
---|
446 | + A lot of fixes have been introduced which effects integrating the
|
---|
447 | spline at the edges of the valid range. In this case any memory
|
---|
448 | was randomly accessed. This behaviour can be tested replacing
|
---|
449 | all MArrayF by TArrayF which perform a range check (but of course
|
---|
450 | they are a lot slower)
|
---|
451 | ! No result obtained with the Spline before can be trusted! Due to
|
---|
452 | random memory access it might by completely random!
|
---|
453 |
|
---|
454 | - callisto: set new defaults in MExtractTimeAndChargeDigitalFilter:
|
---|
455 | + extraction range in the high gain to 4.
|
---|
456 | + weights file to cosmics_weights46.dat
|
---|
457 |
|
---|
458 | - callisto:
|
---|
459 | + introduce the check for fluctuating arrival times.
|
---|
460 | + set charge limit to from 2.5 to 4.5
|
---|
461 | + introduce asymmetric exclusion due to "deviating number of phes":
|
---|
462 | Default: -9.0 +4.5
|
---|
463 | + make deviating number of phes unsuitable (see David's findings).
|
---|
464 |
|
---|
465 | - callisto: fixed the display of unsuitable pixels. The old change
|
---|
466 | to a real profile in MHCamera broke it.
|
---|
467 |
|
---|
468 | - callisto: The cosmics filter is used in MJCalibration now
|
---|
469 | independant of the pulser color (formaly it was used only for
|
---|
470 | CT1-pulser data). The threshold of number of max empty pixels
|
---|
471 | has been raised from 2% to 5% in MJCalibration. The maximum
|
---|
472 | fraction of rejected event is 50% otherwise the calibration has
|
---|
473 | failed. The filter now ignores unsuitable pixels.
|
---|
474 | Setup the filter from callisto.rc using "ContCosmics"
|
---|
475 | (see MFCosmics::ReadEnv)
|
---|
476 |
|
---|
477 | - callisto: changed default for fgOffsetFromLogain back
|
---|
478 | from -2.8 to -1.8 in digital filter.
|
---|
479 |
|
---|
480 | - callisto: for the common extractors
|
---|
481 | + MExtractFixedWindow
|
---|
482 | * MExtractTimeAndChargeSlidingWindow
|
---|
483 | * MExtractTimeAndChargeSpline
|
---|
484 | * MExtractTimeAndChargeDigitalFilter
|
---|
485 | the hi- and lo-gain reolution is stored in fResolutionPerPheHiGain
|
---|
486 | and fResolutionPerPheLoGain
|
---|
487 |
|
---|
488 | - callisto: Updated the hi-/lo-gain intercalibration constants
|
---|
489 | hilocalib_sp1.root, hilocalib_df46_mc.root, hilocalib_df4.root,
|
---|
490 | hilocalib_df6.root
|
---|
491 |
|
---|
492 | - callisto: The default lo-gain extraction window for the
|
---|
493 | MExtractTimeAndChargeSlidingWindow extractor has been increased
|
---|
494 | from 6 to 8 to take the stretch of the pusle into account
|
---|
495 |
|
---|
496 | - callisto (!!!): fixed an important bug in the setting of the
|
---|
497 | incoming pedestal pointer to the signal extractor extracting
|
---|
498 | pedestals. This bug caused the pedestals not to be subtracted
|
---|
499 | correctly in the calibration afterwards. The effect was about 10%
|
---|
500 | too high conversion factors for the digital filter and the spline
|
---|
501 | and more than 40% for the sliding window.
|
---|
502 | The bug existed since end of February! (Markus G.)
|
---|
503 |
|
---|
504 | - star: added muon support to star. A new tab "MHMuonPar" is
|
---|
505 | displayed. The lower right plot is an estimate of the point spread
|
---|
506 | function. A reference value is displayed. To get the real PSF
|
---|
507 | you must compare with MC. The setup for the muon analysis
|
---|
508 | is done in star.rc. More informations can be found in
|
---|
509 | MHSingleMuon and MHCalibParCalc
|
---|
510 |
|
---|
511 | - star: The weather data is now displayed in star
|
---|
512 |
|
---|
513 | - star: MEventRateCalc handles the calculation of the event rate more
|
---|
514 | accurate now in case of the start of a new run inside a sequence
|
---|
515 |
|
---|
516 | - ganymed: a bug in MSrcPosCalc has been fixed (The changes were taken
|
---|
517 | from a bugfix of Wolfgang to Loc0LocToCam; Wolfgang: the results are
|
---|
518 | changed only minimally
|
---|
519 |
|
---|
520 | - ganymed: (MJCut and MJOptimize) now displayes the number of
|
---|
521 | excess events versus size. The energy estimation is done in
|
---|
522 | MJSpectrum (sponde)
|
---|
523 |
|
---|
524 | - ganymed: got support for using other variables than Alpha, eg. Theta.
|
---|
525 | Therefor you need a class deriving from MHAlpha which supports
|
---|
526 | this variable (one is already existing: MHTheta, which is now the
|
---|
527 | default in ganymed). It is setup through ganymed.rc
|
---|
528 |
|
---|
529 | - added a full featured spectrum program (sponde) which reads
|
---|
530 | ganymed output and monte carlos and compiles a spectrum
|
---|
531 |
|
---|
532 |
|
---|
533 |
|
---|
534 | *** Version 0.9.1 (2005/04/14)
|
---|
535 |
|
---|
536 | - Fix bug on the arrival time reconstruction when using Digital
|
---|
537 | Filter (in some marginal cases (10%) times were reconstructed shifted
|
---|
538 | by 0.2 slices)
|
---|
539 |
|
---|
540 | - all executables now return 2 where in previous versions -1 has
|
---|
541 | been returned (gave problems with shell-scripts)
|
---|
542 |
|
---|
543 | - the Hi-/Lo-Gain intercalibration for monte carlo files is now
|
---|
544 | also done with a intercalibration input file
|
---|
545 |
|
---|
546 | - a bug in the time fine adjustment of the digital filter has been fixed
|
---|
547 |
|
---|
548 | - a lot of small fixes to calling TPad::Divide with a margin==0
|
---|
549 |
|
---|
550 | - MStatusDisplay now shows the memory usage
|
---|
551 |
|
---|
552 | - added a memory leak statistic after the eventloop
|
---|
553 |
|
---|
554 | - MHadronness replaced by MParameterD
|
---|
555 |
|
---|
556 | - MEnergyEst replaced by MParameterD
|
---|
557 |
|
---|
558 | - wobble mode can now be switched on from the data-set
|
---|
559 |
|
---|
560 | - switched on bad pixel detection for a pedestal level
|
---|
561 | which is more than 5 times the variance
|
---|
562 |
|
---|
563 | - Fixed default paths to be correct for the new data center
|
---|
564 |
|
---|
565 | - Fixed handling of drive data. The pointing position in now
|
---|
566 | copied to MPointingPos inside star for real and MC events
|
---|
567 |
|
---|
568 | - made sure, that the sequences in a dataset are sorted by
|
---|
569 | their number to ensure the correct synchronization
|
---|
570 |
|
---|
571 | - added all resource files necessary to handle spline extraction
|
---|
572 | of signal for the late 2004 and the early 2005 data
|
---|
573 |
|
---|
574 | - update the reference lines for the december data
|
---|
575 |
|
---|
576 | - changed default for fgHiGainFirst from 2 to 0 in spline extractor
|
---|
577 | This is important for the Dec. and Jan. data where the calibration
|
---|
578 | pulse position changes much.
|
---|
579 |
|
---|
580 | - changed default for fgOffsetFromLogain from -1.8 to -2.8 in digital
|
---|
581 | filter. This corrects only an defective extraction of the MC at
|
---|
582 | low-gain signals lower than 90 phes.
|
---|
583 |
|
---|
584 | - fixed some slowdown in calibrating data with interleaved events from
|
---|
585 | Jan and Dec. As a workaround made the pretty palette the default.
|
---|
586 | The inverse Deep Blue Sea has a bug which slows down long calibration
|
---|
587 | runs a lot.
|
---|
588 |
|
---|
589 | - implemented new values from new starguider report as defined
|
---|
590 | in TDAS00-07 V7.1 (eg SkyBrighness)
|
---|
591 |
|
---|
592 | - Fixed the formerly wrong unit of azimuth and zenith angle deviation
|
---|
593 | in starguider report (If you merpp the same reports with this version
|
---|
594 | you'll get the correct units (arcmin) but a different result
|
---|
595 | than with old versions (wrong units))
|
---|
596 |
|
---|
597 | - Now the status display can also write PNG, JPEG and XPM (other file
|
---|
598 | formats are still unsupported by root)
|
---|
599 |
|
---|
600 | - added a lot of scripts and macros in directory datacenter used
|
---|
601 | for automatic processing
|
---|
602 |
|
---|
603 |
|
---|
604 |
|
---|
605 | *** Version 0.9 (2005/03/23)
|
---|
606 |
|
---|
607 | - Calibration is now done autmatically into photo-electrons like
|
---|
608 | decided by the Collaboration Board
|
---|
609 |
|
---|
610 | - Reference lines in the display can be read from resource file
|
---|
611 |
|
---|
612 | - Interlaced calibration events can be handled by callisto
|
---|
613 |
|
---|
614 | - Hi-Gain vs. Lo-Gain calibration constants can be calculated
|
---|
615 | and applied in callisto.
|
---|
616 |
|
---|
617 | - class MJCalibTest can be called by callisto
|
---|
618 |
|
---|
619 | - callisto can now run with three data types: rawdata, rootdata, MC
|
---|
620 |
|
---|
621 | - added two classes mreport/MReportStarguider.cc and
|
---|
622 | mreport/MReportStarguider.h for implementing starguider-data
|
---|
623 |
|
---|
624 | - the output of merpp-update now contains starguider information:
|
---|
625 | MReportStarguider and MTimeStarguider
|
---|
626 |
|
---|
627 | - Fixed bug in MHHadronness.cc which made that the displayed Q-factor
|
---|
628 | values were lower than they should. This was more visible for high
|
---|
629 | energy (Size) events.
|
---|
630 |
|
---|
631 | - Made MExtractTimeAndChargeDigitalFilter the default for callisto
|
---|
632 |
|
---|
633 | - added a new loop to callisto to support the correct extraction of
|
---|
634 | the pedestal and pedestal rms through the signal extractor
|
---|
635 |
|
---|
636 | - added class to perform fourier tranformation of a hexagonal structure
|
---|
637 | (MHexagonalFT)
|
---|
638 |
|
---|
639 | - added class to perform fourier tranformation of a hexagonal structure
|
---|
640 | in a tasklist (MHexagonalFTCalc) example: hft.C
|
---|
641 |
|
---|
642 | - added class to enhance the MCerPhotEvt from the Magic camera geometry
|
---|
643 | MGeomCamMagic to a enhanced geometry MGeomCamMagicXT having only
|
---|
644 | small pixels, example: extendcam.C
|
---|
645 |
|
---|
646 | - added possibility to write data to memory (TTree) using MWriteRootFile
|
---|
647 |
|
---|
648 | - added possibility to read a TTree stored only in memory by MReadTree
|
---|
649 |
|
---|
650 | - new classes to deal with the interleaved calibration events:
|
---|
651 | MTriggerPattern, MTriggerPatternDecode and MFTriggerPattern
|
---|
652 |
|
---|
653 | - implemented filters to callisto to skip calibration events
|
---|
654 |
|
---|
655 | - changed callisto to calculate three kinds of pedestals and pedestal rms:
|
---|
656 | + fundamental pedestal (MPedPhotFundamental): extracted directly from
|
---|
657 | the slices by statistics
|
---|
658 | + pedestal from extractor (MPedPhotFromExtractor): extracted with the
|
---|
659 | signal extractor without randomization
|
---|
660 | + random pedestal from extractor (MPedPhotFromExtractorRndm): extracted
|
---|
661 | with the signal extractor with randomization (extraction window is
|
---|
662 | randomly fixed)
|
---|
663 | The three kind of pedestal is not yet implemented (for speed reasons) as
|
---|
664 | long as nobody really needs it:
|
---|
665 | + pedestal from extractor with randomizatiuon (MPedPhotFromExtractorRndm):
|
---|
666 | extracted with the signal extractor with randomization
|
---|
667 |
|
---|
668 | - callisto now finds the pulse position in the data automatically
|
---|
669 |
|
---|
670 | - implemented data reduction in calibrated data by reducing the precision
|
---|
671 | of the stored floating point values (pedestal, rms and signal) to
|
---|
672 | roughly 0.5%
|
---|
673 |
|
---|
674 | - fixed showplot to make file format conversion (eg. converting a
|
---|
675 | status display stored in a root file into a postscript file) in
|
---|
676 | batch mode possible:
|
---|
677 | showplot -b --save-as-ps[=outfile.ps] infile.root
|
---|
678 |
|
---|
679 | - Allow class names as part of filter rules, eg
|
---|
680 | (MFSupercuts) && (MHillas.fSize>100)
|
---|
681 |
|
---|
682 | - fixed a lot of stuff to allow all programs to process MonteCarlo
|
---|
683 | camera files.
|
---|
684 |
|
---|
685 | - enhanced possibility to debug reading of resource file
|
---|
686 |
|
---|
687 | - MDataChain should handle priorities of operator more
|
---|
688 | accurate now
|
---|
689 |
|
---|
690 | - completely revised the container in which the signal is stored
|
---|
691 | MCerPhotEvt/Pix, MArrivalTime --> MSignalCam/Pix
|
---|
692 | * the new implementation is faster and
|
---|
693 | * needs less storage space
|
---|
694 |
|
---|
695 | - FIRST version which can process Monte Carlos through the
|
---|
696 | whole chain of programs (callisto, star, etc)
|
---|
697 |
|
---|
698 | - implemented new image parameters for the border length of
|
---|
699 | the shower image (MNewImagePar2)
|
---|
700 |
|
---|
701 | - implemented wobble-mode in ganymed
|
---|
702 |
|
---|
703 | - new class (MJOptimize) taking care of all optimization processes
|
---|
704 |
|
---|
705 |
|
---|
706 |
|
---|
707 | *** Version 0.8.6 (2004/10/05)
|
---|
708 |
|
---|
709 | - New combined signal and time extractor
|
---|
710 | MExtractTimeAndChargeDigitalFilter
|
---|
711 |
|
---|
712 | - The Report for the trigger section in the CC run summary has been
|
---|
713 | updated, and now the IPRs (Individual Pixel Rates) are available.
|
---|
714 |
|
---|
715 | - new macros for database interaction: filldotrun.C, filldotrbk.C
|
---|
716 |
|
---|
717 | - added new program which can convert colored output which was redirected
|
---|
718 | into a file back into colored text (for example to display it with
|
---|
719 | more): showlog
|
---|
720 |
|
---|
721 | - added new program to display an MStatusArray of plots (stored with
|
---|
722 | MStatusDisplay) from a file: showplot
|
---|
723 |
|
---|
724 | - Added support for Sequences (MSequence). Sequences are blocks of run
|
---|
725 | files containing the same calibration and belonging to the same
|
---|
726 | source
|
---|
727 |
|
---|
728 | - Added a new task (MTaskEnv) which can be used in setup files to switch
|
---|
729 | between different tasks (for example to choose a signal extractor)
|
---|
730 |
|
---|
731 | - Implemented automatic file splitting in MWriteRootFile
|
---|
732 |
|
---|
733 | - After image cleaning an island index is assigned to all used pixels.
|
---|
734 | The index corresponds to the order of the islands in size.
|
---|
735 |
|
---|
736 | - added a cleaning which takes signal height _and_ arrival time into
|
---|
737 | account: probability cleaning (for more details see MImgCleanStd)
|
---|
738 |
|
---|
739 | - added a cleaning which takes takes the absolute number of photons
|
---|
740 | times the area ratio as cleaning level
|
---|
741 | (for more details see MImgCleanStd)
|
---|
742 |
|
---|
743 | - Changed calculation of image parameters such, that it can be done
|
---|
744 | for all used pixels or the pixels with a defined island index only
|
---|
745 |
|
---|
746 | - implemented new image parameters displaying the number of islands,
|
---|
747 | saturated hi-gain and lo-gain pixels (MImagePar, MHImagePar)
|
---|
748 |
|
---|
749 | - event display in executable changed to support also calibrated files
|
---|
750 | (done with MJCalibrateSignal)
|
---|
751 |
|
---|
752 | - added program doing the calibration and the signal extraction
|
---|
753 | and signal calibration: callisto Most part of the setup is done
|
---|
754 | by a resource file: callisto.rc
|
---|
755 |
|
---|
756 | - implemented support for pixels with negative IDs (Raw file format
|
---|
757 | version 4)
|
---|
758 |
|
---|
759 | - implemented an new option in merpp (--auto-time) to get the time
|
---|
760 | range for cc and/or caco data from the run header of the raw data
|
---|
761 |
|
---|
762 | - New star-program (star and MJStar). Taking calibrated data from
|
---|
763 | callisto/MJCalibrateSignal as input. The setup is done through
|
---|
764 | a resource file: star.rc
|
---|
765 |
|
---|
766 | - Added possibility to setup the eventloop in the mars-executable
|
---|
767 | Camera Display by a resource file: mars.rc
|
---|
768 |
|
---|
769 | - The the mars-executable Camera Display can now also read
|
---|
770 | calibrated data files written by callisto/MJCalibrateSignal
|
---|
771 |
|
---|
772 | - Added a new class which can calculate the source position in
|
---|
773 | the camera from a pointing model known to be correct and
|
---|
774 | the pointing model used for observations (MSrcPosFromModel)
|
---|
775 |
|
---|
776 | - added a new version of the class calculating the effective on-time
|
---|
777 | MHEffectiveOnTime. It unifies the old classes MHEffOnTime,
|
---|
778 | MHEffOnTimeTime, MHEffOnTimeTheta, MHTimeDiff, MHTimeDiffTime and
|
---|
779 | MHTimeDiffTheta.
|
---|
780 |
|
---|
781 | - added the possibility to count how often a signal is above (or
|
---|
782 | below) a certain threshold in MHCamEvent and MHCamEventRot (this
|
---|
783 | can replace MHTriggerLvl0)
|
---|
784 |
|
---|
785 | - added ore convinient ways to set the axis-titles of your histograms
|
---|
786 | in your macro to some MH-classes like: MH3, MHVsTime, MHSectorVsTime,
|
---|
787 | MHPixVsTime, MHVsTime, MHCamEvent and MHCamEventRot
|
---|
788 |
|
---|
789 |
|
---|
790 |
|
---|
791 | *** Version 0.8.5 (2004/08/06)
|
---|
792 |
|
---|
793 | - new Signal Extractors: MExtractFixedWindowSpline
|
---|
794 | and MExtractAmplitudeSpline
|
---|
795 |
|
---|
796 | - implementes interleave in merpp to be able to merpp parts of a file
|
---|
797 |
|
---|
798 | - implemented force-functionality to merpp
|
---|
799 |
|
---|
800 | - star display to display star catalogs (MAstroCatalog)
|
---|
801 |
|
---|
802 | - star display to 'mirror' stars to the camera (MAstroCamera)
|
---|
803 |
|
---|
804 | - implemented a new cleaning option which allows cleaning scaled with
|
---|
805 | the real ratio of the rms depending on the pixel size, not only the
|
---|
806 | square root of the pixelsize (MImgCleanStd, MCameraData)
|
---|
807 |
|
---|
808 | - removed obsolete MBlind* classes
|
---|
809 |
|
---|
810 | - Signal extractor taking the AB flag into account implemented (this makes
|
---|
811 | an odd number of slices for signal extraction possible
|
---|
812 | (MExtractSignalABcorr)
|
---|
813 |
|
---|
814 | - implemented a class extracting the pedestal from the raw-data (events)
|
---|
815 | itself using empty lo-gain (MpedCalcFromLoGain)
|
---|
816 |
|
---|
817 | - Added mean values to MPedPhotCam
|
---|
818 |
|
---|
819 | - Added Makefile for Darwin (this OS is NOT officially supported!)
|
---|
820 |
|
---|
821 |
|
---|
822 |
|
---|
823 | *** Version 0.8.4 (2004/04/19)
|
---|
824 |
|
---|
825 | - new fast arrival time extractor using cubic splines:
|
---|
826 | MExtractTimeFastSpline
|
---|
827 |
|
---|
828 | - implementes multi-argument support in MDataChain
|
---|
829 | ("pow(a, b)")
|
---|
830 |
|
---|
831 | - implemented double reference support in MDataChain
|
---|
832 | ("MCameraLV.fPowerSupplyA.fVoltagePos5V")
|
---|
833 |
|
---|
834 | - added support in MF for expressiond like
|
---|
835 | "MHillas.fWidth<2*<MHillas.fLength"
|
---|
836 |
|
---|
837 | - MDataChain is now able to support variables like [0], [1], ...
|
---|
838 | which can be used in fit functions as parameters. The interface
|
---|
839 | is implemented through the new virtual function
|
---|
840 | MParContainer::SetVariables
|
---|
841 |
|
---|
842 | - added new class MArrivalTimeCam/MArrivalTimePix:
|
---|
843 | Storage containers to hold the ArrivalTime of the camera/pixel
|
---|
844 |
|
---|
845 | - added new classes for the calibration of relative arrival times:
|
---|
846 | MCalibrationRelTimePix and MCalibrationRelTimeCam
|
---|
847 |
|
---|
848 | - added new classes to extract the signal of the blind pixel and the
|
---|
849 | PIN Diode separately: MExtractBlindPixel and MExtractPINDiode
|
---|
850 |
|
---|
851 | - added new classes for the bad-pixels treatment (MBadPixels*)
|
---|
852 | which are more powerfull than the old ones (MBlindPixel*)
|
---|
853 | and will replace them.
|
---|
854 |
|
---|
855 | - added filter against cosmics: MFCosmics
|
---|
856 |
|
---|
857 | - added new class MArrivalTimeCalc2:
|
---|
858 | Calculates the arrival time as the signal weighted mean of the time
|
---|
859 | slices in the maximum window
|
---|
860 |
|
---|
861 | - added a new macro call pointspreadfucntion.C that fits with a 2D
|
---|
862 | gaussian the DC spot for an star. It gives you the RMS of
|
---|
863 | the PSF and the center of the star, very useful for misspointing
|
---|
864 | studies.
|
---|
865 |
|
---|
866 | - added support for multi-telescope camera files. Added classes
|
---|
867 | MStereoCalc and MStereoPar, classes to calculate and store shower
|
---|
868 | parameters calculated from the data of two telescopes, for the MC
|
---|
869 | studies regarding the MAGIC clone.
|
---|
870 |
|
---|
871 | - added MMcCalibrationCalc, MMcCalibrationUpdate, classes to obtain
|
---|
872 | MC data calibrated in photons instead of ADC counts.
|
---|
873 |
|
---|
874 | - added three macros to show the calibration and analysis chain of
|
---|
875 | MC data. The macro starmc.C does both calibration and analysis, producing
|
---|
876 | an output containing Hillas parameters for each event. The macro
|
---|
877 | mccalibrate.C does just the calibration and writes out a file containing
|
---|
878 | pixel information in photons instead of FADC data. The macro starmc2.C
|
---|
879 | reads in such a file and produces an output with Hillas parameters.
|
---|
880 |
|
---|
881 | - added MPedPhotCalc to compute pedestals in units of photons, see
|
---|
882 | macro pedphotcalc.C
|
---|
883 |
|
---|
884 | - added all class to perform the calibration, see macro calibration.C
|
---|
885 |
|
---|
886 | - added class MFFT to perform Fast Fourier Transforms
|
---|
887 |
|
---|
888 | - added class MSimulatedAnnealing to perform simulated annealing
|
---|
889 | minimizations
|
---|
890 |
|
---|
891 | - added new macro bootcampstandardanalysis.C which holds the skeleton
|
---|
892 | of the analysis chain discussed in the december bootcamp.
|
---|
893 |
|
---|
894 | - added support for DAQ raw data file format V2
|
---|
895 |
|
---|
896 | - implemented an arbitrary time stamp for the events from raw-data
|
---|
897 | files with file version<3. It is calculated from the run number,
|
---|
898 | the date of start and the FADC clock tick from the first module
|
---|
899 |
|
---|
900 | - implemented the correct decoding of the event time-stamp
|
---|
901 | coming from the DAQ for raw-data files with file-version>2
|
---|
902 |
|
---|
903 | - added a new classes storing the pedestals in units of photons:
|
---|
904 | MPedPhotPix, MPedPhotCam
|
---|
905 |
|
---|
906 | - added support for DC current files from the camera control
|
---|
907 |
|
---|
908 | - added support for start- and stop-time when merpping report files
|
---|
909 |
|
---|
910 | - added MReportCC storing the weather data from the CC-REPORT
|
---|
911 |
|
---|
912 | - added class to fill trainings and test matrices (MTFillMatrix)
|
---|
913 |
|
---|
914 | - added a filter performing a software trigger (MFSoftwareTrigger)
|
---|
915 |
|
---|
916 | - Added classes to perform parts of the standard analysis (Jobs):
|
---|
917 | + MJPedestals
|
---|
918 | + MJCalibration
|
---|
919 | + MJExtractSignal
|
---|
920 | Note: All of them are preliminary!
|
---|
921 |
|
---|
922 | - Added Iterator to iterate over files giving only the run-number
|
---|
923 |
|
---|
924 | - Added class (MHSectorVsTime) and example (sectorvstime.C) to plot
|
---|
925 | the evolution of a sector vs time
|
---|
926 |
|
---|
927 |
|
---|
928 |
|
---|
929 | *** Version 0.8.3 (2003/12/05)
|
---|
930 |
|
---|
931 | - adapted Random Forest classes to allow the use with MC
|
---|
932 | multi-telescope files which can be produced with the coming
|
---|
933 | camera version 0.7.
|
---|
934 |
|
---|
935 | - added classes to read and interprete central control report files
|
---|
936 | (Directory: mreport, Base-Class: MReport, Reader: MReportFileRead, ...)
|
---|
937 |
|
---|
938 | - enhanced merpp (the executable) to support .raw and .rep files.
|
---|
939 |
|
---|
940 | - added classes for light calibration (MCalibration* and
|
---|
941 | MHCalibration*) by Markus Gaug. Further work has to be and will
|
---|
942 | be done soon.
|
---|
943 |
|
---|
944 | - Added a preliminary 'synchronizer' (MReadReports) which will
|
---|
945 | replace MReadMarsFile as soon as it is finished.
|
---|
946 |
|
---|
947 | - Added a tutorial macro demonstrating how report files are merpped
|
---|
948 | and how they can be read from the root file in the correct order
|
---|
949 | of time (readrep.C)
|
---|
950 |
|
---|
951 | - Added a generalized histogram (similar to MH3) called MVsTime
|
---|
952 | which allows to plot variables (or rules - MDataChain - of
|
---|
953 | variables) vs time. For an example have a look at tempvstime.C.
|
---|
954 |
|
---|
955 | - Changed the name of the event trees:
|
---|
956 | + Events --> Events
|
---|
957 | + PedEvents --> Pedestals
|
---|
958 | + CalEvents --> Calibration
|
---|
959 |
|
---|
960 | - changed name of MTime in the event trees from MRawEvtTime to MTime
|
---|
961 |
|
---|
962 | - added displaying the sector indices to the mars event display
|
---|
963 |
|
---|
964 | - Magic Online Analysis (MOnA) implemented in a first version
|
---|
965 | (see mona.cc, MOnlineDump and MOnlineDisplay)
|
---|
966 |
|
---|
967 | - added classes to calculate event rate
|
---|
968 | (preliminary: MEventRateCalc, MEventRate)
|
---|
969 |
|
---|
970 | - added new executable 'readdaq' to read *.raw files from the DAQ directly
|
---|
971 |
|
---|
972 | - added classes dealing with the telescope pointing position (MPointing*)
|
---|
973 |
|
---|
974 | - implemented the 'final' Mars time stamp based on some experiences with
|
---|
975 | the new 'Synchonizer'
|
---|
976 |
|
---|
977 |
|
---|
978 |
|
---|
979 | *** Version 0.8.2 (2003/11/10)
|
---|
980 |
|
---|
981 | - accelerated standard analysis by a factor of 6-8 ...
|
---|
982 | + doing precalculations in MGeomCam for the pixel area ratio
|
---|
983 | + creating a look up table for the single pixels in MCerPhotEvt
|
---|
984 |
|
---|
985 | - added task to calculates weights in case you want to 'change'
|
---|
986 | the energy spectrum of a monte carlo file
|
---|
987 | (MMcWeightEnergySpecCalc - Great work from Marcos Lopez Moya)
|
---|
988 |
|
---|
989 | - added a new executable star which implements the
|
---|
990 | star.C macro as precompiled executable. Currently a flexible
|
---|
991 | setup is not possible, but a 'input card' setup will follow.
|
---|
992 |
|
---|
993 | - Starting to implement Multi-Telescope-Support based on the
|
---|
994 | upcomming camera version 0.7. The base for a general support
|
---|
995 | is implemented and the star-functionality is proven to work.
|
---|
996 |
|
---|
997 | - Replaced Event-Display in and Camera-Display in the Mars GUI
|
---|
998 | executable by a more convinient display base on MStatusDisplay.
|
---|
999 |
|
---|
1000 | - fixed the algorithm for the blind pixel treatment (MBlindPixelCalc)
|
---|
1001 |
|
---|
1002 |
|
---|
1003 |
|
---|
1004 | *** Version 0.8.1 (2003/10/20)
|
---|
1005 |
|
---|
1006 | - added signal subtraction for pure on data by means of fitting
|
---|
1007 | the background in the off region or by performing a combined
|
---|
1008 | signal/background fit. Provides necessary histograms for
|
---|
1009 | obtaining energy spectra and a light curve.
|
---|
1010 |
|
---|
1011 | - added classes to perform and study the selection of the
|
---|
1012 | 2nd Level Trigger on MC data (example in triglvl2.C macro)
|
---|
1013 |
|
---|
1014 | - added pedestal calculation
|
---|
1015 |
|
---|
1016 | - implemented "democratic cleaning" (tail cut value proportional
|
---|
1017 | to pixel area) according to Wolfgang's suggestion.
|
---|
1018 |
|
---|
1019 | - added Sigmabar treatment (calculation and basic histogramming)
|
---|
1020 |
|
---|
1021 | - added basic routines to apply padding
|
---|
1022 |
|
---|
1023 | - added first implementation of MARS-based source visibility plotter
|
---|
1024 | (needs to be linked against slalib, preliminary version)
|
---|
1025 |
|
---|
1026 | - enhanced functionality of data chains: random numbers, conversion
|
---|
1027 | functions and access to MHMatrix objects
|
---|
1028 |
|
---|
1029 | - fixed some bugs in the CT1 Preproc file reader, which gave wrong
|
---|
1030 | numbers under certain circumstances (runs with 0 events included)
|
---|
1031 |
|
---|
1032 | - fixed a bug in the general filter MF (didn't work on some systems
|
---|
1033 | at all)
|
---|
1034 |
|
---|
1035 | - fixed a bug in chaining files, which caused the analysis to crash or
|
---|
1036 | ignore files
|
---|
1037 |
|
---|
1038 | - implemented more geometry classes describing the parameters used
|
---|
1039 | to simulate the PMT camera
|
---|
1040 |
|
---|
1041 | - added new Monte Carlo classes containing the setup of the different
|
---|
1042 | programs in the MC chain.
|
---|
1043 |
|
---|
1044 | - added a (preliminary) general task to evaluate chi-square of a given
|
---|
1045 | parameter in an eventloop.
|
---|
1046 |
|
---|
1047 | - first implementation of a container describing the observatory
|
---|
1048 | location (Long, Lat, etc)
|
---|
1049 |
|
---|
1050 | - added Random Forest - method for g/h-separation
|
---|
1051 |
|
---|
1052 | - made compatible with the latest PRO version of root (3.04/02 and 3.05/07)
|
---|
1053 | (this means, that it is compiling, but not yet fully tested)
|
---|
1054 |
|
---|
1055 | - added a new status display which can show the present status
|
---|
1056 | of histograms while an eventloop is running (MStatusDisplay,
|
---|
1057 | an example can be found at status.C)
|
---|
1058 |
|
---|
1059 | - reorganized directories:
|
---|
1060 | classes describing the image --> mimage
|
---|
1061 | classes containing Monte Carlo Histograms --> mhistmc
|
---|
1062 | classes for Random Forest method --> mranforest
|
---|
1063 |
|
---|
1064 | - added (event-)weights to fill histograms
|
---|
1065 |
|
---|
1066 | - colors in logging output to screen
|
---|
1067 |
|
---|
1068 | - changes to the Image Parameter declaration:
|
---|
1069 | + moved fConc, fConc1 from MHillasSrc to MNewImagePar
|
---|
1070 | + moved fNumUsedPix, fNumCorePix from MHillas to MNewImagePar
|
---|
1071 | + MHillasExt now derives from MParContainer instead of MHillas
|
---|
1072 | --> Files written with the old definition are more or less unreadable
|
---|
1073 |
|
---|
1074 | - reading of reflector files
|
---|
1075 |
|
---|
1076 | - display data from reflector files in the camera
|
---|
1077 |
|
---|
1078 | - implemented currents (and display them in the camera)
|
---|
1079 |
|
---|
1080 | - logarithmic scale in camera
|
---|
1081 |
|
---|
1082 | - added class to iterate through directory contents (MDirIter)
|
---|
1083 |
|
---|
1084 |
|
---|
1085 |
|
---|
1086 | *** Version 0.8 (2002/11/18)
|
---|
1087 |
|
---|
1088 | - added all subdirectories as Include-Paths for ACLIC (s. rootlogon.C)
|
---|
1089 |
|
---|
1090 | - corrected 48(!) wrong entries in the Next Neighbor table of the
|
---|
1091 | Magic Camera (all in the inner part of the outer ring, mostly
|
---|
1092 | missing a single NN)
|
---|
1093 |
|
---|
1094 | - Fixed a bug in the table describing the Next Neighbours of the
|
---|
1095 | CT1 camera (a pixel 127 doesn't exist and the pixel 126 didn't
|
---|
1096 | have any neighbour)
|
---|
1097 |
|
---|
1098 | - changed trigrate.C: now it calculates the pure NSB triggers from
|
---|
1099 | a camera file (generated with no showers), so there is no need
|
---|
1100 | to introduce them by hand in the BgR array (for more details
|
---|
1101 | please ask Abelardo)
|
---|
1102 |
|
---|
1103 | - added MHHadronness (and MHadronness) as a general facility to evaluate
|
---|
1104 | the quality of a gamma-hadron seperation method
|
---|
1105 |
|
---|
1106 | - changed MWriteAsciiFile to accept rules (MDataChain)
|
---|
1107 |
|
---|
1108 | - Calls to MWriteAsciiFile::AddContainer and MWriteAsciiFile::AddRule
|
---|
1109 | must be replaced by calles to MWriteAsciiFile::AddColumn and
|
---|
1110 | MWriteAsciiFile::AddColumns. Be carefull, the arguments have slightly
|
---|
1111 | changed.
|
---|
1112 |
|
---|
1113 | - Implemented generalized event-matrices (one row per event)
|
---|
1114 | (MHMatrix)
|
---|
1115 |
|
---|
1116 | - implemented the one dimensional composite probabilities
|
---|
1117 | (MHCompProb, MCompProbCalc, comprob.C)
|
---|
1118 |
|
---|
1119 | - implemented the Multidimensional Distances (Next Neighbours, Kernel)
|
---|
1120 | (MMultiDimDistCalc, multidimdist.C, multidimdist2.C, MHMatrix)
|
---|
1121 |
|
---|
1122 | - Added a camera display displaying the pixel numbers to the
|
---|
1123 | event display gui.
|
---|
1124 |
|
---|
1125 | - Added Monte Carlo Informations to event display gui
|
---|
1126 |
|
---|
1127 | - Changed the camera display to display the pixel numbering
|
---|
1128 |
|
---|
1129 | - Added three buttons to the camera display to change the palette
|
---|
1130 |
|
---|
1131 | - Added the number of used and core pixels after image cleaning
|
---|
1132 | to MHillas
|
---|
1133 |
|
---|
1134 | - Changed the algorithm used in MHillas according to TDAS 02-03
|
---|
1135 |
|
---|
1136 | - Changed the Alpha range according to TDAS 02-03 to [-90°,90°]
|
---|
1137 |
|
---|
1138 | - Changed the algorithm used in MHillasSrc according to TDAS 02-03
|
---|
1139 |
|
---|
1140 | - Added fCosDeltaAlpha to MHillasSrc
|
---|
1141 |
|
---|
1142 | - The numbers of photons used to calculate fConc and fConc1 in
|
---|
1143 | MHillasExt are now scaled with the pixel size, so that one get
|
---|
1144 | a four times smaller value for the bigger pixels in the outer ring.
|
---|
1145 |
|
---|
1146 | - added new task to smooth the camera contents (MCameraSmooth)
|
---|
1147 |
|
---|
1148 | - added possibility to use interpolated pixel values for blind pixels
|
---|
1149 | instead of removing it completely from the analysis
|
---|
1150 |
|
---|
1151 | - Implemented the possibility to save the whole eventloop with
|
---|
1152 | its setup to a file. This information can be read and from
|
---|
1153 | it you can (re)create a Macro. See MEvtLoop::Read, MEvtLoop::Write
|
---|
1154 | and MEvtLoop::MakeMacro. If you find something not working, please
|
---|
1155 | report - this stuff is still in a beta phase.
|
---|
1156 |
|
---|
1157 | - MBlindPixelCalc set all Ceta-Tauri pixels to unused not only for the
|
---|
1158 | file having crab starfield, but also for all following files - fixed
|
---|
1159 |
|
---|
1160 | - MTaskList::PrintStatistics can now be instructud to print also the
|
---|
1161 | title, too: use PrintStatistics(0, kTRUE)
|
---|
1162 |
|
---|
1163 | - Changed the image cleaning so that pixels with to many 'used'
|
---|
1164 | neighbors are left used (to get rid of 'holes' in events)
|
---|
1165 |
|
---|
1166 | - Introduced more output to the camera displays
|
---|
1167 |
|
---|
1168 | - Added an array of histograms (eg one hist per run), MHArray
|
---|
1169 |
|
---|
1170 | - Added a _preliminary_ version of the reader for CT1 PreProc files
|
---|
1171 | (MCT1ReadPreProc)
|
---|
1172 |
|
---|
1173 | - Fixed the error calculation of MHMCollectionArea and MHMcIntRate
|
---|
1174 | (thanks to Raquel)
|
---|
1175 |
|
---|
1176 | - added the first energy estimator (MEnergyEstParam, estimate.C,
|
---|
1177 | estfit.C) using a parametrization
|
---|
1178 |
|
---|
1179 | - Added some new Monte Carlo paremeter containers used to store
|
---|
1180 | setup information from the MC chain (MMcConfigRunHeader,
|
---|
1181 | MMcCorsikaRunHeader, MGeomPMT, MGeomMirror)
|
---|
1182 |
|
---|
1183 |
|
---|
1184 |
|
---|
1185 | *** Version 0.7 (2002/04/30)
|
---|
1186 |
|
---|
1187 | - added a bugfix to MCerPhotCalc. In older camera versions (<=40)
|
---|
1188 | the pedestal mean value was saved incorrectly. For files from
|
---|
1189 | this versions we substract 0.5 from the pedestal mean.
|
---|
1190 | WARNING: This may effect your results, so don't wonder...
|
---|
1191 |
|
---|
1192 | - First implementation of an algorithm using only triggered events
|
---|
1193 | for the collection area calculation
|
---|
1194 |
|
---|
1195 | - Ascii Output can now also be used for parameter containers which
|
---|
1196 | doesn't overload MParCointainer::AsciiWrite
|
---|
1197 |
|
---|
1198 | - The Ascii Output is now also capable of writing single data members
|
---|
1199 | of one container
|
---|
1200 |
|
---|
1201 | - You are now able to change the order of the values written to the
|
---|
1202 | ascii file
|
---|
1203 |
|
---|
1204 | - You can now specify a conversion factor for each data member written
|
---|
1205 | to an ascii file. This may be usefull to change the units of the
|
---|
1206 | data member (eg. degrees instead of millimeters in case of the
|
---|
1207 | hillas parameters)
|
---|
1208 |
|
---|
1209 | - Replaced old MHillas by a new structure which allows you to extend
|
---|
1210 | the parameters stored in MHillas very easily:
|
---|
1211 | see MHillas and MHillasExt
|
---|
1212 |
|
---|
1213 | - Added classes to handle source dependancy of image parameters:
|
---|
1214 | see MHillasSrc
|
---|
1215 |
|
---|
1216 | - Added container (MBinning) to have a standard input for the binning
|
---|
1217 | in different histograms (eg. the Energy bins should be the same in
|
---|
1218 | all histograms)
|
---|
1219 |
|
---|
1220 | - Changed Hillas histograms from mm to deg
|
---|
1221 |
|
---|
1222 | - Added the flexible binning to the hillas histograms
|
---|
1223 |
|
---|
1224 | - Added a filter for the alpha parameter (MFAlpha)
|
---|
1225 |
|
---|
1226 | - It is now possible to write single data members of a class object to
|
---|
1227 | an output stream instead of the whole container only
|
---|
1228 |
|
---|
1229 | - Added a generalized filter for a data member:
|
---|
1230 | MFDataMember filter("MHillas.fWidth", '<', 0.5);
|
---|
1231 |
|
---|
1232 | - Added a generalized Filter parser for more difficult filter rules
|
---|
1233 | MF filter("MHillas.fWidth<0.5 && MHillas.fLength>0.5");
|
---|
1234 |
|
---|
1235 | - Added new Monte Carlo histograms:
|
---|
1236 | MHMcEnergyImpact and MHMcEfficiency
|
---|
1237 |
|
---|
1238 | - Added many new histograms needed for the flux calculation.
|
---|
1239 |
|
---|
1240 | - Added a generalized histograms which can fill and show up to three
|
---|
1241 | data members in either a one-, two- or three-dimensional histogram, eg:
|
---|
1242 | MH3 mh3("MHillas.fWidth", "MHillas.fLength");
|
---|
1243 |
|
---|
1244 | - Added:
|
---|
1245 | * calculation of <Theta> as a function of Theta (MHThetabarTheta)
|
---|
1246 | * calculation of <Theta> as a function of time (MHThetabarTime)
|
---|
1247 | they are needed in the flux calculation in
|
---|
1248 | order to select for a given bin in Theta (or time) the appropriate
|
---|
1249 | effective collection area, which is assumed to be given as a function
|
---|
1250 | of Theta and the true energy
|
---|
1251 |
|
---|
1252 | - Added calculation of the migration matrix in the energy
|
---|
1253 | (MHMcEnergyMigration):
|
---|
1254 | the migration matrix describes the migration from the true (E_true)
|
---|
1255 | to the estimated energy (E_est); it is needed to determine the
|
---|
1256 | distribution of E_true from the measured distribution of E_est
|
---|
1257 | by unfolding
|
---|
1258 |
|
---|
1259 | - changed the color palette in the camera display to DeapSea.
|
---|
1260 |
|
---|
1261 |
|
---|
1262 |
|
---|
1263 | *** Version 0.6 (2002/01/15)
|
---|
1264 |
|
---|
1265 | - Introduce the option of disable pixels (MBlindPixels and
|
---|
1266 | MBlindPixelCalc) for the analysis (eg MHillasCalc) to be
|
---|
1267 | able to deal with Star Field NSB.
|
---|
1268 |
|
---|
1269 | - Fixed a bug in the pedestals substraction
|
---|
1270 |
|
---|
1271 | - Introduced verbosity levels
|
---|
1272 |
|
---|
1273 | - Introduced a task (MReadMarsFile) which reads the RunHeader tree, too.
|
---|
1274 |
|
---|
1275 | - Fixed several bugs in MFTriggerLvl1 which caused to filter not to
|
---|
1276 | work correctly (thanks to Abelardo)
|
---|
1277 |
|
---|
1278 | - Introduced correct treatment of the diffuse Night Sky Background
|
---|
1279 | and NSB (MMcPedestalNSB)
|
---|
1280 |
|
---|
1281 | - Corrected treatment of the electronic noise (MMcPedestalCopy)
|
---|
1282 |
|
---|
1283 | - Introduced MMcRunHeaders which contains monte carlo run informations
|
---|
1284 |
|
---|
1285 | - Added a 'Print'-Task (MPrint) which calls the Print function
|
---|
1286 | of a parameter container for each event
|
---|
1287 |
|
---|
1288 | - Removed MHtml (was replaced by THtml of root 3.02) in dohtml.C
|
---|
1289 |
|
---|
1290 | - changes to be more efficient with root 3.02/06
|
---|
1291 |
|
---|
1292 | - root 3.02/06 fixes:
|
---|
1293 | + the memory leak when reading MRawEvtData
|
---|
1294 | + loosing more time than necessary to update the progress bar
|
---|
1295 |
|
---|
1296 | - MWriteAsciiFile is now capable of writing more than one container
|
---|
1297 | in a line. For example: To be able to write Monte Carlo and
|
---|
1298 | Hillas values (energy and alpha) in one line.
|
---|
1299 |
|
---|
1300 |
|
---|
1301 |
|
---|
1302 | *** Version 0.5 (2001/11/06)
|
---|
1303 |
|
---|
1304 | - Added new GUI functionality (Analysis)
|
---|
1305 |
|
---|
1306 | - Added a camera display to be able to display events in the camera
|
---|
1307 | together with the calculated hillas ellipse
|
---|
1308 |
|
---|
1309 | - Added a 'Clone'-Task (MClone) which can clone a parameter container
|
---|
1310 | object at any state of the analysis, so that the output are several
|
---|
1311 | states
|
---|
1312 |
|
---|
1313 | - Fixed a bug in the collection area error calculation
|
---|
1314 | (Thanks to Ciro and Abelardo)
|
---|
1315 |
|
---|
1316 | - Fixed a bug which causes merpp to crash in some environments
|
---|
1317 |
|
---|
1318 | - Implemented auto enabling scheme for Branches to speed up reading
|
---|
1319 | a lot (see MReadTree and MTask)
|
---|
1320 |
|
---|
1321 | - Fixed a bug in the Histogram classes which caused histograms to
|
---|
1322 | be written to a file by MWriteRootFile without request
|
---|
1323 |
|
---|
1324 | - changed the object I/O from the old stylish root I/O to the new
|
---|
1325 | 'auto evolution scheme' This was done only for classes which are not
|
---|
1326 | yet used in Monte Carlo files, so that these files are still readable.
|
---|
1327 |
|
---|
1328 | - Added support for a progress bar in MEvtLoop and MReadTree
|
---|
1329 | (see the Analysis Window in Mars for an example)
|
---|
1330 |
|
---|
1331 | - Fixed a bug in the package creation which disturbed the conversion
|
---|
1332 | between a mars version unpacked from a tar file and the repository.
|
---|
1333 |
|
---|
1334 | - Changed the code to writer merpped (converted into root format)
|
---|
1335 | raw files, to get faster (around 10%)
|
---|
1336 |
|
---|
1337 |
|
---|
1338 |
|
---|
1339 | *** Version 0.4 (2001/09/20)
|
---|
1340 |
|
---|
1341 | - This release is made to compile on a root version >= 3.00
|
---|
1342 |
|
---|
1343 | - Fixed a bug which causes MReadTree to read the first file only
|
---|
1344 |
|
---|
1345 | - Added a task to compute the trigger rate (MMcTriggerRateCalc)
|
---|
1346 |
|
---|
1347 | - Added a task to write a container to an Ascii file (MWriteAsciiFile)
|
---|
1348 |
|
---|
1349 | - Added a task to write several container to a root file (MWriteRootFile)
|
---|
1350 |
|
---|
1351 | - Added calculation of the Enegry Threshold (MMcThresholdCalc)
|
---|
1352 |
|
---|
1353 | - Added calculation of the collection area (MMcCollectionAreaCalc)
|
---|
1354 |
|
---|
1355 | - fixed some bugs in the Hillas calculation
|
---|
1356 |
|
---|
1357 | - added filters to be able to control the task execution dependent on
|
---|
1358 | a parameter (for example: the number of level 1 triggers in a MC-file)
|
---|
1359 |
|
---|
1360 |
|
---|
1361 |
|
---|
1362 | *** Version 0.3 (2001/04/23)
|
---|
1363 |
|
---|
1364 | - Many demo macros added
|
---|
1365 |
|
---|
1366 | - MCT1ReadAscii is now able to handle more than one file (s. ::AddFile)
|
---|
1367 |
|
---|
1368 | - Hillas Calculation added
|
---|
1369 |
|
---|
1370 | - Standard image cleaning available
|
---|
1371 |
|
---|
1372 | - MReadTree is now able to handle more than one file
|
---|
1373 | (Remark: of the same structure)
|
---|
1374 |
|
---|
1375 | - Now we are able to display events in a first version of the
|
---|
1376 | Camera event display. To do this we must run the macro
|
---|
1377 | "macros/readCT1.C" to read data from CT1.
|
---|
1378 |
|
---|
1379 |
|
---|
1380 |
|
---|
1381 | *** Version 0.2 (2001/01/24)
|
---|
1382 |
|
---|
1383 | - First Implementation of a Gui to read the raw data. Start the
|
---|
1384 | gui with the command mars.
|
---|
1385 |
|
---|
1386 |
|
---|
1387 |
|
---|
1388 | *** Version 0.1 (2000/12/20)
|
---|
1389 |
|
---|
1390 | - First official release 0.1
|
---|
1391 |
|
---|
1392 | - Changes:
|
---|
1393 |
|
---|
1394 | + changed calling style of MRawPixelIterator from do...while to
|
---|
1395 | while-loop
|
---|
1396 |
|
---|