Changeset 10570

Timestamp:

05/04/11 15:17:47 (14 years ago)

Author:

tbretz

Message:

Improved/fixed the retrieval of times from Dim once again.

Location:

trunk/FACT++/src

Files:

• DimDescriptionService.h (modified) (1 diff)
• DimNetwork.cc (modified) (2 diffs)
• DimServerList.cc (modified) (1 diff)
• DimServiceInfoList.cc (modified) (2 diffs)
• EventDim.h (modified) (1 diff)
• MessageDim.cc (modified) (2 diffs)
• dataLogger.cc (modified) (2 diffs)

trunk/FACT++/src/DimDescriptionService.h

@@ -42 +42 @@
 };
 
-
 #endif

trunk/FACT++/src/DimNetwork.cc

@@ -14 +14 @@
 void StateClient::infoHandler()
 {
-    // Make sure getTimestamp is called _before_ getTimestampMillisecs
-    getInfo()->getTimestamp();
-
     DimInfo *curr = getInfo(); // get current DimInfo address
     if (!curr)
@@ -25 +22 @@
         const bool disconnected = fInfoState.getSize()==0;
 
+        // Make sure getTimestamp is called _before_ getTimestampMillisecs
+        const int tsec = fInfoState.getTimestamp();
+        const int tms  = fInfoState.getTimestampMillisecs();
+
         fState     = disconnected ? -2 : fInfoState.getQuality();
-        fStateTime = Time(fInfoState.getTimestamp(),
-                          fInfoState.getTimestampMillisecs()*1000);
+        fStateTime = Time(tsec, tms*1000);
 
         const string name = fInfoState.getName();

trunk/FACT++/src/DimServerList.cc

@@ -47 +47 @@
 void DimServerList::infoHandler()
 {
-    // Make sure getTimestamp is called _before_ getTimestampMillisecs
-    getInfo()->getTimestamp();
-
     if (getInfo()!=&fDimServers)
         return;

trunk/FACT++/src/DimServiceInfoList.cc

@@ -120 +120 @@
 void DimServiceInfoList::RemoveServer(const string &s)
 {
+    cout << "Check for: " << s << endl;
+
     const ServiceInfoList::iterator v = fServiceInfoList.find(s);
     if (v==fServiceInfoList.end())
@@ -173 +175 @@
 void DimServiceInfoList::infoHandler()
 {
-    // Make sure getTimestamp is called _before_ getTimestampMillisecs
-    getInfo()->getTimestamp();
-
     // Get the name of the service
     const string svc = getInfo()->getName();

trunk/FACT++/src/EventDim.h

@@ -58 +58 @@
     Time GetTime() const
     {
-        return Time(const_cast<EventDim*>(this)->getTimestamp(),
-                    const_cast<EventDim*>(this)->getTimestampMillisecs());
+        // Must be in exactly this order!
+        const int tsec = const_cast<EventDim*>(this)->getTimestamp();
+        const int tms  = const_cast<EventDim*>(this)->getTimestampMillisecs();
+
+        return Time(tsec, tms*1000);
     }
 };

trunk/FACT++/src/MessageDim.cc

@@ -126 +126 @@
 void MessageDimRX::infoHandler()
 {
-    // Make sure getTimestamp is called _before_ getTimestampMillisecs
-    getInfo()->getTimestamp();
-
     if (getInfo()!=&fDimMessage)
         return;
 
-    const string name   = getInfo()->getName();
+    const string name   = fDimMessage.getName();
     const string server = name.substr(0, name.find_first_of('/'));
 
-    fConnected = getInfo()->getSize()!=0;
+    fConnected = fDimMessage.getSize()!=0;
 
     // The server is diconnected. Do nothing
@@ -147 +144 @@
 
     // skip all messages with a severity smaller than the minimum log level
-    if (getInfo()->getQuality()<fMinLogLevel)
+    if (fDimMessage.getQuality()<fMinLogLevel)
         return;
 
     stringstream msg;
-    msg << server << ": " << getInfo()->getString();
+    msg << server << ": " << fDimMessage.getString();
+
+    // Make sure getTimestamp is called _before_ getTimestampMillisecs
+    // Must be in exactly this order!
+    const int tsec = fDimMessage.getTimestamp();
+    const int tms  = fDimMessage.getTimestampMillisecs();
 
     // Write the received message to the output
-    fMsg.Write(Time(getInfo()->getTimestamp(), getInfo()->getTimestampMillisecs()*1000),
-               msg.str().c_str(), getInfo()->getQuality());
+    fMsg.Write(Time(tsec, tms*1000), msg.str().c_str(), fDimMessage.getQuality());
 }

trunk/FACT++/src/dataLogger.cc

@@ -755 +755 @@
                 return;
 
-        getInfo()->getTimestamp();
-
         DimInfo* I = getInfo();
         SubscriptionsListType::iterator x;
@@ -799 +797 @@
         if (I->getSize() <= 0)
                 return;
-        //check that the message has been updated by something, i.e. must be different from its initial value
+
+        // Make sure that getTimestampMillisecs is NEVER called before
+        // getTimestamp is properly called
+        // check that the message has been updated by something, i.e. must be different from its initial value
         if (I->getTimestamp() == 0)
                 return;