Changeset 10873 for trunk/FACT++/src

Timestamp:

05/27/11 16:30:07 (13 years ago)

Author:

tbretz

Message:

Replaced a self-done loop by std::find; changed some comments.

Location:

trunk/FACT++/src

Files:

• StateMachineDim.cc (modified) (1 diff)
• StateMachineImp.cc (modified) (2 diffs)

trunk/FACT++/src/StateMachineDim.cc

@@ -167 +167 @@
     const EventImp *evt = dynamic_cast<EventImp*>(cmd);
 
-    // FIXME: In the case of HandleEvent there is no need to copy the data
-    // FIMXE: Currentyl the time is not copied
-    // FIXME: Handle Event is not thread safe (Dim + Console)
     if (HasEvent(evt))
         PostEvent(*evt);

trunk/FACT++/src/StateMachineImp.cc

@@ -316 +316 @@
         // FIXME: Is this thread safe? (Yes, because the data is copied)
         // But two handlers could be called at the same time. Do we
-        // need to lock the handlers?
+        // need to lock the handlers? (Dim + console)
+        // FIXME: Is copying of the data necessary?
         const Event event(evt, ptr, siz);
         HandleEvent(event);
@@ -456 +457 @@
 {
     // Find the event from the list of commands and queue it
-    for (vector<EventImp*>::const_iterator c=fListOfEvents.begin(); c!=fListOfEvents.end(); c++)
-        if (*c == cmd)
-            return true;
-
-    return false;
+    return find(fListOfEvents.begin(), fListOfEvents.end(), cmd)!=fListOfEvents.end();
 }