Changeset 11713

Timestamp:

07/30/11 16:04:48 (13 years ago)

Author:

tbretz

Message:

Fixed a problem in RemoveAllServers - it must be made sure that the reference given to RemoveServer is not deleted during usage.

File:

• trunk/FACT++/src/DimServiceInfoList.cc (modified) (2 diffs)

trunk/FACT++/src/DimServiceInfoList.cc

@@ -148 +148 @@
 void DimServiceInfoList::RemoveAllServers()
 {
-    for (ServiceInfoList::iterator i=fServiceInfoList.begin();
-         i!=fServiceInfoList.end(); i++)
-        RemoveServer(i->first);
+    while (fServiceInfoList.size()>0)
+    {
+        // We need to make a copy, otherwise RemoveServer will
+        // destroy the staring the reference is pointing to
+        const string name = fServiceInfoList.begin()->first;
+        RemoveServer(name);
+    }
 }
 
@@ -231 +235 @@
                     stringstream err;
                     err << "Service '" << server << "/" << name << "' not in list as it ought to be.";
+                    // Seems to happen why more than one client is subscribed
+                    // and e.g. the datalogger is immediately quit
                     throw runtime_error(err.str());
                 }