Changeset 12907 for trunk

Timestamp:

02/19/12 10:21:43 (13 years ago)

Author:

tbretz

Message:

Do not throw an exception if a server which is requested to be removed is not in the list; datalogger should now accept this condition, too.

Location:

trunk/FACT++/src

Files:

• DimServiceInfoList.cc (modified) (1 diff)
• datalogger.cc (modified) (3 diffs)

trunk/FACT++/src/DimServiceInfoList.cc

@@ -121 +121 @@
 void DimServiceInfoList::RemoveServer(const string s)
 {
+    RemoveAllServices(s);
+
     const ServiceInfoList::iterator v = fServiceInfoList.find(s);
     if (v==fServiceInfoList.end())
+        return;
+    /*
     {
         stringstream err;
         err << "DimServiceInfoList: Server '" << s << "' not in list as it ought to be.";
         throw runtime_error(err.str());
-    }
-
-    RemoveAllServices(s);
+    }*/
 
     // Remove the server from the server list

trunk/FACT++/src/datalogger.cc

@@ -471 +471 @@
     if (list.find(service) != list.end())
     {
-        Error("Service " + server + "/" + service + " is already in the dataLogger's list. ignoring its update.");
+        Error("Service " + server + "/" + service + " is already in the dataLogger's list... ignoring update.");
         return;
     }
@@ -502 +502 @@
     if (fServiceSubscriptions.find(server) == fServiceSubscriptions.end())
     {
-      Error("Server " + server + " not found while removing service " + service);
-      return;
+        Error("Request to remove service "+service+" from server "+server+", but service not found.");
+        return;
     }
 
@@ -532 +532 @@
 void DataLogger::RemoveAllServices(const string& server)
 {
+    if (fServiceSubscriptions.find(server)==fServiceSubscriptions.end())
+    {
+        Warn("Request to remove all services, but corresponding server " + server + " not found.");
+        return;
+    }
+
     fNumSubAndFitsData.numSubscriptions -= fServiceSubscriptions[server].size();
+
     fServiceSubscriptions[server].clear();
     fServiceSubscriptions.erase(server);
+
     if (server == "FAD_CONTROL")
         fRunNumberService = NULL;
+
     if (fDebugIsOn)
-    {
         Debug("Removed all subscriptions to " + server + "/");
-    }
 }