Changeset 14637

Timestamp:

11/17/12 14:36:27 (12 years ago)

Author:

tbretz

Message:

Re-did (once more) the exception handling and script termination to allow to cancel a timeout thread properly. Added dim.kill to do that.

Location:

trunk/FACT++/src

Files:

• InterpreterV8.cc (modified) (19 diffs)
• InterpreterV8.h (modified) (4 diffs)

trunk/FACT++/src/InterpreterV8.cc

@@ -84 +84 @@
 // ==========================================================================
 
-void InterpreterV8::Terminate()
-{
-    if (!Locker::IsLocked())
-        JsException("***** InterprterV8::Terminate call not locked *****");
-
-    for (auto it=fThreadIds.begin(); it!=fThreadIds.end(); it++)
-        V8::TerminateExecution(*it);
-    fThreadIds.clear();
-
-    if (fThreadId>=0)
-    {
-        V8::TerminateExecution(fThreadId);
-        fThreadId = -1;
-    }
-}
-
 Handle<Value> InterpreterV8::FuncExit(const Arguments &)
 {
-    Terminate();
-    return ThrowException(String::New("exit"));
+    V8::TerminateExecution(fThreadId);
+    return Undefined();
 }
 
@@ -135 +119 @@
 }
 
-void InterpreterV8::ThreadTimeout(Persistent<Function> func, uint32_t ms)
+void InterpreterV8::ThreadTimeout(int &id, Persistent<Function> func, uint32_t ms)
 {
     const Locker lock;
 
     if (fThreadId<0)
+    {
+        id = -1;
         return;
-
-    const int id = V8::GetCurrentThreadId();
+    }
+
+    id = V8::GetCurrentThreadId();
     fThreadIds.insert(id);
 
@@ -161 +148 @@
     fThreadIds.erase(id);
 
-    if (!exception.HasCaught())
-        return;
-
-    ReportException(&exception);
-    Terminate();
+    if (!HandleException(exception, "dim.timeout"))
+        V8::TerminateExecution(fThreadId);
 }
 
@@ -190 +174 @@
     const uint32_t ms = args[0]->Uint32Value();
 
-    fTimeout.push_back(thread(bind(&InterpreterV8::ThreadTimeout, this, func, ms)));
-    return Undefined();
+    int id=-2;
+    fTimeout.push_back(thread(bind(&InterpreterV8::ThreadTimeout, this, ref(id), func, ms)));
+    {
+        const Unlocker unlock;
+        while (id==-2)
+            usleep(1);
+    }
+
+    return Integer::New(id);
+}
+
+Handle<Value> InterpreterV8::FuncKill(const Arguments& args)
+{
+    for (int i=0; i<args.Length(); i++)
+        if (!args[i]->IsInt32())
+            return ThrowException(String::New("All arguments must be int32."));
+
+    uint32_t cnt = 0;
+
+    for (int i=0; i<args.Length(); i++)
+    {
+        V8::TerminateExecution(args[i]->Int32Value());
+        cnt += fThreadIds.erase(args[i]->Int32Value());
+    }
+
+    return Integer::New(cnt);
 }
 
@@ -995 +1003 @@
     const HandleScope handle_scope;
 
-    Persistent<Object> obj = it->second;
+    Handle<Object> obj = it->second;
 
     obj->CreationContext()->Enter();
@@ -1024 +1032 @@
     fThreadIds.erase(id);
 
-    if (exception.HasCaught())
-        ReportException(&exception);
+    if (!HandleException(exception, "Service.onchange"))
+        V8::TerminateExecution(fThreadId);
+    //Terminate();
 
     if (ret->IsNativeError())
+    {
         JsException(service+".onchange callback - "+*String::Utf8Value(ret));
-
-    if (ret->IsUndefined() || ret->IsNativeError() || exception.HasCaught())
-        Terminate();
+        V8::TerminateExecution(fThreadId);
+//Terminate();
+    }
+
+    //if (ret->IsUndefined() || ret->IsNativeError()/* || exception.HasCaught()*/)
 }
 
@@ -1097 +1109 @@
     fThreadIds.erase(id);
 
-    if (!exception.HasCaught())
-        return;
-
-    ReportException(&exception);
-    Terminate();
+    if (!HandleException(exception, "dim.onchange"))
+        V8::TerminateExecution(fThreadId);
+    //Terminate();
 }
 
@@ -1440 +1450 @@
 // ==========================================================================
 
-bool InterpreterV8::ReportException(TryCatch* try_catch)
-{
-    if (!try_catch->CanContinue())
-        return false;
+bool InterpreterV8::HandleException(TryCatch& try_catch, const char *where)
+{
+    if (!try_catch.HasCaught() || !try_catch.CanContinue())
+        return true;
 
     const HandleScope handle_scope;
 
-    const String::Utf8Value exception(try_catch->Exception());
-
-    if (*exception && string(*exception)=="exit")
+    Handle<Value> except = try_catch.Exception();
+    if (except.IsEmpty() || except->IsNull())
         return true;
-    if (*exception && string(*exception)=="null")
-        return false;
-
-    const Handle<Message> message = try_catch->Message();
+
+    const String::Utf8Value exception(except);
+
+    const Handle<Message> message = try_catch.Message();
     if (message.IsEmpty())
         return false;
@@ -1465 +1474 @@
         const String::Utf8Value filename(message->GetScriptResourceName());
 
-        if (*filename)
-            out << *filename << ": ";
-        out << "l." << message->GetLineNumber();
+        out << *filename;
+        if (message->GetLineNumber()>0)
+            out << ": l." << message->GetLineNumber();
         if (*exception)
             out << ": ";
     }
 
-    // -------------- SKIP if 'internal' and 'Error' ---------------
     if (*exception)
         out << *exception;
+
+    out << " [" << where << "]";
 
     JsException(out.str());
@@ -1482 +1492 @@
     if (*sourceline)
         JsException(*sourceline);
-    // -------------- SKIP if 'internal' and 'Error: ' ---------------
 
     // Print wavy underline (GetUnderline is deprecated).
@@ -1495 +1504 @@
     JsException(out.str());
 
-    const String::Utf8Value stack_trace(try_catch->StackTrace());
+    const String::Utf8Value stack_trace(try_catch.StackTrace());
     if (stack_trace.length()<=0)
         return false;
@@ -1547 +1556 @@
         JsSetState(3);
 
+    TryCatch exception;
+
     const Handle<Value> result = script->Run();
-    if (result.IsEmpty())
-        return Handle<Value>();
+
+    if (exception.HasCaught())
+    {
+        if (file=="internal")
+            return exception.ReThrow();
+
+        HandleException(exception, "code");
+        return Undefined();
+    }
 
     // If all went well and the result wasn't undefined then print
     // the returned value.
-    if (!result->IsUndefined())
+    if (!result.IsEmpty() && result->IsUndefined())
         JsResult(*String::Utf8Value(result));
 
@@ -1596 +1614 @@
 
 
-void InterpreterV8::AddFormatToGlobal() const
+void InterpreterV8::AddFormatToGlobal()// const
 {
     const string code =
@@ -1651 +1669 @@
         "}"*/;
 
+    // ExcuteInternal does not work properly here...
+    // If suring compilation an exception is thrown, it will not work
     Handle<Script> script = Script::New(String::New(code.c_str()), String::New("internal"));
     if (!script.IsEmpty())
@@ -1683 +1703 @@
     dim->Set(String::New("sleep"),     FunctionTemplate::New(WrapSleep),     ReadOnly);
     dim->Set(String::New("timeout"),   FunctionTemplate::New(WrapTimeout),   ReadOnly);
+    dim->Set(String::New("kill"),      FunctionTemplate::New(WrapKill),      ReadOnly);
     dim->Set(String::New("subscribe"), FunctionTemplate::New(WrapSubscribe), ReadOnly);
     dim->Set(String::New("file"),      FunctionTemplate::New(WrapFile),      ReadOnly);
+
+    // timeout   -> Thread  - class?
+    // subscribe -> Service - class?
+    // file      -> File    - class?
+    // new class State ?
+    // newState -> return State?
+    // setState -> return State?
+    // getState -> return State?
 
     Handle<ObjectTemplate> onchange = ObjectTemplate::New();
@@ -1728 +1757 @@
     }
 
+    // Switch off eval(). It is not possible to track it's exceptions.
+    context->AllowCodeGenerationFromStrings(false);
+
     Context::Scope scope(context);
 
@@ -1738 +1770 @@
     //V8::ResumeProfiler();
 
+    bool rc;
+
+    TryCatch exception;
+
     AddFormatToGlobal();
 
-    JsStart(filename);
-
-    //context->Enter();
-
-    TryCatch exception;
-
-    Locker::StartPreemption(10);
-    bool rc = ExecuteFile(filename, true);
-
-    Locker::StopPreemption();
-
-    Terminate();
-
-    if (exception.HasCaught())
-        rc = ReportException(&exception);
+    if (!exception.HasCaught())
+    {
+        JsStart(filename);
+
+        Locker::StartPreemption(10);
+
+        rc = ExecuteFile(filename, true);
+
+        Locker::StopPreemption();
+
+        // Stop all other threads
+        for (auto it=fThreadIds.begin(); it!=fThreadIds.end(); it++)
+            V8::TerminateExecution(*it);
+        fThreadIds.clear();
+    }
+
+    // Handle an exception
+    rc = HandleException(exception, "main");
 
     // IsProfilerPaused()
@@ -1773 +1812 @@
     //context->Exit();
 
-    // Thre threads are started already and wait to get the lock
-    // So we have to unlock (manual preemtion) so they they get
-    // the signal to terminate. After they are all successfully
-    // terminated, just to be sure... we lock again
+    // The threads are started already and wait to get the lock
+    // So we have to unlock (manual preemtion) so that they get
+    // the signal to terminate.
     {
         const Unlocker unlock;
@@ -1814 +1852 @@
 {
     Locker locker;
-    This->Terminate();
+    V8::TerminateExecution(This->fThreadId);
+    //This->Terminate();
 }
 

trunk/FACT++/src/InterpreterV8.h

@@ -50 +50 @@
 
 #ifdef HAVE_V8
-    void Terminate();
-
-    bool ReportException(v8::TryCatch* try_catch);
+    bool HandleException(v8::TryCatch &try_catch, const char *where);
     bool ExecuteFile(const std::string &name, bool main=false);
     v8::Handle<v8::Value> ExecuteCode(const std::string &code, const std::string &file="internal", bool main=false);
     v8::Handle<v8::Value> ExecuteInternal(const std::string &code);
 
-    void ThreadTimeout(v8::Persistent<v8::Function> func, uint32_t ms);
+    void ThreadTimeout(int &id, v8::Persistent<v8::Function> func, uint32_t ms);
 
     v8::Handle<v8::Value> FuncWait(const v8::Arguments& args);
@@ -63 +61 @@
     v8::Handle<v8::Value> FuncSleep(const v8::Arguments& args);
     v8::Handle<v8::Value> FuncTimeout(const v8::Arguments& args);
+    v8::Handle<v8::Value> FuncKill(const v8::Arguments& args);
     v8::Handle<v8::Value> FuncPrint(const v8::Arguments& args);
     v8::Handle<v8::Value> FuncAlarm(const v8::Arguments& args);
@@ -108 +107 @@
     static v8::Handle<v8::Value> WrapSleep(const v8::Arguments &args)    { if (This) return This->FuncSleep(args);    else return v8::Undefined(); }
     static v8::Handle<v8::Value> WrapTimeout(const v8::Arguments &args)  { if (This) return This->FuncTimeout(args);  else return v8::Undefined(); }
+    static v8::Handle<v8::Value> WrapKill(const v8::Arguments &args)     { if (This) return This->FuncKill(args);     else return v8::Undefined(); }
     static v8::Handle<v8::Value> WrapExit(const v8::Arguments &args)     { if (This) return This->FuncExit(args);     else return v8::Undefined(); }
     static v8::Handle<v8::Value> WrapState(const v8::Arguments &args)    { if (This) return This->FuncState(args);    else return v8::Undefined(); }
@@ -178 +178 @@
     void JsHandleState(const std::string &, const State &);
 
-    void AddFormatToGlobal() const;
+    void AddFormatToGlobal();
 
     bool JsRun(const std::string &, const std::map<std::string,std::string> & = std::map<std::string,std::string>());