Changeset 15125

Timestamp:

03/19/13 18:23:36 (12 years ago)

Author:

tbretz

Message:

Reorganized some code around the triming of comments to get more reasonable output.

File:

• trunk/Mars/mcore/ofits.h (modified) (5 diffs)

trunk/Mars/mcore/ofits.h

@@ -121 +121 @@
         }
 
-        bool check()
+        bool check(bool trim=false)
         {
             if (!FormatKey())
@@ -129 +129 @@
                 return false;
 
-            const size_t sz = CalcSize();
-            if (sz>80)
+            size_t sz = CalcSize();
+            if (sz<=80)
+                return true;
+
+            if (!trim)
             {
                 ostringstream sout;
@@ -138 +141 @@
 #else
                 gLog << ___err___ << "ERROR - " << sout.str() << endl;
+#endif
                 return false;
-#endif
             }
 
-            return true;
+            //looks like something went wrong. Maybe entry is too long ?
+            //try to remove the comment
+            comment = "";
+
+            sz = CalcSize();
+            if (sz<=80)
+            {
+#ifndef __EXCEPTIONS
+                ostringstream sout;
+                sout << "Size " << sz << " of entry for key '" << key << "' exceeds 80 characters... removed comment.";
+                gLog << ___warn___ << "WARNING - " << sout.str() << endl;
+#endif
+                return true;
+            }
+
+            ostringstream sout;
+            sout << "Size " << sz << " of entry for key '" << key << "' exceeds 80 characters even without comment.";
+#ifdef __EXCEPTIONS
+            throw runtime_error(sout.str());
+#else
+            gLog << ___err___ << "ERROR - " << sout.str() << endl;
+            return false;
+#endif
         }
 
@@ -257 +282 @@
         entry.changed = true;
 
-        if (!entry.check())
-        {
-            if (!fCommentTrimming)
-                return false;
-
-            //looks like something went wrong. Maybe entry is too long ?
-            //try to remove the comment
-            entry.comment = "";
-            if (!entry.check())
-                return false;
-
-#ifdef __MARS__
-            gLog << ___warn___ << "WARNING - Removed comment from over-sized entry " << key << endl;
-#endif
-        }
+        if (!entry.check(fCommentTrimming))
+            return false;
 
         fKeys.push_back(entry);
@@ -460 +472 @@
         {
             ostringstream sout;
-            sout << "Header already writtenm, no new column can be defined... ignoring column '" << name << "'";
+            sout << "Header already written, no new column can be defined... ignoring column '" << name << "'";
 #ifdef __EXCEPTIONS
             throw runtime_error(sout.str());