Changeset 16089 for trunk/FACT++

Timestamp:

05/23/13 19:09:19 (12 years ago)

Author:

tbretz

Message:

Use empty() instead of size() where possible; replaced queues by list where possible

Location:

trunk/FACT++/src

Files:

• StateMachineImp.cc (modified) (5 diffs)
• StateMachineImp.h (modified) (4 diffs)

trunk/FACT++/src/StateMachineImp.cc

@@ -137 +137 @@
     for (vector<EventImp*>::iterator cmd=fListOfEvents.begin(); cmd!=fListOfEvents.end(); cmd++)
         delete *cmd;
-
-    // Unfortunately, front() doesn't necessarily return 0 if
-    // queue is empty
-    while (fEventQueue.size())
-    {
-        Event *q=fEventQueue.front();
-        if (!q)
-            break;
-
-        fEventQueue.pop();
-        delete q;
-    }
 }
 
@@ -178 +166 @@
 {
     const lock_guard<mutex> guard(fMutex);
-    fEventQueue.push(cmd);
+    fEventQueue.push_back(shared_ptr<Event>(cmd));
 }
 
@@ -190 +178 @@
 //!    A pointer to an Event object
 //
-Event *StateMachineImp::PopEvent()
+shared_ptr<Event> StateMachineImp::PopEvent()
 {
     const lock_guard<mutex> guard(fMutex);
@@ -196 +184 @@
     // Get the next event from the stack
     // and remove event from the stack
-    Event *cmd = fEventQueue.front();
-    fEventQueue.pop();
-
+    const shared_ptr<Event> cmd = fEventQueue.front();
+    fEventQueue.pop_front();
     return cmd;
 }
@@ -1037 +1024 @@
 
             // Pop the next command which arrived from the stack
-            const auto_ptr<Event> cmd(PopEvent());
+            const shared_ptr<Event> cmd(PopEvent());
 
             if (!HandleEvent(*cmd))

trunk/FACT++/src/StateMachineImp.h

@@ -3 +3 @@
 
 #include <map>
-#include <queue>
+#include <list>
 #include <mutex>
 #include <vector>
+#include <memory>
 
 #include "MainImp.h"
@@ -43 +44 @@
 private:
     std::vector<EventImp*> fListOfEvents; /// List of available commands as setup by user
-    std::queue<Event*>     fEventQueue;   /// Event queue (fifo) for the received commands
+    std::list<std::shared_ptr<Event>> fEventQueue;   /// Event queue (fifo) for the received commands
 
     std::mutex fMutex;    /// Mutex to ensure thread-safe access to the command fifo
@@ -54 +55 @@
     /// Push a command into the fifo. The fifo takes over ownership
     void PushEvent(Event *cmd);
-    /// Pop a command from the fifo. You take over owenership
-    Event *PopEvent();
+    /// Pop a command from the fifo.
+    std::shared_ptr<Event> PopEvent();
 
     bool HandleNewState(int newstate, const EventImp *evt, const char *txt);
@@ -137 +138 @@
     EventImp *FindEvent(const std::string &evt);
 
-    bool IsQueueEmpty() const { return fEventQueue.size()==0; }
+    bool IsQueueEmpty() const { return fEventQueue.empty(); }
 
     //const std::vector<EventImp*> &GetListOfEvents() const { return fListOfEvents; }