Changeset 16445

Timestamp:

05/30/13 00:23:28 (11 years ago)

Author:

tbretz

Message:

Added time to output; Require the physics trigger be enables and switched on to go to InProgress; leave InProgress if one of the two conditions is not fullfilled anymore; print a message when stop was received.

File:

• trunk/FACT++/src/ratecontrol.cc (modified) (12 diffs)

trunk/FACT++/src/ratecontrol.cc

@@ -48 +48 @@
     PixelMap fMap;
 
+    bool fPhysTriggerEnabled;
     bool fTriggerOn;
 
@@ -100 +101 @@
         //    return;
 
-        if (!fThresholds.empty())
+        if (fThresholds.empty())
             return;
 
@@ -360 +361 @@
 
         const FTM::DimStaticData &sdata = *static_cast<const FTM::DimStaticData*>(evt.GetData());
-        fTriggerOn = sdata.HasTrigger();
-
+        fPhysTriggerEnabled = sdata.HasTrigger();
+        fTriggerOn = (evt.GetQoS()&FTM::kFtmStates)==FTM::kFtmRunning;
+
+        Out() << "\n" << evt.GetTime() << ": " << (bool)fTriggerOn << " " << (bool)fPhysTriggerEnabled << endl;
         PrintThresholds(sdata);
 
@@ -371 +374 @@
     int HandleTriggerRates(const EventImp &evt)
     {
+        fTriggerOn = (evt.GetQoS()&FTM::kFtmStates)==FTM::kFtmRunning;
+
         if (fThresholds.empty())
             return GetCurrentState();
@@ -523 +528 @@
     int Calibrate()
     {
-        if (!fTriggerOn)
+        if (!fPhysTriggerEnabled)
         {
             Info("Physics trigger not enabled... CALIBRATE command ignored.");
@@ -551 +556 @@
     int CalibrateByCurrent()
     {
-        if (!fTriggerOn)
+        if (!fPhysTriggerEnabled)
         {
             Info("Physics trigger not enabled... CALIBRATE command ignored.");
@@ -596 +601 @@
             Info("No calibration requested.");
             return RateControl::State::kGlobalThresholdSet;
+            break;
 
         case 1:
@@ -615 +621 @@
     int StopRC()
     {
+        Info("Stop received.");
         return RateControl::State::kConnected;
     }
@@ -669 +676 @@
             return RateControl::State::kDisconnected;
 
-        const bool inprog = fTriggerOn && fDimRS.state()<RateScan::State::kConfiguring;
+        // Do not allow any action while a ratescan is configured or in progress
+        if (fDimRS.state()>=RateScan::State::kConfiguring)
+            return RateControl::State::kConnected;
 
         switch (GetCurrentState())
@@ -677 +686 @@
 
         case RateControl::State::kGlobalThresholdSet:
-            if (!inprog)
-                return RateControl::State::kGlobalThresholdSet;
+
+            // Wait for the trigger to get switched on before starting control loop
+            if (fTriggerOn && fPhysTriggerEnabled)
+                return RateControl::State::kInProgress;
+
+            return RateControl::State::kGlobalThresholdSet;
 
         case RateControl::State::kInProgress:
-            if (inprog)
-                return RateControl::State::kInProgress;
+
+            // Go back to connected when the trigger has been switched off
+            if (!fTriggerOn || !fPhysTriggerEnabled)
+                return RateControl::State::kConnected;
+
+            return RateControl::State::kInProgress;
         }
 
@@ -690 +707 @@
 public:
     StateMachineRateControl(ostream &out=cout) : StateMachineDim(out, "RATE_CONTROL"),
-        fTriggerOn(false), fBlock(40),
+        fPhysTriggerEnabled(false), fTriggerOn(false), fBlock(40),
         fDimFTM("FTM_CONTROL"),
         fDimRS("RATE_SCAN"),
@@ -748 +765 @@
         AddEvent("CALIBRATE_RUN", "C")
             (bind(&StateMachineRateControl::CalibrateRun, this, placeholders::_1))
-            ("Start a threshold calibration as defined in the setup for this run-type");
+            ("Start a threshold calibration as defined in the setup for this run-type, state change to InProgress is delayed until trigger enabled");
 
         AddEvent("STOP", RateControl::State::kSettingGlobalThreshold, RateControl::State::kGlobalThresholdSet, RateControl::State::kInProgress)