Changeset 16730 for trunk

Timestamp:

06/05/13 21:12:34 (11 years ago)

Author:

tbretz

Message:

Changed the default queue in three ways: 1) Execute() is called after an Event was handled; 2) a conditional variable is used which gets signaled if a new event is pushed; 3) after a maximum inactivity time of 10ms, Execute is called

Location:

trunk/FACT++/src

Files:

• StateMachineImp.cc (modified) (2 diffs)
• StateMachineImp.h (modified) (2 diffs)

trunk/FACT++/src/StateMachineImp.cc

@@ -167 +167 @@
     const lock_guard<mutex> guard(fMutex);
     fEventQueue.emplace_back(cmd);
+    fCond.notify_one();
 }
 
@@ -1008 +1009 @@
         SetCurrentState(kSM_Ready, "by Run()");
 
-        while (!fExitRequested)
+        std::unique_lock<std::mutex> lock(fMutex);
+        fMutex.unlock();
+
+        while (1)
         {
-            usleep(1);
+            fMutex.lock();
+            if (IsQueueEmpty())
+                fCond.wait_for(lock, chrono::microseconds(10000));
+            fMutex.unlock();
+
+            if (fExitRequested)
+                break;
+
             if (dummy)
                 continue;
 
+            // If the command stack is empty go on with processing in the
+            // current state
+            if (!IsQueueEmpty())
+            {
+                // Pop the next command which arrived from the stack
+                const shared_ptr<Event> cmd(PopEvent());
+                if (!HandleEvent(*cmd))
+                    break;
+            }
+
             // Execute a step in the current state of the state machine
             if (!HandleNewState(Execute(), 0, "by Execute-command"))
-                break;
-
-            // If the command stack is empty go on with processing in the
-            // current state
-            if (IsQueueEmpty())
-                continue;
-
-            // Pop the next command which arrived from the stack
-            const shared_ptr<Event> cmd(PopEvent());
-
-            if (!HandleEvent(*cmd))
                 break;
         }

trunk/FACT++/src/StateMachineImp.h

@@ -7 +7 @@
 #include <vector>
 #include <memory>
+#include <condition_variable>
 
 #include "MainImp.h"
@@ -49 +50 @@
     std::mutex fMutexEvt; /// Mutex to ensure thread-safe access to the command fifo
 
+    std::condition_variable fCond; /// Conditional to signal run the an event is waiting
+
     bool fBufferEvents;  /// Flag if events should be buffered outside the event loop