Changeset 16775

Timestamp:

06/08/13 12:30:58 (11 years ago)

Author:

tbretz

Message:

Introduced a new state kConfiguring3 which checks if the messages to enable the trigger line were really delivered before switching to kConfigured. This never seems necessary, but maybe only because there is a natural delay until the mcp reacts and enables the trigger; removed the ConfigTimer. It seems obsolete with the recent changes in the output buffer queue

File:

• trunk/FACT++/src/fadctrl.cc (modified) (8 diffs)

trunk/FACT++/src/fadctrl.cc

@@ -1088 +1088 @@
         }
 
-        fConfigTimer = Time(Time::none);
-
         // Now the old run is stopped already. So all other servers can start a new run
         // (Note that we might need another step which only checks if the continous trigger
@@ -1095 +1093 @@
         const int64_t runs[2] = { runno, runno+1 };
         fDimStartRun.Update(runs);
-
-        // T::Info(" ==> TODO: Insert/update run configuration in database!");
 
         return FAD::State::kConfiguring1;
@@ -1510 +1506 @@
             if (T::GetCurrentState()==FAD::State::kConfiguring1)
             {
-                // We need some delay so that the FAD is not busy anymore
-                // and really sees the software trigger
-                // FIXME: Do we need this to be configurable?
-                //if (Time()-fConfigTimer<boost::posix_time::milliseconds(3000))
-
                 // Wait until the configuration commands to all boards
                 // have been sent and achknowledged
@@ -1521 +1512 @@
                         return FAD::State::kConfiguring1;
 
-                if (!fConfigTimer)
-                    fConfigTimer = Time();
-
-                // Wait a short moment to ensure that all board have processed
-                // the received data
-                if (Time()-fConfigTimer<boost::posix_time::milliseconds(250))
-                    return FAD::State::kConfiguring1;
-
+                // Now we can sent the trigger
                 for (BoardList::iterator it=fBoards.begin(); it!=fBoards.end(); it++)
                     it->second->Cmd(FAD::kCmdSingleTrigger);
@@ -1567 +1551 @@
 //                const lock_guard<mutex> guard(fMutexReconnect);
 //                fReconnectionList.clear();
+
+                return FAD::State::kConfiguring3;
+            }
+
+            if (T::GetCurrentState()==FAD::State::kConfiguring3)
+            {
+                // Wait until the configuration commands to all boards
+                // have been sent and achknowledged
+                for (BoardList::iterator it=fBoards.begin(); it!=fBoards.end(); it++)
+                    if (!it->second->IsTxQueueEmpty())
+                        return FAD::State::kConfiguring3;
 
                 return FAD::State::kConfigured;
@@ -1675 +1670 @@
         T::AddStateName(FAD::State::kConfiguring2, "Configuring2",
                         "Waiting until all boards returned their configuration and they are valid.");
+
+        T::AddStateName(FAD::State::kConfiguring3, "Configuring3",
+                        "Waiting until 'enable trigger line' was sent to all boards.");
 
         T::AddStateName(FAD::State::kConfigured, "Configured",
@@ -1790 +1788 @@
              "|run_type[string]:Run type which describes the runs");
 
-        T::AddEvent("RESET_CONFIGURE", FAD::State::kConfiguring1, FAD::State::kConfiguring2, FAD::State::kConfigured)
+        T::AddEvent("RESET_CONFIGURE", FAD::State::kConfiguring1, FAD::State::kConfiguring2, FAD::State::kConfiguring3, FAD::State::kConfigured)
             (bind(&StateMachineFAD::ResetConfig, this))
             ("If configuration failed and the fadctrl is waiting for something, use this to reset the state.");
@@ -1957 +1955 @@
     Configs fConfigs;
     Configs::const_iterator fTargetConfig;
-
-    Time fConfigTimer;