Changeset 17929

Timestamp:

07/23/14 12:00:00 (10 years ago)

Author:

tbretz

Message:

It seems that the SQM does not allow asynchronous connections (requests and answers at the same time) very much like the bias crate. Therefore changed the logic of the requests to a synchronous approach.

File:

• trunk/FACT++/src/sqmctrl.cc (modified) (11 diffs)

trunk/FACT++/src/sqmctrl.cc

@@ -29 +29 @@
 
 private:
-    bool fIsVerbose;
-    bool fMsgReceived;
-    bool fMsgValid;
-
+    bool     fIsVerbose;
     uint16_t fTimeout;
 
     boost::asio::streambuf fBuffer;
+
+    boost::asio::deadline_timer fTrigger;
 
     void HandleRead(const boost::system::error_code& err, size_t bytes_received)
@@ -64 +63 @@
         if (!getline(is, buffer, '\n'))
         {
-            Error("Received message does not contain \\n... closing connection.");
+            Fatal("Received message does not contain \\n... closing connection.");
             PostClose(false);
             return;
@@ -72 +71 @@
 
         if (fIsVerbose)
-            Out() << buffer << endl;
+            Out() << Time().GetAsStr("%H:%M:%S.%f") << "[" << buffer.size() << "]: " << buffer << endl;
 
         vector<string> vec;
         boost::split(vec, buffer, boost::is_any_of(","));
 
+        // Send next request in fTimeout milliseconds
+        fTrigger.expires_from_now(boost::posix_time::milliseconds(fTimeout));
+        fTrigger.async_wait(boost::bind(&ConnectionSQM::HandleRequestTrigger,
+                                          this, dummy::error));
         try
         {
@@ -83 +86 @@
 
             if (vec[0]!="r")
-                throw runtime_error("Not a 'reading request' answer.");
+                throw runtime_error("Not a 'reading request' answer: "+vec[0]);
 
             SQM::Data data;
@@ -97 +100 @@
         catch (const exception &e)
         {
-            fMsgValid = false;
             Error("Parsing received data failed ["+string(e.what())+"]");
             Error("Received: "+buffer);
-            PostClose(false);
-            return;
-        }
-
-        fMsgValid    = true;
-        fMsgReceived = true;
+            PostClose(true);
+        }
     }
 
@@ -114 +112 @@
         {
             ostringstream str;
-            str << "Read timeout of " << URL() << ": " << error.message() << " (" << error << ")";// << endl;
+            str << "ReadTimeout of " << URL() << " failed: " << error.message() << " (" << error << ")";// << endl;
             Error(str);
 
@@ -125 +123 @@
             // For example: Here we could schedule a new accept if we
             // would not want to allow two connections at the same time.
-            PostClose(true);
+            //PostClose(true);
             return;
         }
@@ -136 +134 @@
             return;
 
-        if (fMsgReceived)
-        {
-            StartReadReport();
-            return;
-        }
-
         ostringstream str;
-        str << "No answer received from " << URL() << ".";
+        str << "No valid answer received from " << URL() << " within " << ceil(fTimeout*1.5) << "ms";
         Error(str);
 
@@ -149 +141 @@
     }
 
+    void HandleRequestTrigger(const bs::error_code &error)
+    {
+        // 125: Operation canceled (bs::error_code(125, bs::system_category))
+        if (error && error!=ba::error::basic_errors::operation_aborted)
+        {
+            ostringstream str;
+            str << "RequestTrigger failed of " << URL() << " failed: " << error.message() << " (" << error << ")";// << endl;
+            Error(str);
+
+            PostClose(true);
+            return;
+        }
+
+        if (!is_open())
+        {
+            // For example: Here we could schedule a new accept if we
+            // would not want to allow two connections at the same time.
+            //PostClose(true);
+            return;
+        }
+
+        // Check whether the deadline has passed. We compare the deadline
+        // against the current time since a new asynchronous operation
+        // may have moved the deadline before this actor had a chance
+        // to run.
+        if (fTrigger.expires_at() > ba::deadline_timer::traits_type::now())
+            return;
+
+        StartReadReport();
+    }
+
     void StartReadReport()
     {
-        fMsgReceived = false;
-
         PostMessage(string("rx\n"), 3);
+
         async_read_until(*this, fBuffer, '\n',
                          boost::bind(&ConnectionSQM::HandleRead, this,
                                      dummy::error, dummy::bytes_transferred));
 
-        fInTimeout.expires_from_now(boost::posix_time::milliseconds(fTimeout));
+        fInTimeout.expires_from_now(boost::posix_time::milliseconds(fTimeout*2.5));
         fInTimeout.async_wait(boost::bind(&ConnectionSQM::HandleReadTimeout,
                                           this, dummy::error));
@@ -175 +197 @@
 public:
     ConnectionSQM(ba::io_service& ioservice, MessageImp &imp) : Connection(ioservice, imp()),
-        fIsVerbose(true)
+        fIsVerbose(true), fTimeout(0), fTrigger(ioservice)
     {
         SetLogStream(&imp);
@@ -193 +215 @@
     int GetState() const
     {
-        if (!is_open())
-            return SQM::State::kDisconnected;
-
-        return fMsgValid ? SQM::State::kValid : SQM::State::kConnected;
+        return is_open() ? SQM::State::kConnected : SQM::State::kDisconnected;
     }
 };