Changeset 18832 for trunk/FACT++

Timestamp:

04/14/17 20:56:46 (8 years ago)

Author:

tbretz

Message:

Make sure the server does not see itself. This can lead to crashes from the console if it talks to itself. Secured Tools::Split against exceptions from boost::tokenize

File:

• trunk/FACT++/src/StateMachineDimControl.cc (modified) (2 diffs)

trunk/FACT++/src/StateMachineDimControl.cc

@@ -93 +93 @@
     string opt(imp.GetString());
 
-    const map<string,string> data = Tools::Split(opt, true);
+    map<string,string> data;
+    try
+    {
+        data = Tools::Split(opt, true);
+    }
+    catch (const exception &e)
+    {
+        Warn("DIM_CONTROL/START: Parsing failed: "+opt+" ["+string(e.what())+"]");
+        return GetCurrentState();
+    }
+
     if (imp.GetSize()==0 || opt.size()==0 || opt[0]==0)
     {
-        Error("File name missing in DIM_CONTROL/START");
+        Error("DIM_CONTROL/START: File name missing.");
         return GetCurrentState();
     }
@@ -394 +404 @@
 int StateMachineDimControl::HandleServerAdd(const string &server)
 {
+    if (fIsServer && server=="DIM_CONTROL")
+        return GetCurrentState();
+
     if (server!="DIS_DNS")
     {