Changeset 19698 for trunk/Mars

Timestamp:

09/27/19 21:56:54 (5 years ago)

Author:

tbretz

Message:

Changed the default of BaselineShift to false. This is what we use in all our simulations so far. Instead, it can now be manually enabled as a none baseline shft introduces strange values (which depend on the number of connected pixels) due to the clipping.

File:

• trunk/Mars/msimcamera/MSimTrigger.cc (modified) (6 diffs)

trunk/Mars/msimcamera/MSimTrigger.cc

@@ -107 +107 @@
       fDigitalSignalLength(8),
       fCoincidenceTime(0.5),
-      fShiftBaseline(kTRUE),
+      fShiftBaseline(kFALSE),
       fUngainSignal(kTRUE),
       fSimulateElectronics(kTRUE),
@@ -355 +355 @@
 //        return kFALSE;
 //    }
-
+/*
     if (fElectronicNoise && !fRouteAC.IsEmpty() && !fRouteAC.IsDefaultCol())
     {
@@ -362 +362 @@
         fElectronicNoise = 0;
     }
-
+*/
     if (fGain && !fRouteAC.IsEmpty() && !fRouteAC.IsDefaultCol())
     {
@@ -557 +557 @@
                 if (pixel_id<fCamera->GetNumChannels())
                 {
-                    //(*raw_patches)[patch_id].AddSignal((*fCamera)[pixel_id]);
+                    // FIXME: There must also be a correction for the AC-coupling. Fortunately it is tiny
+                    // and for one channel in the order of a few ADC counts
+                    if (fShiftBaseline && fElectronicNoise)
+                        (*patches)[patch_id].ShiftSignal(-(1+fCableDamping)*(*fElectronicNoise)[pixel_id].GetPedestal());
+
                     (*patches)[patch_id].AddSignal((*fCamera)[pixel_id]);
                     (*patches)[patch_id].AddSignal((*fCamera)[pixel_id], fCableDelay, fCableDamping);
@@ -627 +631 @@
     {
         // FIXME: What if the gain was also allpied to the baseline?
-        const Double_t offset = fElectronicNoise ? (*fElectronicNoise)[i].GetPedestal() : 0;
-        const Double_t gain   = fGain            ? (*fGain)[i].GetPedestal()            : 1;
+        const Double_t offset = fElectronicNoise && empty ? (*fElectronicNoise)[i].GetPedestal() : 0;
+        const Double_t gain   = fGain                     ? (*fGain)[i].GetPedestal()            : 1;
         // FIXME: fCableDelay not taken into account when calculating the
         // valid range, therefore, fCableDelay must be smaller than the pulse width
@@ -894 +898 @@
     }
 
+    if (IsEnvDefined(env, prefix, "ShiftBaseline", print))
+    {
+        rc = kTRUE;
+        fShiftBaseline = GetEnvValue(env, prefix, "ShiftBaseline", fShiftBaseline);
+    }
+
     return rc;
 }