Changeset 19771 for trunk

Timestamp:

10/15/19 08:42:18 (5 years ago)

Author:

tbretz

Message:

Fixed a bug which could lead (not in La Palma though) to inconsistent path and file names.

File:

• trunk/FACT++/src/datalogger.cc (modified) (4 diffs)

trunk/FACT++/src/datalogger.cc

@@ -349 +349 @@
     string CompileFileNameWithPath(const string &path, const string &service, const string & extension);
     ///Form the file names only
-    string CompileFileName(const string& service, const string& extension, const Time& time=Time()) const;
+    string CompileFileName(const string& service, const string& extension, const uint32_t& night) const;
     ///Check whether service is in black and/or white list
     bool ShouldSubscribe(const string& server, const string& service);
@@ -831 +831 @@
 //! @param extension the extension to add, if any
 //
-string DataLogger::CompileFileName(const string& service, const string& extension, const Time& time) const
+string DataLogger::CompileFileName(const string& service, const string& extension, const uint32_t& night) const
 {
     ostringstream str;
 
-    const Time ftime(time);//removed this as already done by nightAsInt: -boost::posix_time::hours(12));
-    str << ftime.NightAsInt();
+    str << night;
 
     if (!service.empty())
@@ -853 +852 @@
     const Time time;
 
-    //calculate time suitable for naming files.
-    //fCurrentDay is 30 minutes after upcoming sunrise. So just use 12 hours before then
+    // calculate time suitable for naming files. Get a time between the next sun-rise (fCurrentDay)
+    // and the previous sun-rise so that NightAsInt (which refers to the previous sun-rise)
+    // provides reasonable results.
+
+    // WARNING: This fails if the sun-rise is around midnight UTC!
+    // It would be more appropriate to relate the "NightAsInt" to
+    // the LOCAL time of sun-rise!
     const Time ftime = fCurrentDay-boost::posix_time::hours(12);
 
     //output it
-    str << path << ftime.GetAsStr("/%Y/%m/%d");
+    const uint32_t night = ftime.NightAsInt();
+    str << path << Tools::Form("/%04d/%02d/%02d/", night/10000, (night/100)%100, night%100);
 
     //check if target directory exist
@@ -864 +869 @@
         CreateDirectory(str.str());
 
-    str << '/' << CompileFileName(service, extension, ftime);//fCurrentDay);
+    str << '/' << CompileFileName(service, extension, night);//fCurrentDay);
 
     return str.str();