Changeset 20086 for trunk

Timestamp:

04/20/21 23:25:43 (4 years ago)

Author:

tbretz

Message:

Trying to improve exception safety of closing a connection. Calling shutdown is suggested in the close documentation and using the error code should prevent exceptions.

File:

• trunk/FACT++/src/Connection.cc (modified) (1 diff)

trunk/FACT++/src/Connection.cc

@@ -100 +100 @@
 
     // Close possible open connections
-    close();
+    if (is_open())
+    {
+        bs::error_code err;
+        shutdown(boost::asio::ip::tcp::socket::shutdown_both, err);
+        if (err)
+        {
+            ostringstream str;
+            str << "Shutting down " << URL() << ": " << err.message() << " (" << err << ")";// << endl;
+            Error(str);
+        }
+        close(err);
+        if (err)
+        {
+            ostringstream str;
+            str << "Closing " << URL() << ": " << err.message() << " (" << err << ")";// << endl;
+            Error(str);
+        }
+    }
 
     // Reset the connection status