Changeset 3239 for trunk

Timestamp:

02/19/04 11:00:22 (21 years ago)

Author:

moralejo

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mhist/MHEvent.cc (modified) (2 diffs)
• mhist/MHEvent.h (modified) (2 diffs)
• mmain/MEventDisplay.cc (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -4 +4 @@
 
                                                  -*-*- END OF LINE -*-*-
+ 2004/01/19: Thomas Bretz
+
+   * mhist/MHEvent.[h,cc]:
+     - Changed names of Event "types" to make them more descriptive.
+       Former kEvtSignal is now called kEvtSignalDensity, and indicates
+       pixel content scaled by area. Added kEvtSignalRaw, which 
+       corresponds to pixel content (with no scaling) in whatever units
+       (this depends on how the MHEvent object is filled!). The default
+       constructor initializes type=kEvtSignalRaw.
+
+   * mmain/MEventDisplay.cc
+     - Changed filling of evt1 and evt2. Now they are filled with raw 
+       content of MCerPhotEvt. Since in MEventDisplay, MCerPhotEvt is
+       still filled uncalibrated (hence in ADC counts), this means that 
+       what will be now shown in Mars' camera display is now the signal 
+       in each pixel without scaling with pixel area. Given that the 
+       default flat fielding is such that equal light density 
+       corresponds to equal absolute signal (in ADC counts), this is 
+       more reasonable, and allows to check for instance how the 
+       relative pixel gains are adjusted by looking at calibration 
+       events. To be FIXED: there is however an "inconsistency" in 
+       MEventDisplay, and it is that MCerPhotEvt is still used to keep
+       uncalibrated signals. To be replaced by MExtractedSignalCam?
+
+
  2004/01/19: Thomas Bretz
 

trunk/MagicSoft/Mars/mhist/MHEvent.cc

@@ -122 +122 @@
     switch (fType)
     {
-    case kEvtSignal:
-        fHist->SetName("Signal");
+    case kEvtSignalRaw:
+        fHist->SetName("Signal (raw)");
+        fHist->SetYTitle("S [au]");
+        break;
+    case kEvtSignalDensity:
+        fHist->SetName("Signal density");
         fHist->SetYTitle("S [au]");
         break;
@@ -182 +186 @@
     switch (fType)
     {
-    case kEvtSignal: // Get NumPhotons without pixel-size scaling
-        //        fHist->SetCamContent(*event, 3);
-        //        break;
+    case kEvtSignalRaw:   // Get Content without pixel-size scaling
+        fHist->SetCamContent(*event, 3);
+        break;
+    case kEvtSignalDensity:
+        fHist->SetCamContent(*event, 0);
+        break;
     case kEvtPedestal:
         fHist->SetCamContent(*event, 0);

trunk/MagicSoft/Mars/mhist/MHEvent.h

@@ -20 +20 @@
 public:
     enum EventType_t {
-        kEvtSignal, kEvtPedestal, kEvtPedestalRMS,
-        kEvtRelativeSignal, kEvtCleaningLevels,
-        kEvtIdxMax, kEvtArrTime
+        kEvtSignalRaw, kEvtSignalDensity, kEvtPedestal, 
+        kEvtPedestalRMS, kEvtRelativeSignal, kEvtCleaningLevels,
+        kEvtIdxMax, kEvtArrTime 
     };
 
@@ -47 +47 @@
 
 public:
-    MHEvent(EventType_t type=kEvtSignal);
+    MHEvent(EventType_t type=kEvtSignalRaw);
     ~MHEvent();
 

trunk/MagicSoft/Mars/mmain/MEventDisplay.cc

@@ -156 +156 @@
     fEvtLoop->SetParList(plist);
 
-    MHEvent *evt1 = new MHEvent(MHEvent::kEvtSignal);
-    MHEvent *evt2 = new MHEvent(MHEvent::kEvtSignal);
+    MHEvent *evt1 = new MHEvent(MHEvent::kEvtSignalRaw);
+    MHEvent *evt2 = new MHEvent(MHEvent::kEvtSignalRaw);
     MHEvent *evt3 = new MHEvent(MHEvent::kEvtPedestal);
     MHEvent *evt4 = new MHEvent(MHEvent::kEvtPedestalRMS);