Changeset 3273

Timestamp:

02/24/04 15:40:29 (21 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mcalib/MCalibrationChargePix.cc (modified) (2 diffs)

trunk/MagicSoft/Mars/Changelog

@@ -5 +5 @@
                                                  -*-*- END OF LINE -*-*-
  
+
+ 2004/02/24: Markus Gaug
+
+   * mcalib/MCalibrationChargePix.cc
+     - discovered an error in the calculation of phe's in 
+       CalcFFactorMethod(). The average QE was applied twice. 
+       This error has been introduced on 13/02/04
+
 
  2004/02/23: Markus Gaug

trunk/MagicSoft/Mars/mcalib/MCalibrationChargePix.cc

@@ -732 +732 @@
 
   //
-  // Calculate the number of photons from the F-Factor method
-  // FIXME: This is a preliminary solution, the qe shall be 
-  // calibrated itself!
-  //
-  fPheFFactorMethod /= fAverageQE;
-
+  // Calculate the Error of Nphe
+  //
   const Float_t pheFFactorRelErrSquare =  ffactorsquareRelErrSquare
-      + chargeSquareRelErrSquare
-      + rsigmaSquareRelErrSquare
-      + avQERelErrSquare;
-  
+                                        + chargeSquareRelErrSquare
+                                        + rsigmaSquareRelErrSquare;
   fPheFFactorMethodErr                 =  TMath::Sqrt(pheFFactorRelErrSquare) * fPheFFactorMethod;
-      
-  fMeanConversionFFactorMethod         =  fPheFFactorMethod / GetMeanCharge() ;
-  fConversionFFactorMethodErr          =  ( pheFFactorRelErrSquare + chargeRelErrSquare )
-                                       * fMeanConversionFFactorMethod * fMeanConversionFFactorMethod;
-      
-  const Float_t convrelerror           =   fConversionFFactorMethodErr
-                                       / fMeanConversionFFactorMethod;
-  
-  if ( (fMeanConversionFFactorMethod > 0.) && (convrelerror < fConvFFactorRelErrLimit))
-      SETBIT(fFlags,kFFactorMethodValid);
-
-  fSigmaConversionFFactorMethod = GetTotalFFactorFFactorMethod()*TMath::Sqrt(fMeanConversionFFactorMethod);
-
-  //
-  // Calculate the Total F-Factor of the camera ( in photons )
-  //
-  if (fPheFFactorMethod > 0)
-  {      
-      fTotalFFactorFFactorMethod =  (fRSigmaCharge/GetMeanCharge())*TMath::Sqrt(fPheFFactorMethod);
-      fTotalFFactorFFactorMethod *=  avQEFFactor;
-  }
+
+  //
+  // Calculate the conversion factor between PHOTONS and FADC counts
+  //
+  fMeanConversionFFactorMethod         =  fPheFFactorMethod / GetMeanCharge() / fAverageQE;
+
+  if (fMeanConversionFFactorMethod < 0.)
+      return kFALSE;
+
+  //
+  // Calculate the error of the mean conversion factor between PHOTONS and FADC counts
+  //
+  const Float_t convRelErrSquare     =  ( pheFFactorRelErrSquare + chargeRelErrSquare + avQERelErrSquare);
+  
+  if (convRelErrSquare < 0.)
+      return kFALSE;
+
+  const Float_t convRelErr           =  TMath::Sqrt(convRelErrSquare);
+  fConversionFFactorMethodErr        = convRelErr * fMeanConversionFFactorMethod;
+  
+  if (convRelErr < fConvFFactorRelErrLimit)
+      SetFFactorMethodValid();
+
+  //
+  // Calculate the Total F-Factor of the camera (in photons)
+  //
+  fTotalFFactorFFactorMethod =  (fRSigmaCharge/GetMeanCharge())*TMath::Sqrt(fPheFFactorMethod);
+  fTotalFFactorFFactorMethod *=  avQEFFactor;
       
   //
@@ -776 +777 @@
                                                 + pheFFactorRelErrSquare
                                                 + avQEFFactorRelErrSquare  );
-  
   fTotalFFactorErrFFactorMethod *= fTotalFFactorFFactorMethod;
 
-  SetFFactorMethodValid();
+  //
+  // Calculate the sigma of the conversion from FADC counts to photons
+  //
+  fSigmaConversionFFactorMethod = GetTotalFFactorFFactorMethod()*TMath::Sqrt(fMeanConversionFFactorMethod);
+
   return kTRUE;
 }