Changeset 3417

Timestamp:

03/07/04 14:05:58 (21 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mcalib/MCalibrationChargeCalc.cc (modified) (9 diffs)
• mcalib/MCalibrationChargeCalc.h (modified) (6 diffs)
• mcalib/Makefile (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -4 +4 @@
 
                                                  -*-*- END OF LINE -*-*-
+
+2004/03/06: Markus Gaug
+
+  * macros/calibration.C
+    - adapted call to MHCamera::ProjectionS to the new version
+
+  * mcalib/Makefile
+    - include directory mbadpixels
+
+  * mcalib/MCalibrationChargeCalc.[h,cc]
+    - include MBadPixelsCam
+    - remove exclusion of pixels from ascii-file
+      (now accessible from MBadPixelsCam)
+
 
 2004/03/05: Nadia Tonello

trunk/MagicSoft/Mars/mcalib/MCalibrationChargeCalc.cc

@@ -37 +37 @@
 //               Initialize pulser light wavelength
 //               
-//   ReInit:     MCalibrationCam::InitSize(NumPixels) is called which allocates
-//               memory in a TClonesArray of type MCalibrationChargePix
+//   ReInit:     MCalibrationCam::InitSize(NumPixels) is called from MGeomApply (which allocates
+//               memory in a TClonesArray of type MCalibrationChargePix)
+//               Initializes pointer to MBadPixelsCam
 //
 //   Process:    Nothing done by this class, histograms are filled by 
@@ -57 +58 @@
 //   MRawEvtData
 //   MPedestalCam
-//   MCalibrationCam
+//   MBadPixelsCam
 //
 //  Output Containers:
 //   MCalibrationCam
+//   MBadPixelsCam
 //
 //
@@ -174 +176 @@
 #include "MCalibrationChargeCalc.h"
 
-// FXIME: Usage of fstream is a preliminary workaround!
-#include <fstream>
-
 #include <TSystem.h>
 #include <TH1.h>
@@ -200 +199 @@
 #include "MExtractedSignalPix.h"
 
+#include "MBadPixelsCam.h"
+#include "MBadPixelsPix.h"
+
 
 ClassImp(MCalibrationChargeCalc);
@@ -211 +213 @@
 MCalibrationChargeCalc::MCalibrationChargeCalc(const char *name, const char *title)
     : fPedestals(NULL), fCam(NULL), 
-      fRawEvt(NULL), fRunHeader(NULL), fGeom(NULL), fEvtTime(NULL),
+      fRawEvt(NULL), fRunHeader(NULL), fGeom(NULL), 
+      fBadPixels(NULL), fEvtTime(NULL),
       fSignals(NULL), fPINDiode(NULL), fBlindPixel(NULL)
 {
@@ -235 +238 @@
     fNumLoGainSamples  = 0;
     fConversionHiLo    = 0;
-    fNumExcludedPixels = 0;
 
 }
@@ -323 +325 @@
     }
   
+  fBadPixels = (MBadPixelsCam*)pList->FindCreateObj("MBadPixelsCam");
+  if (!fBadPixels)
+    {
+      *fLog << err << "Could not find or create MBadPixelsCam ... aborting." << endl;
+      return kFALSE;
+    }
+  
   fCam->SetGeomCam(fGeom);
-
-  fNumHiGainSamples =  fSignals->GetNumUsedHiGainFADCSlices();
-  fNumLoGainSamples =  fSignals->GetNumUsedLoGainFADCSlices();
-  fSqrtHiGainSamples = TMath::Sqrt((Float_t)fNumHiGainSamples);
-  
-  UInt_t npixels = fGeom->GetNumPixels();
+  fCam->SetBadPixelsCam(fBadPixels);
+
+  fNumHiGainSamples  =  fSignals->GetNumUsedHiGainFADCSlices();
+  fNumLoGainSamples  =  fSignals->GetNumUsedLoGainFADCSlices();
+  fSqrtHiGainSamples =  TMath::Sqrt((Float_t)fNumHiGainSamples);
+  
+  UInt_t npixels     = fGeom->GetNumPixels();
   
   for (UInt_t i=0; i<npixels; i++)
     {
       MCalibrationChargePix &pix = (*fCam)[i];
+      MBadPixelsPix         &bad = (*fBadPixels)[i];
+
       pix.DefinePixId(i);
+
+      if (bad.IsBad())
+        {
+          pix.SetExcluded();
+          continue;
+        }
       
       pix.SetAbsTimeBordersHiGain(fSignals->GetFirstUsedSliceHiGain(),
@@ -341 +359 @@
                                   fSignals->GetLastUsedSliceLoGain());
     }
-  
-  if (fExcludedPixelsFile.IsNull())
-        return kTRUE;
-
-    //
-    // Look for file to exclude pixels from analysis
-    //
-    gSystem->ExpandPathName(fExcludedPixelsFile);
-
-    //
-    // Initialize reading the file
-    //
-    ifstream in(fExcludedPixelsFile);
-    if (!in)
-    {
-        *fLog << warn << "Cannot open file '" << fExcludedPixelsFile << "'" << endl;
-        return kTRUE;
-    }
-
-    *fLog << inf << "Use excluded pixels from file: '" << fExcludedPixelsFile << "'" << endl;
-
-    //
-    // Read the file and count the number of entries
-    //
-    UInt_t pixel = 0;
-
-    while (++fNumExcludedPixels)
-    {
-        in >> pixel;
-        if (!in)
-            break;
-
-        //
-        // Check for out of range
-        //
-        if (pixel > npixels)
-        {
-            *fLog << warn << "WARNING: To be excluded pixel: " << pixel << " is out of range " << endl;
-            continue;
-        }
-        //
-        // Exclude pixel
-        //
-        MCalibrationChargePix &pix = (*fCam)[pixel];
-        pix.SetExcluded();
-
-        *fLog << GetDescriptor() << inf << ": Exclude Pixel: " << pixel << endl;
-
-    }
-
-    if (--fNumExcludedPixels == 0)
-        *fLog << warn << "WARNING: File '" << fExcludedPixelsFile << "'" << " is empty " << endl;
-    else
-        fCam->SetNumPixelsExcluded(fNumExcludedPixels);
 
     return kTRUE;
@@ -436 +400 @@
       const Float_t num    = TMath::Sqrt((Float_t)fPedestals->GetTotalEntries());
 
-      if (ped == -1.) 
-          pix.SetExcluded();
-      
       //
       // Check if the pixel has been excluded from the fits

trunk/MagicSoft/Mars/mcalib/MCalibrationChargeCalc.h

@@ -15 +15 @@
 #endif
 
-#include "TString.h"
-
 class MRawEvtData;
 class MRawRunHeader;
@@ -25 +23 @@
 class MGeomCam;
 class MExtractedSignalCam;
+class MBadPixelsCam;
 class MTime;
 class MCalibrationChargeCalc : public MTask
@@ -35 +34 @@
   MRawRunHeader              *fRunHeader;                 //! RunHeader information
   MGeomCam                   *fGeom;                      //! Geometry information
-
+  MBadPixelsCam              *fBadPixels;                 //! Bad Pixels information
+  
   MTime                      *fEvtTime;                   //! Time of the event
 
@@ -42 +42 @@
   MCalibrationChargeBlindPix *fBlindPixel;                // Calibration results of the Blind Pixel 
 
-  
   Byte_t  fNumHiGainSamples; 
   Byte_t  fNumLoGainSamples; 
@@ -49 +48 @@
   Float_t fConversionHiLo;
   Int_t   fFlags;                                // Flag for the fits used
-
-  TString fExcludedPixelsFile;
-  UInt_t  fNumExcludedPixels;
 
   enum  { kUseQualityChecks,
@@ -72 +68 @@
       {b ? CLRBIT(fFlags, kHiLoGainCalibration) : SETBIT(fFlags, kHiLoGainCalibration);}
 
-
-  // Exclude pixels from configuration file
-  void ExcludePixelsFromAsciiFile(const char *file) { fExcludedPixelsFile = file;  }
-  
   ClassDef(MCalibrationChargeCalc, 1)   // Task to fill the Calibration Containers from raw data
 };

trunk/MagicSoft/Mars/mcalib/Makefile

@@ -23 +23 @@
 #
 INCLUDES = -I. -I../mbase -I../mhbase -I../mgui -I../mgeom -I../manalysis \
-           -I../mraw -I../mtools -I../mmc -I../mimage -I../msignal
+           -I../mraw -I../mtools -I../mmc -I../mimage -I../msignal -I../mbadpixels
 
 # mhbase:    MBinning MH