Changeset 3445 for trunk

Timestamp:

03/09/04 14:36:31 (21 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• Makefile.rules (modified) (1 diff)
• mcalib/MCalibrationChargeCalc.cc (modified) (1 diff)
• mcalib/MHCalibrationChargeBlindPix.cc (modified) (3 diffs)
• mcalib/MHCalibrationChargeCam.cc (modified) (5 diffs)
• mcalib/MHCalibrationChargePINDiode.cc (modified) (2 diffs)
• mjobs/MJCalibration.cc (modified) (2 diffs)
• mjobs/MJCalibration.h (modified) (1 diff)
• mjobs/MJExtractSignal.h (modified) (1 diff)
• mjobs/MJPedestal.h (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -2 +2 @@
 to   send  a   Changelog   file  to  a  line  printer  directly.  Thanks.
 
+For your entries please follow this style:
+
+_yyyy/mm/dd:_[Your Name]
+_
+___*_filename:
+_____-_description
+_
+___*_filename2, filename3:
+_____-_description
+_
+_
+_
+
+While an underscore is a placeholder for a white-space or an empty line.
 
                                                  -*-*- END OF LINE -*-*-
+ 2004/03/09: Thomas Bretz
+
+   * Makefile.rules:
+     - replaced *.o by $(...) for building archives
+
+   * mjobs/MJCalibration.cc:
+     - exchanged  apply  and merge task
+
+   * mjobs/MJCalibration.h, mjobs/MJExtractSignal.h, mjobs/MJPedestal.h:
+     - fixed some const-qualifiers
+
+   * mcalib/MHCalibrationChargeBlindPix.cc, 
+     mcalib/MHCalibrationChargeCam.cc,
+     mcalib/MHCalibrationChargePINDiode.cc
+     - removed some obsolete output when calling FindCreateObj
+     - changed some 'not found' output messages to be 'Mars-compliant'
+     - replaced some gLog by *fLog
+
+
+
  2004/03/08: Markus Gaug
    
-  * mbadpixels/MBadPixelsPix.h
+   * mbadpixels/MBadPixelsPix.h
      - small modifications for better readability
      - remove Getters for calibration methods
 
-  * mcalib/MCalibrationChargeCam.cc
+   * mcalib/MCalibrationChargeCam.cc
      - displaying saturation also for not-valid pixels in GetPixelContent
+
+
 
  2004/03/08: Thomas Bretz

trunk/MagicSoft/Mars/Makefile.rules

@@ -3 +3 @@
 $(LIB): $(OBJS) $(CINT)Cint.o
         @echo " - Building Library lib$(LIB)"
-        $(AR) $(LIB) *.o
+        $(AR) $(LIB) $(OBJS) $(CINT)Cint.o
         @echo " "
 

trunk/MagicSoft/Mars/mcalib/MCalibrationChargeCalc.cc

@@ -348 +348 @@
 
       if (bad.IsBad())
-        {
+      {
           pix.SetExcluded();
           continue;
-        }
-      
+      }
+
       pix.SetAbsTimeBordersHiGain(fSignals->GetFirstUsedSliceHiGain(),
                                   fSignals->GetLastUsedSliceHiGain());

trunk/MagicSoft/Mars/mcalib/MHCalibrationChargeBlindPix.cc

@@ -241 +241 @@
     if (!fRawEvt)
     {
-      *fLog << err << dbginf << "MRawEvtData not found... aborting." << endl;
+      *fLog << err << "MRawEvtData not found... aborting." << endl;
       return kFALSE;
     }
@@ -248 +248 @@
   if (!fSignal)
   {
-      *fLog << err << GetDescriptor() << ": ERROR: Could not find MExtractedSignalBlindPixel ... aborting " << endl;
+      *fLog << err << "MExtractedSignalBlindPixel not found... aborting " << endl;
       return kFALSE;
   }
@@ -262 +262 @@
   fBlindPix = (MCalibrationChargeBlindPix*)pList->FindCreateObj("MCalibrationChargeBlindPix");
   if (!fBlindPix)
-  {
-      *fLog << err << GetDescriptor() << ": ERROR: Could not find MCalibrationChargeBlindPix ... aborting " << endl;
-      return kFALSE;
-  }
+      return kFALSE;
 
   return kTRUE;

trunk/MagicSoft/Mars/mcalib/MHCalibrationChargeCam.cc

@@ -275 +275 @@
   
   fRawEvt = (MRawEvtData*)pList->FindObject("MRawEvtData");
-
   if (!fRawEvt)
   {
-      gLog << err << dbginf << "MRawEvtData not found... aborting." << endl;
+      *fLog << err << dbginf << "MRawEvtData not found... aborting." << endl;
       return kFALSE;
   }
 
   fGeom = (MGeomCam*)pList->FindObject("MGeomCam");
-
   if (!fGeom)
   {
-      gLog << err << dbginf << "MGeomCam not found... aborting." << endl;
+      *fLog << err << "MGeomCam not found... aborting." << endl;
       return kFALSE;
   }
@@ -306 +304 @@
   fBadPixels = (MBadPixelsCam*)pList->FindCreateObj("MBadPixelsCam");
   if (!fBadPixels)
+      return kFALSE;
+
+
+  fCam = (MCalibrationChargeCam*)pList->FindCreateObj("MCalibrationChargeCam");
+  if (!fCam)
+      return kFALSE;
+
+  MExtractedSignalCam *signal = (MExtractedSignalCam*)pList->FindObject("MExtractedSignalCam");
+  if (!signal)
   {
-      gLog << err << GetDescriptor() << ": ERROR: Could not find MBadPixelsCam ... aborting " << endl;
+      *fLog << err << "MExtractedSignalCam not found... abort." << endl;
       return kFALSE;
   }
-
-
-  fCam = (MCalibrationChargeCam*)pList->FindCreateObj("MCalibrationChargeCam");
-  if (!fCam)
-  {
-      gLog << err << GetDescriptor() << ": ERROR: Could not find MCalibrationChargeCam ... aborting " << endl;
-      return kFALSE;
-  }
-
-  MExtractedSignalCam *signal = (MExtractedSignalCam*)pList->FindObject("MExtractedSignalCam");
-  if (!signal)
-    {
-      gLog << err << "No argument in MExtractedSignalCam::ReInit... abort." << endl;
-      return kFALSE;
-    }
 
   const Int_t n = signal->GetSize();
@@ -382 +374 @@
   if (!signal)
     {
-      gLog << err << "No argument in MExtractedSignalCam::Fill... abort." << endl;
+      *fLog << err << "No argument in MExtractedSignalCam::Fill... abort." << endl;
       return kFALSE;
     }
@@ -390 +382 @@
   if (fHiGainArray->GetEntries() != n)
     {
-      gLog << err << "ERROR - Size mismatch... abort." << endl;
+      *fLog << err << "ERROR - Size mismatch... abort." << endl;
       return kFALSE;
     }
@@ -396 +388 @@
   if (fLoGainArray->GetEntries() != n)
     {
-      gLog << err << "ERROR - Size mismatch... abort." << endl;
+      *fLog << err << "ERROR - Size mismatch... abort." << endl;
       return kFALSE;
     }

trunk/MagicSoft/Mars/mcalib/MHCalibrationChargePINDiode.cc

@@ -134 +134 @@
   if (!fPINDiode)
   {
-      *fLog << err << GetDescriptor() << ": ERROR: Could not find MCalibrationChargePINDiode ... aborting " << endl;
+      *fLog << err << "MCalibrationChargePINDiode not found... aborting " << endl;
       return kFALSE;
   }
@@ -163 +163 @@
   if (fExtractSlices != 0. && slices != fExtractSlices )
     {
-      gLog << err << "Number of used signal slices changed in MExtractedSignalCam  ... abort." 
+      *fLog << err << "Number of used signal slices changed in MExtractedSignalCam  ... abort."
            << endl;
       return kFALSE;

trunk/MagicSoft/Mars/mjobs/MJCalibration.cc

@@ -508 +508 @@
     MCalibrationChargeCalc   calcalc;
 
-    MFillH fillpin(  "MHCalibrationChargePINDiode" , "MExtractedSignalPINDiode"   );
-    MFillH fillblind("MHCalibrationChargeBlindPix" , "MExtractedSignalBlindPixel" );
-    MFillH fillcam  ("MHCalibrationChargeCam"      , "MExtractedSignalCam"        );
+    MFillH fillpin  ("MHCalibrationChargePINDiode", "MExtractedSignalPINDiode");
+    MFillH fillblind("MHCalibrationChargeBlindPix", "MExtractedSignalBlindPixel");
+    MFillH fillcam  ("MHCalibrationChargeCam",      "MExtractedSignalCam");
     // 
     // Apply a filter against cosmics
@@ -522 +522 @@
 
     tlist.AddToList(&read);
+    tlist.AddToList(&merge);
     tlist.AddToList(&apply);
-    tlist.AddToList(&merge);
     tlist.AddToList(&extract);
     tlist.AddToList(&pinext);  

trunk/MagicSoft/Mars/mjobs/MJCalibration.h

@@ -40 +40 @@
     TString GetOutputFile() const;
 
-    const MCalibrationChargeCam &GetCalibrationCam() const { return fCalibrationCam; }
-    const MBadPixelsCam         &GetBadPixels()      const { return fBadPixels; }
+    MCalibrationChargeCam &GetCalibrationCam() { return fCalibrationCam; }
+    const MBadPixelsCam &GetBadPixels() const { return fBadPixels; }
 
-    void SetBadPixels(MBadPixelsCam &bad) { bad.Copy(fBadPixels); }
+    void SetBadPixels(const MBadPixelsCam &bad) { bad.Copy(fBadPixels); }
 
     Bool_t ReadCalibrationCam();

trunk/MagicSoft/Mars/mjobs/MJExtractSignal.h

@@ -44 +44 @@
     TString GetOutputFileD() const;
 
-    const MPedPhotCam   &GetPedPhotCam() const { return fPedPhotCam; }
+    MPedPhotCam &GetPedPhotCam() { return fPedPhotCam; }
     const MBadPixelsCam &GetBadPixels()  const { return fBadPixels; }
 
-    void SetBadPixels(MBadPixelsCam &bad) { bad.Copy(fBadPixels); }
+    void SetBadPixels(const MBadPixelsCam &bad) { bad.Copy(fBadPixels); }
 
     Bool_t ProcessD(MPedestalCam &pedcam);

trunk/MagicSoft/Mars/mjobs/MJPedestal.h

@@ -40 +40 @@
     TString GetOutputFile() const;
 
-    const MPedestalCam  &GetPedestalCam() const { return fPedestalCam; }
-    const MBadPixelsCam &GetBadPixels()   const { return fBadPixels; }
+    MPedestalCam &GetPedestalCam() { return fPedestalCam; }
+    const MBadPixelsCam &GetBadPixels() const { return fBadPixels; }
 
-    void SetBadPixels(MBadPixelsCam &bad) { bad.Copy(fBadPixels); }
+    void SetBadPixels(const MBadPixelsCam &bad) { bad.Copy(fBadPixels); }
 
     Bool_t ProcessFile();