Changeset 3840 for trunk/MagicSoft/Mars

Timestamp:

04/26/04 18:56:45 (21 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mcalib/MHCalibrationRelTimeCam.cc (modified) (5 diffs)
• mcalib/MHCalibrationRelTimePix.cc (modified) (3 diffs)
• mcalib/MHCalibrationRelTimePix.h (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -58 +58 @@
        IsUnsuitableRun(MBadPixelsPix::kUnsuitableRun). This includes 
        now the oscillating pixels (which are sometimes many!!)
+
+   * mcalib/MHCalibrationRelTimePix.cc
+     - commented re-normalization to ns in Renorm()
+     - introduced Getter to fFADCSliceWidth
+
+   * mcalib/MHCalibrationRelTimeCam.cc
+     - renorm to ns in GetPixelsContent()
+     --> now, calibration in MCalibrateRelTimes is consistent
+
 
  2004/04/26: Abelardo Moralejo

trunk/MagicSoft/Mars/mcalib/MHCalibrationRelTimeCam.cc

@@ -296 +296 @@
     }
   
-  const UInt_t npixels  = fGeom->GetNumPixels();
-  const UInt_t nareas   = fGeom->GetNumAreas();
-  const UInt_t nsectors = fGeom->GetNumSectors();
+  const Int_t npixels  = fGeom->GetNumPixels();
+  const Int_t nareas   = fGeom->GetNumAreas();
+  const Int_t nsectors = fGeom->GetNumSectors();
 
   Float_t sumareahi  [nareas],   sumarealo  [nareas];
@@ -349 +349 @@
     }
   
-  for (UInt_t j=0; j<nareas; j++)
+  for (Int_t j=0; j<nareas; j++)
     {
       MHGausEvents &histhi = GetAverageHiGainArea(j);
@@ -358 +358 @@
     }
   
-  for (UInt_t j=0; j<nsectors; j++)
+  for (Int_t j=0; j<nsectors; j++)
     {
       MHGausEvents &histhi = GetAverageHiGainSector(j);
@@ -422 +422 @@
 // ============== 
 //
-// 0: Fitted Mean Relative Arrival Time              (calls: MHGausEvents::GetMean())
-// 1: Error of fitted Mean Relative Arrival Time     (calls: MHGausEvents::GetMeanErr())
-// 2: Sigma of fitted Relative Arrival Time          (calls: MHGausEvents::GetSigma())
-// 3: Error of Sigma of fitted Relative Arrival Time (calls: MHGausEvents::GetSigmaErr())
-//
+// 0: Fitted Mean Relative Arrival Time in ns  (MHGausEvents::GetMean()*MHCalibrationRelTimePix::GetFADCSliceWidth())
+// 1: Error Mean Relative Arrival Time in ns   (MHGausEvents::GetMeanErr()*MHCalibrationRelTimePix::GetFADCSliceWidth())
+// 2: Sigma fitted Relative Arrival Time in ns (MHGausEvents::GetSigma()*MHCalibrationRelTimePix::GetFADCSliceWidth())
+// 3: Error Sigma Relative Arrival Time in ns  (MHGausEvents::GetSigmaErr()*MHCalibrationRelTimePix::GetFADCSliceWidth())
 //
 // Useful variables derived from the fit results:
@@ -445 +444 @@
     return kFALSE;
 
+  const MHCalibrationRelTimePix &pix = (MHCalibrationRelTimePix&)(*this)[idx];
+  const Float_t fadc2ns              = pix.GetFADCSliceWidth();
+
   switch (type)
     {
     case 0:
-      val = (*this)[idx].GetMean();
+      val = pix.GetMean()*fadc2ns;
       break;
     case 1:
-      val = (*this)[idx].GetMeanErr();
+      val = pix.GetMeanErr()*fadc2ns;
       break;
     case 2:
-      val = (*this)[idx].GetSigma();
+      val = pix.GetSigma()*fadc2ns;
       break;
     case 3:
-      val = (*this)[idx].GetSigmaErr();
+      val = pix.GetSigmaErr()*fadc2ns;
       break;
     case 4:
-      val = (*this)[idx].GetProb();
+      val = pix.GetProb();
       break;
     case 5:
-      if (!(*this)[idx].IsGausFitOK())
+      if (!pix.IsGausFitOK())
         val = 1.;
       break;
     case 6:
-      if (!(*this)[idx].IsFourierSpectrumOK())
+      if (!pix.IsFourierSpectrumOK())
         val = 1.;
       break;

trunk/MagicSoft/Mars/mcalib/MHCalibrationRelTimePix.cc

@@ -99 +99 @@
 // If mean and sigma have not yet been set, returns.
 //
+// HAS BEEN COMMENTED IN ORDER TO ALLOW FURTHER CALIBRATION OF OFFSETS IN DATA
+// RETURNS ALWAYS WITHOUT RENORMALIZING!!
 // Results are re-normalized to a value per time (ns) with the formulae:
 //
@@ -109 +111 @@
 {
 
+  /*
   if (fMean == fMeanErr == fSigma == fSigmaErr == 0.)
     return;
@@ -116 +119 @@
   fSigma   *= fFADCSliceWidth;
   fSigmaErr*= fFADCSliceWidth;
-  
+  */
 }

trunk/MagicSoft/Mars/mcalib/MHCalibrationRelTimePix.h

@@ -23 +23 @@
   ~MHCalibrationRelTimePix() {}
 
+  // Getters
+  Float_t GetFADCSliceWidth() const    { return fFADCSliceWidth;  }
+  
   // Setters
   void SetFADCSliceWidth( const Float_t f=fgFADCSliceWidth )  {  fFADCSliceWidth = f; }