Changeset 3931

Timestamp:

05/03/04 10:47:30 (20 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mpedestal/MPedCalcPedRun.cc (modified) (7 diffs)
• mpedestal/MPedCalcPedRun.h (modified) (2 diffs)
• mpedestal/MPedestalCam.cc (modified) (1 diff)
• mpedestal/MPedestalPix.cc (modified) (6 diffs)
• mpedestal/MPedestalPix.h (modified) (2 diffs)

trunk/MagicSoft/Mars/Changelog

@@ -20 +20 @@
 
  2004/05/03: Markus Gaug
+
+   * mpedestals/MPedestalPix.[h,cc]
+     - add a dedicated fValid flag in order to be able to discard pixels
+       from outside (e.g. from MBadPixelsCam)
+
+   * mpedestals/MPedCalcPedRun.[h,cc]
+     - catch badpixels cam from parameter list, if existing and set 
+       corresponding pixels to not valid in MPedestalPix
 
    * mjobs/MGCamDisplays.[h,cc]

trunk/MagicSoft/Mars/mpedestal/MPedCalcPedRun.cc

@@ -116 +116 @@
 #include "MGeomCam.h"
 
+#include "MBadPixelsPix.h"
+#include "MBadPixelsCam.h"
+
 #include "MGeomCamMagic.h"
 
@@ -133 +136 @@
 //
 // Sets:
+// - all pointers to NULL
 // - fWindowSizeHiGain to fgHiGainWindowSize
 // - fWindowSizeLoGain to fgLoGainWindowSize
@@ -144 +148 @@
 MPedCalcPedRun::MPedCalcPedRun(const char *name, const char *title)
     : fWindowSizeHiGain(fgHiGainWindowSize), 
-      fWindowSizeLoGain(fgLoGainWindowSize)
+      fWindowSizeLoGain(fgLoGainWindowSize), 
+      fGeom(NULL),fBad(NULL)
 {
   fName  = name  ? name  : "MPedCalcPedRun";
@@ -263 +268 @@
 //  - MRawRunHeader
 //  - MGeomCam
+//  - MBadPixelsCam
 // 
 // The following output containers are also searched and created if
@@ -298 +304 @@
   if (!fPedestals)
     return kFALSE;
+
+  fBad       =  (MBadPixelsCam*)pList->FindObject("MBadPixelsCam");
 
   return kTRUE;
@@ -318 +326 @@
 // modifying the ranges again, if necessary.
 //
+// A loop over the MBadPixelsCam is performed and bad pixels are set
+// to MPedestalPix::SetValid(kFALSE);
+//
 Bool_t MPedCalcPedRun::ReInit(MParList *pList)
 {
@@ -385 +396 @@
   *fLog << inf << GetDescriptor() << ": Taking " << (int)fWindowSizeLoGain
         << " LoGain FADC samples starting with slice: " << (int)fLoGainFirst << endl;
+
+
+  if (fBad)
+    {
+      const Int_t nbads = fBad->GetSize();
+      for (Int_t i=0; i<(nbads>npixels?npixels:nbads);i++)
+        if ((*fBad)[i].IsBad())
+          (*fPedestals)[i].SetValid(kFALSE);
+    }
   
   return kTRUE;
-  
+      
 }
 // --------------------------------------------------------------------------

trunk/MagicSoft/Mars/mpedestal/MPedCalcPedRun.h

@@ -15 +15 @@
 
 class MGeomCam;
+class MBadPixelsCam;
 class MPedCalcPedRun : public MExtractor
 {
@@ -30 +31 @@
   
   MGeomCam     *fGeom;       // Camera geometry
+  MBadPixelsCam *fBad;       // Bad Pixels
   
   TArrayF fSumx;         // sum of values

trunk/MagicSoft/Mars/mpedestal/MPedestalCam.cc

@@ -314 +314 @@
 
   if (GetSize() <= idx)
+    return kFALSE;
+
+  if (!(*this)[idx].IsValid())
     return kFALSE;
 

trunk/MagicSoft/Mars/mpedestal/MPedestalPix.cc

@@ -17 +17 @@
 !
 !   Author(s): Thomas Bretz  12/2000 <mailto:tbretz@uni-sw.gwdg.de>
+!              Markus Gaug   04/2004 <mailto:markus@ifae.es>               
 !
-!   Copyright: MAGIC Software Development, 2000-2001
+!   Copyright: MAGIC Software Development, 2000-2004
 !
 !
@@ -41 +42 @@
 
 MPedestalPix::MPedestalPix()
+    : fValid(kTRUE)
 {
   Clear();
@@ -52 +54 @@
 void MPedestalPix::Clear(Option_t *o)
 {
-  fPedestal = -1.;
+  fPedestal    = -1.;
   fPedestalRms = -1.;
-
 }
 
@@ -60 +61 @@
 {
 
-  fPedestal = 0.;
+  fPedestal    = 0.;
   fPedestalRms = 0.;
 }
@@ -67 +68 @@
 void MPedestalPix::Set(Float_t m, Float_t r)
 {
-  fPedestal = m; 
+  fPedestal    = m; 
   fPedestalRms = r; 
 }
@@ -73 +74 @@
 Bool_t MPedestalPix::IsValid() const 
 {
+
+  if (!fValid)
+    return kFALSE;
+
  return fPedestal>=0||fPedestalRms>=0;
 }

trunk/MagicSoft/Mars/mpedestal/MPedestalPix.h

@@ -12 +12 @@
   Float_t fPedestal;     // mean value of pedestal (PMT offset)
   Float_t fPedestalRms;  // root mean square / sigma  / standard deviation of pedestal
+  Bool_t  fValid;        // flag to set pixel valid
   
 public:
@@ -26 +27 @@
   
   void Set(const Float_t m, const Float_t r);
+  void SetValid(const Bool_t b=kTRUE)    { fValid = b;  }
   
   // Getters