Changeset 4272

Timestamp:

06/03/04 10:52:24 (20 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mcalib/MCalibrationChargeCalc.cc (modified) (6 diffs)

trunk/MagicSoft/Mars/Changelog

@@ -30 +30 @@
      - replace fNumHiGainFADCSlices and fNumLoGainFADCSlices by a 
        TArrayF and increment ClassDef by 1 for the streamer.
+
+   * mcalib/MCalibrationChargeCalc.cc
+     - found a small bug making a difference in the number of valid 
+       pixels with the blind PIxel method and the ffactor method. Now
+       fixed. (The difference was usually a couple of pixels)
 
 

trunk/MagicSoft/Mars/mcalib/MCalibrationChargeCalc.cc

@@ -1013 +1013 @@
           bad.SetUncalibrated( MBadPixelsPix::kDeviatingNumPhes );
           bad.SetUnsuitable  ( MBadPixelsPix::kUnsuitableRun    );
-          pix.SetExcluded();
+          pix.SetFFactorMethodValid(kFALSE);
           continue;
         }
@@ -1295 +1295 @@
       MCalibrationQEPix   &qepix = (MCalibrationQEPix&)  (*fQECam)[i];
 
-      if (!pix.IsFFactorMethodValid())
-        {
-          qepix.SetExcluded();
-          qepix.SetFFactorMethodValid(kFALSE,fPulserColor);
-          continue;
-        }
-      
+      if (bad.IsUnsuitable(MBadPixelsPix::kUnsuitableRun))
+        continue;
+
       const Float_t photons = avphotons / fGeom->GetPixRatio(i);
       const Float_t qe      = pix.GetPheFFactorMethod() / photons ;
@@ -1307 +1303 @@
       if (!pix.CalcMeanFFactor( photons , avphotrelvar ))
         {
-          pix.SetFFactorMethodValid(kFALSE);
-          qepix.SetFFactorMethodValid(kFALSE, fPulserColor);
           (*fBadPixels)[i].SetUncalibrated( MBadPixelsPix::kDeviatingNumPhes );
+          continue;
+          
         }
 
@@ -1341 +1337 @@
       
       MCalibrationChargePix &pix = (MCalibrationChargePix&)(*fCam)[i];
-
-      if (!pix.IsFFactorMethodValid())
+      MBadPixelsPix         &bad =                   (*fBadPixels)[i];
+
+      if (bad.IsUnsuitable(MBadPixelsPix::kUnsuitableRun))
         continue;
       
       const Float_t ffactor = pix.GetMeanFFactorFADC2Phot();
-      MBadPixelsPix    &bad = (*fBadPixels)[i];
-
       const Int_t   aidx   = (*fGeom)[i].GetAidx();
 
@@ -1357 +1352 @@
           bad.SetUncalibrated( MBadPixelsPix::kDeviatingFFactor );
           bad.SetUnsuitable  ( MBadPixelsPix::kUnsuitableRun    );
+        }
+    }
+
+  for (UInt_t i=0; i<npixels; i++)
+    {
+      
+      MCalibrationChargePix &pix = (MCalibrationChargePix&)(*fCam)[i];
+      MCalibrationQEPix   &qepix = (MCalibrationQEPix&)  (*fQECam)[i];
+      MBadPixelsPix         &bad =                   (*fBadPixels)[i];
+      
+      if (bad.IsUnsuitable(MBadPixelsPix::kUnsuitableRun))
+        {
+          qepix.SetFFactorMethodValid(kFALSE,fPulserColor);
+          pix.SetFFactorMethodValid(kFALSE);
           pix.SetExcluded();
+          continue;
         }
     }
@@ -1425 +1435 @@
         }
       
-      MBadPixelsPix       &bad   =                   (*fBadPixels)[i];
-
+      MBadPixelsPix &bad = (*fBadPixels)[i];
       if (bad.IsUnsuitable (MBadPixelsPix::kUnsuitableRun))
         {