Changeset 6150 for trunk

Timestamp:

01/31/05 16:04:49 (20 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mjobs/MJCalibrateSignal.cc (modified) (5 diffs)
• mjobs/MJCalibrateSignal.h (modified) (4 diffs)
• mjobs/MJCalibration.cc (modified) (4 diffs)
• mjobs/MJob.cc (modified) (1 diff)
• msignal/MExtractTimeAndChargeDigitalFilterPeakSearch.cc (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -20 +20 @@
 
                                                  -*-*- END OF LINE -*-*-
+
+ 2005/01/31 Markus Gaug 
+ 
+  * mjobs/MJob.[h,cc]
+  * mjobs/MJCalibrateSignal.[h,cc]
+  * mjobs/MJCalibration.[h,cc]
+    - move file type enum to base class
+
+  * mjobs/MJCalibrateSignal.[h,cc]
+    - allow also for direct setting of an MRunIter (not used in callisto).
+
 
  2005/01/31 Abelardo Moralejo

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.cc

@@ -44 +44 @@
 
 #include "MDirIter.h"
+#include "MRunIter.h"
 #include "MParList.h"
 #include "MTaskList.h"
@@ -116 +117 @@
 //
 MJCalibrateSignal::MJCalibrateSignal(const char *name, const char *title)
-  : fDataFlag(0), fIsInterlaced(kTRUE), fIsRelTimesUpdate(kFALSE), fIsHiLoCalibration(kFALSE)
+  : fRuns(0), fIsInterlaced(kTRUE), fIsRelTimesUpdate(kFALSE), fIsHiLoCalibration(kFALSE)
 {
     fName  = name  ? name  : "MJCalibrateSignal";
@@ -213 +214 @@
     if (!fSequence.IsValid())
     {
-        *fLog << err << "ERROR - Sequence invalid!" << endl;
-        return kFALSE;
+        if (!fRuns)
+        {
+          *fLog << err << "ERROR - Sequence invalid and no runs chosen!" << endl;
+          return kFALSE;
+        }
+
+        if (fRuns->GetNumRuns() != fRuns->GetNumEntries())
+        {
+            *fLog << err << "Number of files found doesn't match number of runs... abort."
+                << fRuns->GetNumRuns() << " vs. " << fRuns->GetNumEntries() << endl;
+            return kFALSE;
+        }
+        *fLog << "Calibrate data from ";
+        *fLog << "Runs " << fRuns->GetRunsAsString() << endl;
+        *fLog << endl;
     }
 
@@ -339 +353 @@
     plist.AddToList(&tlist);
 
-    /*
-    TString name = iter.Next();
-    Byte_t filetype = MRawFileRead::IsFileValid(name);
-    if (!filetype)
-        filetype = MReadMarsFile::IsFileValid(name)+1;
-    if (filetype<1||filetype>3)
-    {
-        gLog << err << "ERROR - FileType #" << (int)filetype << " of first file " << name << " unknown..." << endl;
-        return kFALSE;
-    } */
-
     MReadReports readreal;
     readreal.AddTree("Events", "MTime.", kTRUE);
@@ -362 +365 @@
     MRawFileRead rawread(NULL);
     if (IsRawData())
-        rawread.AddFiles(iter);
+        rawread.AddFiles(fSequence.IsValid() ? iter : *fRuns);
     else
-        readreal.AddFiles(iter);
+        readreal.AddFiles(fSequence.IsValid() ? iter : *fRuns);
 
     MPointingPosInterpolate pextr;

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.h

@@ -8 +8 @@
 class TEnv;
 class TList;
-
+class MRunIter;
 class MTask;
 class MParList;
@@ -21 +21 @@
 private:
 
-    enum DataType_t {
-      kIsRawData,
-      kIsRootData,
-      kIsMC
-    };
+    MRunIter *fRuns;                    // Data files
 
-    Byte_t fDataFlag;                   // Bit-field to store the data type
     Bool_t fIsInterlaced;               // Distinguish interlaced from other calibration
     Bool_t fIsRelTimesUpdate;           // Choose to update relative times from interlaced
@@ -40 +35 @@
                            MExtractor* &ext1, MExtractor* &ext2, TString &geom) const;
 
-    Bool_t IsRawData()  const { return TESTBIT(fDataFlag,kIsRawData);  }
-    Bool_t IsRootData() const { return TESTBIT(fDataFlag,kIsRootData); }
-    Bool_t IsMC()       const { return TESTBIT(fDataFlag,kIsMC);       }
-
-    void   SetRawData ( const Bool_t b=kTRUE )  { b ? SETBIT(fDataFlag,kIsRawData)  : CLRBIT(fDataFlag,kIsRawData);  }
-    void   SetRootData( const Bool_t b=kTRUE )  { b ? SETBIT(fDataFlag,kIsRootData) : CLRBIT(fDataFlag,kIsRootData); }
-    void   SetMC      ( const Bool_t b=kTRUE )  { b ? SETBIT(fDataFlag,kIsMC)       : CLRBIT(fDataFlag,kIsMC);       }
-
 public:
     MJCalibrateSignal(const char *name=NULL, const char *title=NULL);
@@ -57 +44 @@
     void SetHiLoCalibration( const Bool_t b=kTRUE )  { fIsHiLoCalibration = b; }
 
+    void SetInput          ( MRunIter *iter       )  { fRuns = iter; }
+
     ClassDef(MJCalibrateSignal, 0) // Tool to create a pedestal file (MPedestalCam)
 };

trunk/MagicSoft/Mars/mjobs/MJCalibration.cc

@@ -1428 +1428 @@
     SetGeometry(GetEnv("Geometry", fGeometry));
 
+    SetRootData();
+
+    if (HasEnv("MC"))
+    {
+      fDataFlag = 0;
+      SetMC();
+    }
+
+    if (HasEnv("RawData") || IsDataCheck())
+    {
+      fDataFlag = 0;
+      SetRawData();
+    }
+
     fReferenceFile = GetEnv("ReferenceFile",fReferenceFile.Data());
 
@@ -1628 +1642 @@
     if (fSequence.IsValid())
     {
-        const Int_t n0 = fSequence.SetupCalRuns(iter, fPathData, "C", IsDataCheck());
+        const Int_t n0 = fSequence.SetupCalRuns(iter, fPathData, "C", IsRawData());
         const Int_t n1 = fSequence.GetNumCalRuns();
         if (n0==0)
@@ -1688 +1702 @@
     MRawFileRead rawread(NULL);
 
-    if (IsDataCheck())
+    if (IsRawData())
     {
         rawread.AddFiles(fSequence.IsValid() ? iter : *fRuns);
@@ -1852 +1866 @@
     if (!evtloop.Eventloop())
     {
+      //        DisplayResult(plist);
+      //        WriteResult(plist);
         *fLog << err << GetDescriptor() << ": Failed." << endl;
         return kFALSE;

trunk/MagicSoft/Mars/mjobs/MJob.cc

@@ -52 +52 @@
 // Default constructor. 
 //
-// Sets fRuns to 0, fExtractor to NULL, fDataCheck to kFALSE
-//
-MJob::MJob(const char *name, const char *title) : fEnv(0), fOverwrite(kFALSE), fMaxEvents(0)
+// Sets fDataFlag to 0
+//
+MJob::MJob(const char *name, const char *title) : fEnv(0), fDataFlag(0), fOverwrite(kFALSE), fMaxEvents(0)
+  
 {
     fName  = name  ? name  : "MJob";

trunk/MagicSoft/Mars/msignal/MExtractTimeAndChargeDigitalFilterPeakSearch.cc

@@ -79 +79 @@
 const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgHiGainFirst             =  0;
 const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgHiGainLast              = 20;
-const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgLoGainFirst             =  3;
+const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgLoGainFirst             =  1;
 const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgLoGainLast              = 14;
-const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgOffsetLeftFromPeak      =  2;
+const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgOffsetLeftFromPeak      =  1;
 const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgOffsetRightFromPeak     =  3;
 const Byte_t MExtractTimeAndChargeDigitalFilterPeakSearch::fgPeakSearchWindowSize    =  2;