Changeset 6276 for trunk/MagicSoft/Mars

Timestamp:

02/07/05 09:25:42 (20 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mbase/MFilter.cc (modified) (1 diff)
• mdata/MDataFormula.h (modified) (1 diff)
• mhist/MHCamEvent.cc (modified) (4 diffs)
• mhist/MHCamEvent.h (modified) (1 diff)
• mhist/MHCamera.cc (modified) (2 diffs)
• mhist/MHCamera.h (modified) (1 diff)
• mjobs/MJCalibrateSignal.cc (modified) (1 diff)
• mjobs/MJCalibrateSignalFromOutside.cc (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -20 +20 @@
 
                                                  -*-*- END OF LINE -*-*-
+
+ 2005/02/07 Thomas Bretz
+
+   * mbase/MFilter.cc:
+     - use paranthesis around ClassName in GetRule
+
+   * mdata/MDataFormula.h:
+     - fixed a wrong comment in variable description
+
+   * mhist/MHCamEvent.[h,cc], mhist/MHCamera.[h,cc],
+     mjobs/MJCalibrateSignal.cc, 
+     mjobs/MJCalibrateSignalFromOutside.cc:
+     - to make sure there are no missunderstandings we have to
+       replace all occurances of 'Variance' by 'SqrtVariance'
+       (it was not my decision)
+
+
 
  2005/02/04 Markus Gaug

trunk/MagicSoft/Mars/mbase/MFilter.cc

@@ -95 +95 @@
 TString MFilter::GetRule() const
 {
-    return ClassName(); //"<GetRule n/a for " + fName + ">";
+    return Form("(%s)", ClassName()); //"<GetRule n/a for " + fName + ">";
 }
 

trunk/MagicSoft/Mars/mdata/MDataFormula.h

@@ -17 +17 @@
 private:
     TFormula      *fFormula;    // TFormula
-    TOrdCollection fMembers;    // Container for the filters
+    TOrdCollection fMembers;    // List of arguments
 
     TString Parse(const char *rule);

trunk/MagicSoft/Mars/mhist/MHCamEvent.cc

@@ -33 +33 @@
 // =====
 //
-// To plot the variance instead of the rms use:
-//    MHCamEvent::SetBit(MHCamera::kVariance);
+// To plot sqrt(variance) instead of the rms use:
+//    MHCamEvent::SetBit(MHCamera::kSqrtVariance);
 //  or
-//    MHCamEvent::EnableVariance()
+//    MHCamEvent::EnableSqrtVariance()
 //
 // To count how often a certain pixel is above or below a threshold do:
@@ -127 +127 @@
 // use this to display the variance instead of the rms.
 //
-void MHCamEvent::EnableVariance(Bool_t b)
-{
-    b ? SetBit(MHCamera::kVariance) : ResetBit(MHCamera::kVariance);
+void MHCamEvent::EnableSqrtVariance(Bool_t b)
+{
+    b ? SetBit(MHCamera::kSqrtVariance) : ResetBit(MHCamera::kSqrtVariance);
 }
 
@@ -173 +173 @@
         fSum->SetYTitle("a.u.");
     fSum->SetBit(MHCamera::kProfile);
-    if (TestBit(MHCamera::kVariance))
-        fSum->SetBit(MHCamera::kVariance);
+    if (TestBit(MHCamera::kSqrtVariance))
+        fSum->SetBit(MHCamera::kSqrtVariance);
 
     fSum->SetXTitle("Pixel Idx");
@@ -301 +301 @@
     MHCamera *cam = new MHCamera(*fSum->GetGeometry());
     cam->SetName(Form("%s;err", fName.Data()));
-    cam->SetTitle(fSum->TestBit(MHCamera::kVariance)?"Variance":"Root Mean Squared (rms)");
+    cam->SetTitle(fSum->TestBit(MHCamera::kSqrtVariance)?"Sqrt(Variance)":"Root Mean Squared (rms)");
     cam->SetYTitle(fSum->GetYaxis()->GetTitle());
     cam->SetCamContent(*fSum, 1);

trunk/MagicSoft/Mars/mhist/MHCamEvent.h

@@ -50 +50 @@
 
     void SetThreshold(Float_t f, Char_t direction=kIsLowerBound) { fThreshold = f; fUseThreshold=direction; }
-    void EnableVariance(Bool_t b=kTRUE);
+    void EnableSqrtVariance(Bool_t b=kTRUE);
 
     ClassDef(MHCamEvent, 1) // Histogram to sum camera events

trunk/MagicSoft/Mars/mhist/MHCamera.cc

@@ -329 +329 @@
 // ------------------------------------------------------------------------
 //
-// Return the variance of all entries which are used if all=kFALSE and
+// Return the sqrt variance of all entries which are used if all=kFALSE and
 // of all entries if all=kTRUE if sector<0. If sector>=0 only
 // entries with match the given sector are taken into account.
@@ -1155 +1155 @@
 {
     Double_t rc = 0;
-    if (TestBit(kVariance) && GetEntries()>0) // error on the mean
+    if (TestBit(kSqrtVariance) && GetEntries()>0) // error on the mean
     {
         const Double_t error = fSumw2.fArray[bin]/GetEntries();

trunk/MagicSoft/Mars/mhist/MHCamera.h

@@ -40 +40 @@
 public:
     enum {
-        kProfile  = BIT(18), // FIXME: When changing change max/min!
-        kFreezed  = BIT(19),
-        kNoLegend = BIT(20),
-        kVariance = BIT(21)
+        kProfile      = BIT(18), // FIXME: When changing change max/min!
+        kFreezed      = BIT(19),
+        kNoLegend     = BIT(20),
+        kSqrtVariance = BIT(21)
     };
 private:

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.cc

@@ -553 +553 @@
     MHCamEvent evt8(0, "Conv",        "Calibration Conv. Factors;;[phe/fadc cnts]");
 
-    evt0.EnableVariance();
-    evt1.EnableVariance();
-    evt2.EnableVariance();
+    evt0.EnableSqrtVariance();
+    evt1.EnableSqrtVariance();
+    evt2.EnableSqrtVariance();
     // evt3.EnableVariance();
-    evt4.EnableVariance();
-    evt5.EnableVariance();
-    evt7.EnableVariance();
-    evt8.EnableVariance();
+    evt4.EnableSqrtVariance();
+    evt5.EnableSqrtVariance();
+    evt7.EnableSqrtVariance();
+    evt8.EnableSqrtVariance();
 
     MFillH fill0(&evt0, "MPedestalFundamental",   "FillPedFLG");

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignalFromOutside.cc

@@ -346 +346 @@
     MHCamEvent evt8(0, "HiLoConv",    "Ratio Hi-Lo Gain Signal;;Ratio [1]");
 
-    evt0.EnableVariance();
-    evt1.EnableVariance();
-    evt2.EnableVariance();
-    evt3.EnableVariance();
-    evt4.EnableVariance();
-    evt5.EnableVariance();
-    evt7.EnableVariance();
-    evt8.EnableVariance();
+    evt0.EnableSqrtVariance();
+    evt1.EnableSqrtVariance();
+    evt2.EnableSqrtVariance();
+    evt3.EnableSqrtVariance();
+    evt4.EnableSqrtVariance();
+    evt5.EnableSqrtVariance();
+    evt7.EnableSqrtVariance();
+    evt8.EnableSqrtVariance();
 
     MFillH fill0(&evt0, "MPedestalFundamental",   "FillPedFLG");