Changeset 6699 for trunk/MagicSoft

Timestamp:

03/02/05 11:44:43 (20 years ago)

Author:

gaug

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mjobs/MJCalib.cc (modified) (1 diff)
• mjobs/MJCalib.h (modified) (3 diffs)
• mjobs/MJCalibrateSignal.cc (modified) (5 diffs)
• mjobs/MJCalibrateSignal.h (modified) (4 diffs)
• mjobs/MJCalibration.cc (modified) (1 diff)
• mjobs/MJCalibration.h (modified) (3 diffs)
• mjobs/MJPedestal.cc (modified) (5 diffs)
• mjobs/MJPedestal.h (modified) (3 diffs)

trunk/MagicSoft/Mars/Changelog

@@ -21 +21 @@
 
                                                  -*-*- END OF LINE -*-*-
+ 2005/03/02 Markus Gaug
+
+   * mjobs/MJCalib.[h,cc]
+   * mjobs/MJPedestal.[h,cc]
+   * mjobs/MJCalibration.[h,cc]
+   * mjobs/MJCalibrateSignal.[h,cc]
+     - put the storage types in the base class
+
  2005/02/25 Markus Gaug
 

trunk/MagicSoft/Mars/mjobs/MJCalib.cc

@@ -48 +48 @@
 // - fPixelCheck   to kFALSE
 //
-MJCalib::MJCalib() : fDataFlag(kIsUseRootData), fPixelCheck(kFALSE), fRuns(NULL)
+MJCalib::MJCalib() : fDataFlag(kIsUseRootData), fStorage(0), fPixelCheck(kFALSE), fRuns(NULL)
 {
   SetCheckedPixId();

trunk/MagicSoft/Mars/mjobs/MJCalib.h

@@ -24 +24 @@
     Byte_t fDataFlag;                    // Bit-field to store the data type
 
+    enum  Storage_t                        // Possible devices for calibration
+      {
+        kNoStorage,
+        kHistsStorage
+      };                                  // Possible flags for the storage of results
+    
+    Byte_t fStorage;                      // Bit-field for chosen storage type
+
 protected:
 
@@ -34 +42 @@
     Byte_t GetDataFlag() { return fDataFlag; }
 
+    Bool_t IsNoStorage    () const { return TESTBIT(fStorage,kNoStorage);    }
+    Bool_t IsHistsStorage () const { return TESTBIT(fStorage,kHistsStorage); }
+    
 public:
+
     MJCalib();
 
@@ -52 +64 @@
     void SetCheckedPixId( const Int_t i=fgCheckedPixId ) { fCheckedPixId = i; }
 
+    void SetNoStorage    ( const Bool_t b=kTRUE ) { b ? SETBIT(fStorage,kNoStorage)    : CLRBIT(fStorage,kNoStorage); }
+    void SetHistsStorage ( const Bool_t b=kTRUE ) { b ? SETBIT(fStorage,kHistsStorage) : CLRBIT(fStorage,kHistsStorage); }
+  
     ClassDef(MJCalib, 0) // Base class for calibration jobs
 };

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.cc

@@ -129 +129 @@
     fTitle = title ? title : "Tool to calibrate data";
 
+    //fCruns = NULL;
+}
+
+const char* MJCalibrateSignal::GetInputFile() const
+{
+    const TString name(GetInputFileName());
+    if (name.IsNull())
+        return "";
+
+    return Form("%s/%s", fPathIn.Data(), name.Data());
+}
+
+const char* MJCalibrateSignal::GetInputFileName() const
+{
+
+  if (fSequence.IsValid())
+    return Form("calib%08d.root", fSequence.GetSequence());
+  
+  if (!fRuns)
+    return "";
+  
+  //  return Form("%s-F1.root", (const char*)fCruns->GetRunsAsFileName());
 }
 
@@ -139 +161 @@
 Bool_t MJCalibrateSignal::ReadCalibration(TObjArray &l, MBadPixelsCam &cam, MExtractor* &ext1, MExtractor* &ext2, TString &geom) const
 {
-    const TString fname = Form("%s/calib%08d.root", fPathIn.Data(), fSequence.GetSequence());
+
+    const TString fname = GetInputFile();
 
     *fLog << inf << "Reading from file: " << fname << endl;
@@ -751 +774 @@
     if (fPixelCheck)
       {
-        MHCalibrationPulseTimeCam *pcam = (MHCalibrationPulseTimeCam*)plist.FindObject("MHCalibrationPulseCam");
+        MHCalibrationPulseTimeCam *pcam = (MHCalibrationPulseTimeCam*)plist.FindObject("MHCalibrationPulseTimeCam");
         MHCalibrationPix &pix1 = (*pcam)[fCheckedPixId];
         pix1.DrawClone("");
@@ -757 +780 @@
         if (fIsHiLoCalibration)
           {
-            MHCalibrationHiLoCam *hcam = (MHCalibrationHiLoCam*)plist.FindObject("MHCalibrationPulseCam");
+            MHCalibrationHiLoCam *hcam = (MHCalibrationHiLoCam*)plist.FindObject("MHCalibrationHiLoCam");
             MHCalibrationPix &pix2 = (*hcam)[fCheckedPixId];
             pix2.DrawClone("");
           }
-}
-
+      }
 
     if (!WriteResult(interlacedcont))
@@ -773 +795 @@
       addcont.Add(&hilcam);
 
+    if (IsHistsStorage())
+      {
+        addcont.Add(plist.FindObject("MHCalibrationHiLoCam"));
+        addcont.Add(plist.FindObject("MHCalibrationPulseTimeCam"));
+      }
+    
     if (!WriteResult(addcont))
       return kFALSE;
+
 
     // return if job went ok

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.h

@@ -15 +15 @@
 class MPedestalCam;
 class MBadPixelsCam;
+class MRunIter;
 
 class MJCalibrateSignal : public MJCalib
@@ -20 +21 @@
 private:
 
+  //    MRunIter *fCruns;                   // Calibration run iter
+  
     Bool_t fIsInterlaced;               // Distinguish interlaced from other calibration
     Bool_t fIsRelTimesUpdate;           // Choose to update relative times from interlaced
@@ -32 +35 @@
                            MExtractor* &ext1, MExtractor* &ext2, TString &geom) const;
 
+    const char*  GetInputFileName() const;
+    const char*  GetInputFile() const;
+    
 public:
 
@@ -42 +48 @@
     void SetHiLoCalibration( const Bool_t b=kTRUE )  { fIsHiLoCalibration = b; }
 
+    //    void SetInputCal    ( MRunIter *iter       )  { fCruns = iter; }
+  
     ClassDef(MJCalibrateSignal, 0) // Tool to create a pedestal file (MPedestalCam)
 };

trunk/MagicSoft/Mars/mjobs/MJCalibration.cc

@@ -200 +200 @@
   SetDebug(kFALSE);
   SetIntensity(kFALSE);
-
-  SetNoStorage(kFALSE);
-  SetHistsStorage(kFALSE);
 
   SetReferenceFile();

trunk/MagicSoft/Mars/mjobs/MJCalibration.h

@@ -131 +131 @@
   Byte_t fDevices;                                     // Bit-field for used devices for calibration
 
-  enum  Storage_t                                       // Possible devices for calibration
-    {
-      kNoStorage,
-      kHistsStorage
-    };                                                 // Possible flags for the storage of results
-  
-  Byte_t fStorage;                                     // Bit-field for chosen storage type
-
   enum { kRelTimes, kDebug, kIntensity };  // Possible flags
 
@@ -151 +143 @@
   Bool_t IsDebug        () const { return TESTBIT(fFlags,kDebug);          }
   Bool_t IsIntensity    () const { return TESTBIT(fFlags,kIntensity);      }
-
-  Bool_t IsNoStorage    () const { return TESTBIT(fStorage,kNoStorage);    }
-  Bool_t IsHistsStorage () const { return TESTBIT(fStorage,kHistsStorage); }
 
   void   DrawTab(MParList &plist, const char *cont, const char *name, Option_t *opt);
@@ -218 +207 @@
 
   // Storage
-  void SetNoStorage    ( const Bool_t b=kTRUE ) { b ? SETBIT(fStorage,kNoStorage)    : CLRBIT(fStorage,kNoStorage); }
-  void SetHistsStorage ( const Bool_t b=kTRUE ) { b ? SETBIT(fStorage,kHistsStorage) : CLRBIT(fStorage,kHistsStorage); }
-  
   void SetReferenceFile( const TString ref=fgReferenceFile ) { fReferenceFile = ref; }
 

trunk/MagicSoft/Mars/mjobs/MJPedestal.cc

@@ -101 +101 @@
 MJPedestal::MJPedestal(const char *name, const char *title) 
     : fExtractor(NULL), fDisplayType(kDisplayDataCheck),
-      fExtractType(kUsePedRun), fExtractionType(kFundamental), fIsUseHists(kFALSE)
+      fExtractType(kUsePedRun), fExtractionType(kFundamental)
 {
     fName  = name  ? name  : "MJPedestal";
     fTitle = title ? title : "Tool to create a pedestal file (MPedestalCam)";
 
-    SetNormalStorage();
     SetUsePedRun();
     SetPathIn("");
@@ -954 +953 @@
     // 
     if (!fBadPixelsFile.IsNull())
-    {
+      {
         *fLog << inf << "Excluding: " << fBadPixelsFile << endl;
         ifstream fin(fBadPixelsFile.Data());
         fBadPixels.AsciiRead((istream&)fin);
-    }
+      }
 
     MGeomApply geomapl;
@@ -1037 +1036 @@
     {
 
+      if (fExtractionType!=kFundamental)
+        {
+          pedcalc.SetRandomCalculation(fExtractionType==kWithExtractorRndm);
+          pedlogain.SetRandomCalculation(fExtractionType==kWithExtractorRndm);
+          
+          pedcalc.SetExtractor((MExtractTimeAndCharge*)fExtractor);
+          pedlogain.SetExtractor((MExtractTimeAndCharge*)fExtractor);
+        }
+      
       if (fExtractor->InheritsFrom("MExtractTimeAndCharge"))
         {
 
-          const Float_t f = 0.5+fExtractor->GetHiGainFirst();
+          const Float_t f = 0.1+fExtractor->GetHiGainFirst();
           const Int_t win = ((MExtractTimeAndCharge*)fExtractor)->GetWindowSizeHiGain();
           pedcalc.SetExtractWindow((Int_t)f, win);
@@ -1048 +1056 @@
       else
         {
-          const Float_t f = 0.5+fExtractor->GetHiGainFirst();
-          const Float_t n = 0.5+fExtractor->GetNumHiGainSamples();
+          const Float_t f = 0.1+fExtractor->GetHiGainFirst();
+          const Float_t n = 0.1+fExtractor->GetNumHiGainSamples();
           pedcalc.SetExtractWindow((Int_t)f, (Int_t)n);
           pedlogain.SetExtractWindow((Int_t)(15+f), (Int_t)n);
@@ -1063 +1071 @@
       
       
-      if (fExtractionType!=kFundamental)
-        {
-          pedcalc.SetRandomCalculation(fExtractionType==kWithExtractorRndm);
-          pedlogain.SetRandomCalculation(fExtractionType==kWithExtractorRndm);
-          
-          pedcalc.SetExtractor((MExtractTimeAndCharge*)fExtractor);
-          pedlogain.SetExtractor((MExtractTimeAndCharge*)fExtractor);
-        }
     }
     else

trunk/MagicSoft/Mars/mjobs/MJPedestal.h

@@ -60 +60 @@
     Display_t fDisplayType;                  // Chosen Display type
 
-    enum Storage_t { kNoStorage };           // Possible flags for the storage of results
-    Byte_t fStorage;                         // Bit-field for chosen storage type
-
     enum Extract_t { kUseData, kUsePedRun }; // Possible flags for the extraction of the pedestal
     Extract_t fExtractType;                  // Chosen extractor type
@@ -80 +77 @@
     void   DisplayOutliers(TH1D *hist) const;
     void   FixDataCheckHist(TH1D *hist) const;
-
-    Bool_t IsNoStorage() const { return TESTBIT(fStorage, kNoStorage); }
 
     Bool_t CheckEnvLocal();
@@ -124 +119 @@
     MExtractor *GetExtractor() const { return fExtractor; }
 
-    // Storage
-    void SetNoStorage(const Bool_t b=kTRUE)     { b ? SETBIT(fStorage, kNoStorage) : CLRBIT(fStorage,kNoStorage); }
-    void SetNormalStorage()                     { CLRBIT(fStorage, kNoStorage); }
-
     ClassDef(MJPedestal, 0) // Tool to create a pedestal file (MPedestalCam)
 };