Changeset 6820 for trunk

Timestamp:

03/15/05 11:10:55 (20 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mcalib/MCalibrateData.cc (modified) (1 diff)
• mjobs/MJCalibrateSignal.cc (modified) (6 diffs)
• mjobs/MJCalibration.cc (modified) (5 diffs)
• mjobs/MJCut.cc (modified) (1 diff)
• mjobs/MJPedestal.cc (modified) (10 diffs)
• msignal/MExtractTimeAndCharge.cc (modified) (2 diffs)
• msignal/MExtractor.cc (modified) (1 diff)
• msignal/MExtractor.h (modified) (1 diff)
• sinope.cc (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -21 +21 @@
 
                                                  -*-*- END OF LINE -*-*-
- 2005/03/14 Toni Coarasa
-   Please use the new CVS
-
  2005/03/14 Thomas Bretz
 
    * mbase/MGMenu.h:
      - added a fix for root 4.02.00
+
+
+ 2005/03/14 Markus Gaug
+
+   * mcalib/MCalibrateData.cc
+     - catch the case that now high-gain low-gian intercalibration const.
+       is available.
+
+   * mjobs/MJPedestal.cc
+     - modify option for pedy*.root: from UPDATE to RECREATE
+
+
+
+ 2005/03/11 Markus Gaug
+
+   * callisto.rc
+     - changed default weights for DF to cosmics_weights4.dat. (This has 
+       turned out to be the most stable set of weights). 
+
+   * mjobs/MJCalibration.cc
+     - some cosmetic changes in the output
+     - in case of WriteHists(), do not overwrite existing signal*.root 
+       file, but append histograms (bugfix!)
+
+
+
+ 2005/03/10 Toni Coarasa (With Nadia's and Alessandro's inside)
+
+   * mjobs/MJCut.cc
+     - inclusion of (TString) to avoid compiler error under 2.95.3
+
+   * sinope.cc
+     - inclusion of <errno.h> to avoid compiler error under 2.95.3
+
+
+
+ 2005/03/10 Markus Gaug
+
+   * msignal/MExtractTimeAndCharge.cc
+     - set fgLoGainStartShift to -4.0
+     - put a check to avoid a dynamic low-gain range < 0 (should not 
+       occur with current extractors, but one never knows...)
+
+   * msignal/MExtractor.[h,cc]
+     - introduced Clear()-function, used in SetRange()
+
+   * mjobs/MJCalibrateSignal.cc
+     - changed order of initialization of the 2 MWriteRootFiles whereupon
+       the crash goes away. Have to revise the /dev/null work-around 
+       in MWriteRootFile!
 
 

trunk/MagicSoft/Mars/mcalib/MCalibrateData.cc

@@ -669 +669 @@
             if (sig.IsLoGainUsed())
             {
-                signal    = sig.GetExtractedSignalLoGain()*fHiLoConv   [pixidx];
-                signalErr = sig.GetExtractedSignalLoGain()*fHiLoConvErr[pixidx];
+              if (fHiLoConv[pixidx] < 0.5)
+                {
+                  signal    = sig.GetExtractedSignalHiGain()*1.5;
+                  signalErr = sig.GetExtractedSignalHiGain()*2.;
+                }
+              else
+                {
+                  signal    = sig.GetExtractedSignalLoGain()*fHiLoConv   [pixidx];
+                  signalErr = sig.GetExtractedSignalLoGain()*fHiLoConvErr[pixidx];
+                }
             }
             else

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.cc

@@ -159 +159 @@
 Bool_t MJCalibrateSignal::WriteResult(TObjArray &cont)
 {
-    const TString name(Form("signal%08d.root", fSequence.GetSequence()));
-    return WriteContainer(cont, name);
+  if (IsNoStorage())
+    return kTRUE;
+
+  const TString name(Form("signal%08d.root", fSequence.GetSequence()));
+  return WriteContainer(cont, name);
 }
 
@@ -367 +370 @@
 
     *fLog << all;
-    if (extractor1)
-    {
-        *fLog << underline << "Signal Extractor found in calibration file" << endl;
-        extractor1->Print();
-        *fLog << endl;
-        extractor3 = (MExtractor*)extractor1->Clone();
-        
-    }
-    else
-        *fLog << inf << "No Signal Extractor: ExtractSignal in file." << endl;
-
-    if (extractor2)
-    {
-        *fLog << underline << "Time Extractor found in calibration file" << endl;
-        extractor2->Print();
-        *fLog << endl;
-    }
-    else
-        *fLog << inf << "No Time Extractor: ExtractTime in file." << endl;
-
     if (!geom.IsNull())
         *fLog << inf << "Camera geometry found in file: " << geom << endl;
@@ -395 +378 @@
       if (!ReadExtractorCosmics(extractor1))
         *fLog << warn << "No extraction window update for signal extractor found" << endl;
+
+    if (extractor1)
+    {
+      *fLog << underline << "Signal Extractor found in calibration file" << endl;
+      extractor1->Print();
+      *fLog << endl;
+      extractor3 = (MExtractor*)extractor1->Clone();
+    }
+    else
+      *fLog << inf << "No Signal Extractor: ExtractSignal in file." << endl;
+
+    if (extractor2)
+    {
+        *fLog << underline << "Time Extractor found in calibration file" << endl;
+        extractor2->Print();
+        *fLog << endl;
+    }
+    else
+        *fLog << inf << "No Time Extractor: ExtractTime in file." << endl;
 
     // This is necessary for the case in which it is not in the files
@@ -436 +438 @@
     const TString fname(Form("%s{s/_D_/_Y_}{s/.raw$/.root}", fPathOut.Data()));
 
-    // Write the special MC tree
-    MWriteRootFile writemc(2, fname, fOverwrite?"RECREATE":"NEW");
-    writemc.SetName("WriteMC");
-    writemc.AddContainer("MMcEvtBasic", "OriginalMC");
-
+    
     // Skips empty MC events (Not necessary, but faster!)
     MContinue contmc("MRawEvtData.GetNumPixels<0.5", "ContEmptyMC");
@@ -689 +687 @@
     write.AddContainer("MTimeCC",                   "CC",         kFALSE);
 
+    // Write the special MC tree
+    MWriteRootFile writemc(2, fname, fOverwrite?"RECREATE":"NEW");
+    writemc.SetName("WriteMC");
+    writemc.AddContainer("MMcEvtBasic", "OriginalMC");
+
     // Now setup tasklist for events
     MTaskList tlist2;
@@ -836 +839 @@
       interlacedcont.Add(&hilcam);
 
+    if (IsHistsStorage())
+      {
+        interlacedcont.Add(plist.FindObject("MHCalibrationHiLoCam"));
+        interlacedcont.Add(plist.FindObject("MHCalibrationPulseTimeCam"));
+      }
+    
     if (!WriteResult(interlacedcont))
       return kFALSE;
 
-    //    if (IsHistsStorage())
-    //      {
-    //        addcont.Add(plist.FindObject("MHCalibrationHiLoCam"));
-    //        addcont.Add(plist.FindObject("MHCalibrationPulseTimeCam"));
-    //      }
-    
     // return if job went ok
     *fLog << all << GetDescriptor() << ": Done." << endl;

trunk/MagicSoft/Mars/mjobs/MJCalibration.cc

@@ -177 +177 @@
 const Int_t MJCalibration::gkThirdBlindPixelInstallation   = 43308;
 const TString MJCalibration::fgReferenceFile = "mjobs/calibrationref.rc";
-const TString MJCalibration::fgHiLoCalibFile = "mjobs/hilocalib_df6.root";
+const TString MJCalibration::fgHiLoCalibFile = "mjobs/hilocalib_df4.root";
 // --------------------------------------------------------------------------
 //
@@ -1482 +1482 @@
   MCalibrationHiLoCam hilocam;
   
+  *fLog << all << "Initializing High gain vs. Low gain intercalibration from " << fHiLoCalibFile << endl;
+  *fLog << all << endl;
+
   if (hilocam.Read()<=0)
   {
@@ -1712 +1715 @@
     }
 
-    //if (!CheckEnv())
-    //    return kFALSE;
-
-    if (!CheckEnv())
-      return kFALSE;
-
     // --------------------------------------------------------------------------------
 
@@ -1732 +1729 @@
     // --------------------------------------------------------------------------------
     
+    if (!CheckEnv())
+      return kFALSE;
+
+    // --------------------------------------------------------------------------------
+
     // Setup Tasklist
     MParList plist;
@@ -1975 +1977 @@
     tlist.PrintStatistics();
 
-  if (fIsPixelCheck)
-    {
-      MHCalibrationChargeCam *hcam = (MHCalibrationChargeCam*)plist.FindObject("MHCalibrationChargeCam");
-      MHCalibrationChargePix &pix1 = (MHCalibrationChargePix&)(*hcam)[fCheckedPixId];
-      pix1.DrawClone("");
-      
-      MHCalibrationChargePix &pix2 = (MHCalibrationChargePix&)(*hcam)(fCheckedPixId);
-      pix2.DrawClone("");
-      
-      if (IsRelTimes())
-        {
-          MHCalibrationRelTimeCam *hccam = (MHCalibrationRelTimeCam*)plist.FindObject("MHCalibrationRelTimeCam");
-          MHCalibrationPix &pix11 = (*hccam)[fCheckedPixId];
-          pix11.DrawClone("");
-          MHCalibrationPix &pix12 = (*hccam)(fCheckedPixId);
-          pix12.DrawClone("");
-        }
-    }
-
+    // --------------------------------------------------------------------------------
+
+    if (fIsPixelCheck)
+      {
+        MHCalibrationChargeCam *hcam = (MHCalibrationChargeCam*)plist.FindObject("MHCalibrationChargeCam");
+        MHCalibrationChargePix &pix1 = (MHCalibrationChargePix&)(*hcam)[fCheckedPixId];
+        pix1.DrawClone("");
+        
+        MHCalibrationChargePix &pix2 = (MHCalibrationChargePix&)(*hcam)(fCheckedPixId);
+        pix2.DrawClone("");
+        
+        if (IsRelTimes())
+          {
+            MHCalibrationRelTimeCam *hccam = (MHCalibrationRelTimeCam*)plist.FindObject("MHCalibrationRelTimeCam");
+            MHCalibrationPix &pix11 = (*hccam)[fCheckedPixId];
+            pix11.DrawClone("");
+            MHCalibrationPix &pix12 = (*hccam)(fCheckedPixId);
+            pix12.DrawClone("");
+          }
+      }
+    
     if (!fCalibrationPINDiode.IsValid())
-        SetUsePINDiode(kFALSE);
-
+      SetUsePINDiode(kFALSE);
+    
     DisplayResult(plist);
-
+    
     if (!WriteResult(plist))
-        return kFALSE;
-
+      return kFALSE;
+    
     *fLog << all << GetDescriptor() << ": Done." << endl;
-
+    
     return kTRUE;
 }

trunk/MagicSoft/Mars/mjobs/MJCut.cc

@@ -347 +347 @@
     TString fname0(path);
     TString fname1(path);
-    fname0 += fNameSummary.IsNull() ? Form("ganymed%08d-summary.root", set.GetNumAnalysis()) : fNameSummary;
-    fname1 += fNameResult.IsNull()  ? Form("ganymed%08d-result.root",  set.GetNumAnalysis()) : fNameResult;
+    fname0 += fNameSummary.IsNull() ?  (TString) Form("ganymed%08d-summary.root", set.GetNumAnalysis()) : fNameSummary;
+    fname1 += fNameResult.IsNull()  ?  (TString) Form("ganymed%08d-result.root",  set.GetNumAnalysis()) : fNameResult;
 
     MWriteRootFile write0(fPathOut.IsNull()?0:fname0.Data(), fOverwrite?"RECREATE":"NEW");

trunk/MagicSoft/Mars/mjobs/MJPedestal.cc

@@ -179 +179 @@
     const TString fname = GetOutputFile();
 
+    const Bool_t fileexist = !gSystem->AccessPathName(fname, kFileExists);
+    if (!fileexist)
+      {
+        *fLog << inf << "Input file " << fname << " not found, will create pedestals" << endl;
+        return kFALSE;
+      }
+
     *fLog << inf << "Reading pedestals from file: " << fname << endl;
 
@@ -242 +249 @@
   *fLog << inf << "Updating extractor in file: " << fname << endl;
 
-  TFile file(fname, "UPDATE");
+  TFile file(fname, fOverwrite?"RECREATE":"NEW");
   if (!file.IsOpen())
     {
       *fLog << err << dbginf << "ERROR - Could not open file " << fname << endl;
+      *fLog << err << dbginf << "Maybe, file " << fname << " already exists, call callisto with option -f then." << endl;
       return kFALSE;
     }
@@ -252 +260 @@
   cont.Add(fExtractor);
 
-  return WriteContainer(cont,name, fOverwrite?"RECREATE":"NEW");
+  return WriteContainer(cont);
 }
 
@@ -914 +922 @@
         if (fRuns && fRuns->GetNumRuns() != fRuns->GetNumEntries())
         {
-            *fLog << err << "Number of files found doesn't match number of runs... abort." << endl;
+            *fLog << err << "Number of files found doesn't match number of runs... abort."
+                << fRuns->GetNumRuns() << " vs. " << fRuns->GetNumEntries() << endl;
             return kFALSE;
         }
@@ -1007 +1016 @@
     
     MHPedestalCam hpedcam;
-    hpedcam.SetRenorm(kTRUE);
+    if (fExtractionType != kFundamental)
+      hpedcam.SetRenorm(kTRUE);
     //    fPedestalHist.SetRenorm(kTRUE);
     //    fPedestalHist.SetPedestalsOut(&fPedestalCamOut);
+    hpedcam.SetPedestalsOut(&fPedestalCamOut);
 
     MPedestalCam pedinter;
@@ -1038 +1049 @@
     sel.SetNumSelectEvts(0);
      
-    if (fExtractionType!=kFundamental && fExtractor)
+    if (fExtractor)
       {
         fExtractor->SetFilter(&sel);
@@ -1077 +1088 @@
     
     if (fIsUseHists)
-    {
+      {
+        if (fExtractor->InheritsFrom("MExtractTimeAndCharge"))
+          hpedcam.SetFitStart(-10.*((MExtractTimeAndCharge*)fExtractor)->GetWindowSizeHiGain());
+        
         pedcalc.SetIntermediateStorage();
         pedlogain.SetIntermediateStorage();
@@ -1248 +1262 @@
             const Float_t meanpulsetime = cam->GetAverageArea(0).GetHiGainMean();
             const Float_t rmspulsetime = cam->GetAverageArea(0).GetHiGainRms();
-            *fLog << inf << "Mean pulse time (cosmics): " << meanpulsetime << "+-" << rmspulsetime << endl;
+            *fLog << all << "Mean pulse time (cosmics): " << meanpulsetime << "+-" << rmspulsetime << endl;
             const Int_t newfirst = (Int_t)(meanpulsetime-fExtractWinLeft);
             Int_t wshigain = fExtractor->InheritsFrom("MExtractTimeAndCharge") 
@@ -1255 +1269 @@
             if (wshigain > 6)
               wshigain = 6;
-            const Int_t wslogain = fExtractor->InheritsFrom("MExtractTimeAndCharge") 
+            Int_t wslogain = fExtractor->InheritsFrom("MExtractTimeAndCharge") 
               ? ((MExtractTimeAndCharge*)fExtractor)->GetWindowSizeLoGain()
               : 6;
+            if (wslogain > 6)
+              wslogain = 6;
             const Int_t newlast  = (Int_t)(meanpulsetime+fExtractWinRight);
-            *fLog << inf << "Try to set new range limits: ("<<newfirst<<","<<newlast<<"+"<<wshigain
-                  <<","<<newfirst<<","<<newlast<<"+"<<wslogain<<")"<<endl;
+            *fLog << all << underline 
+                  << "Try to set new range limits: ("<<newfirst<<","<<newlast<<"+"<<wshigain
+                  <<","<<newfirst-1<<","<<newlast<<"+"<<wslogain<<")"<<endl;
             if (newfirst < 0)
               {
@@ -1274 +1291 @@
             if (newlast+wslogain > data->GetNumLoGainSamples())
               {
-                *fLog << err << "Pulse is too much to the right, cannot go beyond logain limits! " 
-                      << " Try to use a different extractor ... " << endl;
+                *fLog << err << "Pulse is too much to the right, cannot go beyond logaie limits! " << endl;
+                *fLog << endl;
+                *fLog << "Try to use a different extractor (e.g. with a window size of only 4 sl.) or:" << endl;
+                *fLog << "Set the limit to a lower value (callisto.rc: line 310): " << endl;
+                *fLog << "    MJPedestalY2:ExtractWinRight: 5.0           " << endl;
+                *fLog << "(ATTENTION, you will lose late cosmics pulses!)" << endl;
+                *fLog << endl;
                 return kFALSE;
               }
-            fExtractor->SetRange(newfirst,newlast+wshigain,newfirst,data->GetNumLoGainSamples()-1);
+            fExtractor->SetRange(newfirst,newlast+wshigain,
+                                 newfirst>0?newfirst-1:newfirst,data->GetNumLoGainSamples()-1);
             if (!WriteExtractor())
               {

trunk/MagicSoft/Mars/msignal/MExtractTimeAndCharge.cc

@@ -85 +85 @@
 using namespace std;
 
-const Float_t MExtractTimeAndCharge::fgLoGainStartShift = -2.8; 
+const Float_t MExtractTimeAndCharge::fgLoGainStartShift = -4.0; 
 const Byte_t  MExtractTimeAndCharge::fgLoGainSwitch = 120; 
 // --------------------------------------------------------------------------
@@ -217 +217 @@
           fLoGainFirstSave = fLoGainFirst;
           const Byte_t logainstart = sathi 
-            ? (sathi > (Int_t)fLoGainStartShift ? sathi + (Int_t)fLoGainStartShift : fLoGainFirst)
-            : (Byte_t)(timehi + fLoGainStartShift);
+            ? (sathi > (Int_t)(-fLoGainStartShift) ? sathi + (Int_t)fLoGainStartShift : fLoGainFirst)
+            : (timehi+fLoGainStartShift > 0. ? (Byte_t)(timehi + fLoGainStartShift) : fLoGainFirst);
           fLoGainFirst = logainstart > fLoGainFirstSave ? logainstart : fLoGainFirstSave;
 

trunk/MagicSoft/Mars/msignal/MExtractor.cc

@@ -133 +133 @@
 void MExtractor::SetRange(Byte_t hifirst, Byte_t hilast, Byte_t lofirst, Byte_t lolast)
 {
-    fHiGainFirst = hifirst;
-    fHiGainLast  = hilast;
-
-    fLoGainFirst = lofirst;
-    fLoGainLast  = lolast;
+ 
+  Clear();
+
+  fHiGainFirst = hifirst;
+  fHiGainLast  = hilast;
+  
+  fLoGainFirst = lofirst;
+  fLoGainLast  = lolast;
 }
 

trunk/MagicSoft/Mars/msignal/MExtractor.h

@@ -72 +72 @@
   MExtractor(const char *name=NULL, const char *title=NULL);
   
+  void Clear(Option_t *o="") 
+    {
+      fHiGainFirst = fHiGainLast = fLoGainFirst = fLoGainLast = fHiLoLast = 0;
+    }
+
   Byte_t  GetHiGainFirst()      const { return fHiGainFirst;      }
   Byte_t  GetHiGainLast ()      const { return fHiGainLast ;      }

trunk/MagicSoft/Mars/sinope.cc

@@ +1 @@
+#include <errno.h>
 #include <fstream>