Changeset 6821 for trunk/MagicSoft

Timestamp:

03/15/05 11:32:29 (20 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mjobs/MJCalibrateSignal.cc (modified) (9 diffs)
• mjobs/MJCalibrateSignal.h (modified) (3 diffs)
• mjobs/MJPedestal.cc (modified) (3 diffs)
• mpedestal/MExtractPedestal.cc (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -21 +21 @@
 
                                                  -*-*- END OF LINE -*-*-
+ 2005/03/15 Thomas Bretz
+
+   * mjobs/MJCalibrateSignal.[h,cc]:
+     - added the fExtractor data member
+     - added a destructor deleting it
+     - only read extractor from file if not set by user
+     - user fExtractor as extractor1
+     - do not delete extractor1 if set by user
+     - added member function to set extractor
+
+   * mjobs/MJPedestal.cc:
+     - removed MFEventSelector workaround again
+     - do not write pedy file anymore
+
+   * callisto.cc:
+     - MJCalibrateSignal now takes the signal extractor directly
+       instead of taking the long way round a new file
+
+   * mpedestal/MExtractPedestal.cc:
+     - ReInit extractor correctly. Now the workaround should be
+       really obsolete
+
+
+
  2005/03/14 Thomas Bretz
 

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.cc

@@ -126 +126 @@
 //
 MJCalibrateSignal::MJCalibrateSignal(const char *name, const char *title)
-    : fIsInterlaced(kTRUE), fIsRelTimesUpdate(kFALSE), 
+    : fExtractor(0), fIsInterlaced(kTRUE), fIsRelTimesUpdate(kFALSE),
       fIsModifiedExtractWin(kTRUE)
 {
@@ -134 +134 @@
     SetPulsePosCheck();
     //fCruns = NULL;
+}
+
+MJCalibrateSignal::~MJCalibrateSignal()
+{
+    if (fExtractor)
+        delete fExtractor;
+}
+
+void MJCalibrateSignal::SetExtractor(const MExtractor &ext)
+{
+    if (fExtractor)
+        delete fExtractor;
+
+    fExtractor = (MExtractor*)ext.Clone();
 }
 
@@ -180 +194 @@
     }
 
-    TObject *o = file.Get("ExtractSignal");
-    if (o && !o->InheritsFrom(MExtractor::Class()))
-    {
-        *fLog << err << dbginf << "ERROR - ExtractSignal read from " << fname << " doesn't inherit from MExtractor!" << endl;
-        return kFALSE;
-    }
-    ext1 = o ? (MExtractor*)o->Clone() : NULL;
-
-    o = file.Get("ExtractTime");
+    if (!ext1)
+    {
+        TObject *o = file.Get("ExtractSignal");
+        if (o && !o->InheritsFrom(MExtractor::Class()))
+        {
+            *fLog << err << dbginf << "ERROR - ExtractSignal read from " << fname << " doesn't inherit from MExtractor!" << endl;
+            return kFALSE;
+        }
+        ext1 = o ? (MExtractor*)o->Clone() : NULL;
+    }
+
+    TObject *o = file.Get("ExtractTime");
     if (o && !o->InheritsFrom(MExtractor::Class()))
     {
@@ -213 +230 @@
     return ReadContainer(cont);
 }
-
+/*
 Bool_t MJCalibrateSignal::ReadExtractorCosmics(MExtractor* &ext1) const
 {
@@ -245 +262 @@
   return kTRUE;
 }
-
+*/
 // --------------------------------------------------------------------------
 //
@@ -354 +371 @@
     }
 
-    MExtractor *extractor1=0;
+    MExtractor *extractor1=fExtractor;
     MExtractor *extractor2=0;
     MExtractor *extractor3=0;
@@ -374 +391 @@
     else
         *fLog << inf << "No Camera geometry found using default <MGeomCamMagic>" << endl;
-
-    if (fIsModifiedExtractWin)
-      if (!ReadExtractorCosmics(extractor1))
-        *fLog << warn << "No extraction window update for signal extractor found" << endl;
 
     if (extractor1)
@@ -537 +550 @@
     // at the Wuerzburg software meeting 26.01.05
     //
-#warning Default calibration now in equiv. photo-electrons!
     MCalibrateData calib;
     calib.SetSignalType(MCalibrateData::kPhe);
@@ -800 +812 @@
 
     // make sure owned object are deleted
-    if (extractor1)
+    if (extractor1 && extractor1!=fExtractor)
         delete extractor1;
     if (extractor2)

trunk/MagicSoft/Mars/mjobs/MJCalibrateSignal.h

@@ -20 +20 @@
 {
 private:
+    MExtractor *fExtractor;
 
   //    MRunIter *fCruns;                   // Calibration run iter
-  
     Bool_t fIsInterlaced;               // Distinguish interlaced from other calibration
     Bool_t fIsRelTimesUpdate;           // Choose to update relative times from interlaced
@@ -42 +42 @@
 
     MJCalibrateSignal(const char *name=NULL, const char *title=NULL);
+    ~MJCalibrateSignal();
 
     Bool_t ProcessFile(MPedestalCam &camab, MPedestalCam &cam1, MPedestalCam &cam2);
@@ -50 +51 @@
 
     //    void SetInputCal    ( MRunIter *iter       )  { fCruns = iter; }
-  
+
+    void SetExtractor(const MExtractor &ext);
+
     ClassDef(MJCalibrateSignal, 0) // Tool to create a pedestal file (MPedestalCam)
 };

trunk/MagicSoft/Mars/mjobs/MJPedestal.cc

@@ -1046 +1046 @@
     }
 
-    MFEventSelector sel;
-    sel.SetNumSelectEvts(0);
-     
-    if (fExtractor)
-      {
-        fExtractor->SetFilter(&sel);
-        tlist.AddToList(&sel);
-        tlist.AddToList(fExtractor);
-      }
-
     MFTriggerPattern fcalib("CalibFilter");
     fcalib.RequireCalibration();
@@ -1224 +1214 @@
 
     tlist.PrintStatistics();
-
-    fExtractor->SetFilter(0);
 
     if (fIsPixelCheck)
@@ -1302 +1290 @@
             fExtractor->SetRange(newfirst,newlast+wshigain,
                                  newfirst>0?newfirst-1:newfirst,data->GetNumLoGainSamples()-1);
-            if (!WriteExtractor())
+            /*if (!WriteExtractor())
               {
                 *fLog << err << "Could not write the changes to disk, abort... " << endl;
                 return kFALSE;
-              }
+              }*/
           }
         else

trunk/MagicSoft/Mars/mpedestal/MExtractPedestal.cc

@@ -442 +442 @@
   if (fExtractor)
   {
+    if (!fExtractor->ReInit(pList))
+        return kFALSE;
+
       if (!fExtractor->InitArrays())
           return kFALSE;