Changeset 6980 for trunk/MagicSoft/Mars/msignal

Timestamp:

04/27/05 17:23:36 (20 years ago)

Author:

tbretz

Message:

*** empty log message ***

File:

• trunk/MagicSoft/Mars/msignal/MExtractTimeAndChargeSpline.cc (modified) (3 diffs)

trunk/MagicSoft/Mars/msignal/MExtractTimeAndChargeSpline.cc

@@ -21 +21 @@
 !
 \* ======================================================================== */
+
 //////////////////////////////////////////////////////////////////////////////
 //
@@ -160 +161 @@
 const Float_t MExtractTimeAndChargeSpline::fgOffsetLoGain     = 1.7;  // 5 ns
 const Float_t MExtractTimeAndChargeSpline::fgLoGainStartShift = -1.8;  
+
 // --------------------------------------------------------------------------
 //
@@ -1060 +1062 @@
 void MExtractTimeAndChargeSpline::CalcIntegralHiGain(Float_t &sum, Float_t start, Float_t last)
 {
-
-  const Float_t step = 0.2;
-
-  if (start < 0)
-    {
-      last -= start;
-      start = 0.;
-    }
-  
-  Int_t klo = int(start);
-  Int_t khi = klo+1;
-
-  Float_t lo = TMath::Floor(start);
-  Float_t up = lo + 1.;
-
-  const Int_t m = int((start-klo)/step);
-  start = step*m + klo; // Correct start for the digitization due to resolution
-
-  Float_t x = start;
-  Float_t a = up-start;
-  Float_t b = start-lo;
-
-  while (1)
-    {
-      
-      while (x<up)
-        {
-          x += step;
-
-          if (x > last)
-            {
-              sum *= step;
-              return;
-            }
-          
-          a -= step;
-          b += step;
-          
-          sum += a*fHiGainSignal[klo]
-          + b*fHiGainSignal[khi]
-            + (a*a*a-a)*fHiGainSecondDeriv[klo] 
+    const Float_t step = 0.2;
+
+    if (start < 0)
+    {
+        last -= start;
+        start = 0.;
+    }
+
+    const Int_t n = TMath::Nint((last-start)/step);
+
+    sum = 0.;
+    for (Int_t i=1; i<=n+1; i++)
+    {
+        const Float_t x = start+i*step;
+        const Int_t klo = (Int_t)TMath::Floor(x);
+        const Int_t khi = klo + 1;
+        // Note: if x is close to one integer number (= a FADC sample)
+        // we get the same result by using that sample as klo, and the
+        // next one as khi, or using the sample as khi and the previous
+        // one as klo (the spline is of course continuous). So we do not
+        // expect problems from rounding issues in the argument of
+        // Floor() above (we have noticed differences in roundings
+        // depending on the compilation options).
+
+        const Float_t a = khi - x; // Distance from x to next FADC sample
+        const Float_t b = x - klo; // Distance from x to previous FADC sample
+
+        sum += a*fHiGainSignal[klo]
+            +  b*fHiGainSignal[khi]
+            + (a*a*a-a)*fHiGainSecondDeriv[klo]
             + (b*b*b-b)*fHiGainSecondDeriv[khi];
-        }
-
-      up += 1.;
-      lo += 1.;
-      klo++;
-      khi++;
-      start += 1.;
-      a = 1.;
-      b = 0.;
-    }
-  
+
+        // FIXME? Perhaps the integral should be done analitically
+        // between every two FADC slices, instead of numerically
+    }
+    sum *= step; // Transform sum in integral
 }
+
 void MExtractTimeAndChargeSpline::CalcIntegralLoGain(Float_t &sum, Float_t start, Float_t last)
 {
-
-  const Float_t step = 0.1;
-
-  if (start < 0)
-    {
-      last -= start;
-      start = 0.;
-    }
-  
-  Int_t klo = int(start);
-  Int_t khi = klo+1;
-
-  Float_t lo = TMath::Floor(start);
-  Float_t up = lo + 1.;
-
-  const Int_t m = int((start-klo)/step);
-  start = step*m + klo; // Correct start for the digitization due to resolution
-
-  Float_t x = start;
-  Float_t a = up-start;
-  Float_t b = start-lo;
-
-  while (1)
-    {
-      
-      while (x<up)
-        {
-          x += step;
-          
-          if (x > last)
-            {
-              sum *= step;
-              return;
-            }
-          
-          a -= step;
-          b += step;
-          
-          sum += a*fLoGainSignal[klo]
-          + b*fLoGainSignal[khi]
-            + (a*a*a-a)*fLoGainSecondDeriv[klo] 
+    const Float_t step = 0.2;
+
+    if (start < 0)
+    {
+        last -= start;
+        start = 0.;
+    }
+
+    const Int_t n = TMath::Nint((last-start)/step);
+
+    sum = 0.;
+    for (Int_t i=1; i<=n+1; i++)
+    {
+        const Float_t x = start+i*step;
+        const Int_t klo = (Int_t)TMath::Floor(x);
+        const Int_t khi = klo + 1;
+        // Note: if x is close to one integer number (= a FADC sample)
+        // we get the same result by using that sample as klo, and the
+        // next one as khi, or using the sample as khi and the previous
+        // one as klo (the spline is of course continuous). So we do not
+        // expect problems from rounding issues in the argument of
+        // Floor() above (we have noticed differences in roundings
+        // depending on the compilation options).
+
+        const Float_t a = khi - x; // Distance from x to next FADC sample
+        const Float_t b = x - klo; // Distance from x to previous FADC sample
+
+        sum += a*fLoGainSignal[klo]
+            +  b*fLoGainSignal[khi]
+            + (a*a*a-a)*fLoGainSecondDeriv[klo]
             + (b*b*b-b)*fLoGainSecondDeriv[khi];
-          
-        }
-
-      up += 1.;
-      lo += 1.;
-      klo++;
-      khi++;
-      start += 1.;
-      a = 1.;
-      b = 0.;
-    }
-  
+
+        // FIXME? Perhaps the integral should be done analitically
+        // between every two FADC slices, instead of numerically
+    }
+    sum *= step; // Transform sum in integral
 }
-
-
-
 
 // --------------------------------------------------------------------------