Changeset 7349 for trunk/MagicSoft/Mars

Timestamp:

09/12/05 16:35:04 (19 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• NEWS (modified) (1 diff)
• callisto.cc (modified) (1 diff)
• mbadpixels/MBadPixelsCalc.cc (modified) (2 diffs)
• mbadpixels/MBadPixelsTreat.cc (modified) (1 diff)
• mbase/MStatusDisplay.cc (modified) (1 diff)
• mbase/MStatusDisplay.h (modified) (1 diff)
• mgui/MCamEvent.cc (modified) (1 diff)
• mgui/MCamEvent.h (modified) (1 diff)
• mhflux/MHThreshold.h (modified) (1 diff)
• mhvstime/MHSectorVsTime.cc (modified) (1 diff)
• mjobs/MDataSet.cc (modified) (2 diffs)
• mjobs/MJCut.cc (modified) (1 diff)
• mjobs/MSequence.cc (modified) (2 diffs)
• mpedestal/MPedPhotCam.cc (modified) (1 diff)
• msignal/MSignalCam.cc (modified) (2 diffs)
• msignal/MSignalCam.h (modified) (2 diffs)

trunk/MagicSoft/Mars/NEWS

@@ -8 +8 @@
    * general: added a new game. Start it from the interpreter with
         MagicJam j;
+
+   * callisto: MBadPixelsCalc now raises an error instead of simply stopping
+     the eventloop if something went wrong. This is necessary for the
+     automatic processing
+
+   * callisto: Fixed a bug in the treatment of times in the bad pixel
+     treatment. No neighbors have been taken into account, the new
+     arrival time was always calculated by the pixels 0 to 5.
+
+   * callisto: Fixed a bug which caused the random and peak-search pedestal
+     extracted with an extractor to be exchanged for the first (roughly)
+     500 events. (The were simple exchanged in callisto.cc) This bug might
+     have been introduced in Mars 0.9.4 when the order of calculation of the
+     two types of pedestal in callisto got exchanged. The bug only effects
+     the first seconds of data of each sequence.
 
 

trunk/MagicSoft/Mars/callisto.cc

@@ -598 +598 @@
 
         // Where to search for calibration files
-        if (!job4.Process(job1.GetPedestalCam(), job2.GetPedestalCam(), job3.GetPedestalCam()))
+        if (!job4.Process(job1.GetPedestalCam(), job3.GetPedestalCam(), job2.GetPedestalCam()))
             return 2;
 

trunk/MagicSoft/Mars/mbadpixels/MBadPixelsCalc.cc

@@ -137 +137 @@
 // too high pedestal Rms with respect to the mean.
 // 
-Bool_t MBadPixelsCalc::CheckPedestalRms(MBadPixelsPix::UnsuitableType_t type) const
+Int_t MBadPixelsCalc::CheckPedestalRms(MBadPixelsPix::UnsuitableType_t type) const
 {
     const Bool_t checklo = fPedestalLevelVarianceLo>0;
@@ -310 +310 @@
 Int_t MBadPixelsCalc::Process()
 {
-    return fCheckInProcess ? CheckPedestalRms(MBadPixelsPix::kUnsuitableEvt) : kTRUE;
+    if (!fCheckInProcess)
+        return kTRUE;
+
+    return CheckPedestalRms(MBadPixelsPix::kUnsuitableEvt) ? kTRUE : kERROR;
 }
 

trunk/MagicSoft/Mars/mbadpixels/MBadPixelsTreat.cc

@@ -441 +441 @@
         for (unsigned int j=0; j<time.GetSize(); j++)
         {
-            const Double_t t = (*fEvt)[j].GetArrivalTime();
-            if (t>=0)
+            const Int_t nn = gpix.GetNeighbor(j);
+
+            const Double_t t = (*fEvt)[nn].GetArrivalTime();
+            if (t>=0 && !IsPixelBad(nn))
                 time[n0++] = t;
         }

trunk/MagicSoft/Mars/mbase/MStatusDisplay.cc

@@ -2045 +2045 @@
         //if (!GetCanvas(c->GetName()))
         if (!tab || c->GetName()==(TString)tab)
-            DrawClonePad(AddTab(c->GetName()), *c);
+            DrawClonePad(c->GetName(), *c);
 
     return kTRUE;

trunk/MagicSoft/Mars/mbase/MStatusDisplay.h

@@ -204 +204 @@
      void   Update() { HandleTimer(&fTimer); HandleTimer(&fLogTimer); }
 
+     void DrawClonePad(const char *tab, TCanvas &oldc)
+     {
+         DrawClonePad(AddTab(tab), oldc);
+     }
+
      void SetNoContextMenu(Bool_t flag=kTRUE);
 

trunk/MagicSoft/Mars/mgui/MCamEvent.cc

@@ -55 +55 @@
     InitSize(geom.GetNumPixels());
 }
+
+// --------------------------------------------------------------------------
+//
+// Return the mean of all corresponding GetPixelContent
+//
+Double_t MCamEvent::GetCameraMean(const MGeomCam &cam, Int_t type) const
+{
+    Int_t    num  = 0;
+    Double_t mean = 0;
+    for (unsigned int i=0; i<cam.GetNumPixels(); i++)
+    {
+        Double_t val;
+        if (!GetPixelContent(val, i, cam, type))
+            continue;
+
+        mean += val;
+        num ++;
+    }
+    return num == 0 ? 0 : mean/num;
+}

trunk/MagicSoft/Mars/mgui/MCamEvent.h

@@ -17 +17 @@
     virtual void   InitSize(const UInt_t i) { } // Used by MGeomApply see Init()
 
+    virtual Double_t GetCameraMean(const MGeomCam &cam, Int_t type=0) const;
+
     ClassDef(MCamEvent, 0) // A camera event
 };

trunk/MagicSoft/Mars/mhflux/MHThreshold.h

@@ -15 +15 @@
 {
 private:
-    const MMcEvt *fMcEvt; //! POinter to MC energy
+    const MMcEvt *fMcEvt; //! Pointer to MC energy
 
     TH1D fHEnergy;

trunk/MagicSoft/Mars/mhvstime/MHSectorVsTime.cc

@@ -86 +86 @@
 using namespace std;
 
-const TString MHSectorVsTime::gsDefName  = "MSectorHVsTime";
+const TString MHSectorVsTime::gsDefName  = "MHSectorVsTime";
 const TString MHSectorVsTime::gsDefTitle = "Graph of sector mean vs. time";
 

trunk/MagicSoft/Mars/mjobs/MDataSet.cc

@@ -110 +110 @@
     while (!runs.IsNull())
     {
-        TString num = runs(regexp);
+        const TString num = runs(regexp);
+
+        if (num.IsNull())
+        {
+            *fLog << warn << "WARNING - Sequence is NaN (not a number): " << runs << endl;
+            break;
+        }
 
         const Int_t seq = atoi(num.Data());
@@ -122 +128 @@
 
         if (i<n)
-            *fLog << warn << "WARNING - Sequence #" << seq << " alraedy in list... skipped." << endl;
+            *fLog << warn << "WARNING - Sequence #" << seq << " already in list... skipped." << endl;
         else
         {

trunk/MagicSoft/Mars/mjobs/MJCut.cc

@@ -171 +171 @@
     p += "/";
     p += fNameOutput.IsNull() ? Form("ganymed%08d.root", num) : fNameOutput.Data();
+    gSystem->ExpandPathName(p);
     return p;
 }

trunk/MagicSoft/Mars/mjobs/MSequence.cc

@@ -166 +166 @@
     while (!runs.IsNull())
     {
-        TString num = runs(regexp);
+        const TString num = runs(regexp);
+
+        if (num.IsNull())
+        {
+            *fLog << warn << "WARNING - Run is NaN (not a number): " << runs << endl;
+            break;
+        }
 
         const Int_t run = atoi(num.Data());
@@ -178 +184 @@
 
         if (i<n)
-            *fLog << warn << "WARNING - Run #" << run << " alraedy in list... skipped." << endl;
+            *fLog << warn << "WARNING - Run #" << run << " already in list... skipped." << endl;
         else
         {

trunk/MagicSoft/Mars/mpedestal/MPedPhotCam.cc

@@ -357 +357 @@
         break;
     case 5:
-        val = (*this)[idx].GetRms()*TMath::Sqrt(cam.GetPixRatio(idx));
+        val = (*this)[idx].GetRms()*cam.GetPixRatioSqrt(idx);
         break;
     default:

trunk/MagicSoft/Mars/msignal/MSignalCam.cc

@@ -252 +252 @@
         Float_t testval = pix.GetNumPhotons()/pix.GetErrorPhot();
         if (geom)
-            testval *= TMath::Sqrt(geom->GetPixRatio(i/*pix.GetPixId()*/));
+            testval *= geom->GetPixRatioSqrt(i/*pix.GetPixId()*/);
 
         if (testval < minval)
@@ -280 +280 @@
         Float_t testval = pix.GetNumPhotons()/pix.GetErrorPhot();
         if (geom)
-            testval *= TMath::Sqrt(geom->GetPixRatio(i/*pix.GetPixId()*/));
+            testval *= geom->GetPixRatioSqrt(i/*pix.GetPixId()*/);
 
         if (testval > maxval)

trunk/MagicSoft/Mars/msignal/MSignalCam.h

@@ -46 +46 @@
     }
 
+    // Setter functions for use in image cleaning classes only
+    void SetSinglePixels(Short_t num, Float_t size)  { fNumSinglePixels=num; fSizeSinglePixels=size; }
+    void SetNumPixelsSaturated(UInt_t hi, UInt_t lo) { fNumPixelsSaturatedHiGain=hi;fNumPixelsSaturatedLoGain=lo; }
+
     // Getter functions
     UInt_t  GetNumPixels() const { return fPixels->GetEntriesFast(); }
@@ -55 +59 @@
     Int_t   GetNumPixelsSaturatedHiGain() const { return fNumPixelsSaturatedHiGain; }
     Int_t   GetNumPixelsSaturatedLoGain() const { return fNumPixelsSaturatedLoGain; }
-
-    // Setter functions for use in image cleaning classes only
-    void SetSinglePixels(Short_t num, Float_t size)  { fNumSinglePixels=num; fSizeSinglePixels=size; }
-    void SetNumPixelsSaturated(UInt_t hi, UInt_t lo) { fNumPixelsSaturatedHiGain=hi;fNumPixelsSaturatedLoGain=lo; }
 
     Bool_t  IsPixelExisting(Int_t id) const;