Changeset 7979 for trunk

Timestamp:

09/28/06 10:05:44 (18 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• NEWS (modified) (1 diff)
• mfilter/MFMagicCuts.cc (modified) (5 diffs)
• mfilter/MFMagicCuts.h (modified) (1 diff)

trunk/MagicSoft/Mars/Changelog

@@ -24 +24 @@
      - implemented a hadronness cut as an option
      - updated class reference
+     - fixed abug introduced 14.7.2005 which caused the M3Long of the
+       anti source to be not properly evaluated in case of optimization.
 
 

trunk/MagicSoft/Mars/NEWS

@@ -121 +121 @@
      cut in hadronness (index 8) and a fixed cut in size (index 9).
 
+   - ganymed: MFMagicCuts: fixed abug introduced 2005/7/14 which caused
+     the M3Long of the anti source to be not properly evaluated 
+     (actually is was evaluated as a unique random number) in case
+     of optimization with anti-theta cut switched on. This might have
+     lead to improper, but not necessarily wrong, optimization results.
 
 

trunk/MagicSoft/Mars/mfilter/MFMagicCuts.cc

@@ -33 +33 @@
 //      lgsize       = log10(MHillas.fSize)
 //
+//      leakage1     = log10(MNewImagePar.fLeakage1+1)
+//
 //      alpha        = MHillasSrc.fAlpha
 //      dist         = MHillasSrc.fDist*fMm2Deg
-//      leakage1     = log10(MNewImagePar.fLeakage1+1)
-//
 //      m3long       = MHillasExt.fM3Long*sign(MHillasSrc.fCosDeltaAlpha)*fMm2Deg
+//
+//      antialpha    = MHillasSrcAnti.fAlpha
+//      antidist     = MHillasSrcAnti.fDist*fMm2Deg
 //      antim3long   = MHillasExt.fM3Long*sign(MHillasSrcAnti.fCosDeltaAlpha)*fMm2Deg
 //
@@ -51 +54 @@
 //          antidisp    = TMath::Sign(disp, antim3long-c[5])
 //          thetasq     = disp^2 + dist^2 - 2*disp*dist*alpha
-//          antithetasq = antidisp^2 + dist^2 - 2*antidisp*dist*alpha
+//          antithetasq = antidisp^2 + antidist^2 - 2*antidisp*antidist*antialpha
 //
 //    c[1]:
@@ -140 +143 @@
     AddToBranchList("MHillas.fSize");
     AddToBranchList("MHillasSrc.fAlpha");
+    AddToBranchList("MHillasSrc.fDist");
+    AddToBranchList("MHillasSrc.fCosDeltaAlpha");
     AddToBranchList("MHillasSrcAnti.fAlpha");
-    AddToBranchList("MHillasExt.fMaxDist");
+    AddToBranchList("MHillasSrcAnti.fDist");
+    AddToBranchList("MHillasSrcAnti.fCosDeltaAlpha");
     AddToBranchList("MHillasExt.fM3Long");
     AddToBranchList("MNewImagePar.fLeakage1");
@@ -270 +276 @@
     fMatrix = mat;
 
+    fMap[kEWdivL]   = fMatrix->AddColumn("MHillas.fWidth/MHillas.fLength");
     fMap[kESize]    = fMatrix->AddColumn("log10(MHillas.fSize)");
     fMap[kEArea]    = fMatrix->AddColumn("MHillas.GetArea*MGeomCam.fConvMm2Deg*MGeomCam.fConvMm2Deg");
-    fMap[kEM3Trans] = fMatrix->AddColumn("abs(MHillasExt.fM3Trans)*MGeomCam.fConvMm2Deg");
-    fMap[kEM3Long]  = fMatrix->AddColumn("MHillasExt.fM3Long*sign(MHillasSrc.fCosDeltaAlpha)*MGeomCam.fConvMm2Deg");
-    fMap[kESrcSign] = fMatrix->AddColumn("sign(MHillasSrc.fCosDeltaAlpha)");
-    fMap[kEWdivL]   = fMatrix->AddColumn("MHillas.fWidth/MHillas.fLength");
+
+    fMap[kELeakage] = fMatrix->AddColumn("log10(MNewImagePar.fLeakage1+1)");
 
     fMap[kEAlpha]   = fMatrix->AddColumn("MHillasSrc.fAlpha");
     fMap[kEDist]    = fMatrix->AddColumn("MHillasSrc.fDist*MGeomCam.fConvMm2Deg");
-    fMap[kELeakage] = fMatrix->AddColumn("log10(MNewImagePar.fLeakage1+1)");
+    fMap[kEM3Long]  = fMatrix->AddColumn("MHillasExt.fM3Long*sign(MHillasSrc.fCosDeltaAlpha)*MGeomCam.fConvMm2Deg");
+
+    fMap[kESrcSign] = fMatrix->AddColumn("sign(MHillasSrc.fCosDeltaAlpha)");
 
     if (fThetaCut&kOff)
@@ -285 +292 @@
         fMap[kEAlphaAnti]  = fMatrix->AddColumn("MHillasSrcAnti.fAlpha");
         fMap[kEDistAnti]   = fMatrix->AddColumn("MHillasSrcAnti.fDist*MGeomCam.fConvMm2Deg");
+        fMap[kEM3LongAnti] = fMatrix->AddColumn("MHillasExt.fM3Long*sign(MHillasSrcAnti.fCosDeltaAlpha)*MGeomCam.fConvMm2Deg");
     }
 

trunk/MagicSoft/Mars/mfilter/MFMagicCuts.h

@@ -42 +42 @@
     // the last on in the list. It is used as counter for fMap.
     enum {
-        kESize, kEAlpha, kEAlphaAnti, kEArea, kEDist,
-        kEM3Long, kEM3LongAnti, kEM3Trans, kEDistAnti, kEWdivL,
-        kELeakage, kESrcSign, kEHadronness,
+        kESize, kEAlpha, kEAlphaAnti, kEArea, kEDist, kEDistAnti,
+        kEM3Long, kEM3LongAnti, kEWdivL, kELeakage, kESrcSign, kEHadronness,
         kLastElement
     };