Changeset 8147

Timestamp:

10/23/06 13:27:21 (18 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• mbadpixels/MBadPixelsCam.cc (modified) (1 diff)
• mcalib/MCalibCalcFromPast.cc (modified) (2 diffs)
• mcalib/MCalibrationChargeCalc.cc (modified) (32 diffs)
• mcalib/MCalibrationChargePix.cc (modified) (1 diff)
• mfbase/MFDataPhrase.cc (modified) (1 diff)
• mhcalib/MHCalibrationChargeCam.cc (modified) (4 diffs)
• mhcalib/MHCalibrationPulseTimeCam.cc (modified) (3 diffs)

trunk/MagicSoft/Mars/mbadpixels/MBadPixelsCam.cc

@@ -152 +152 @@
     if (n!=GetSize())
     {
-        *fLog << warn << "MBadPixelsCam::Merge: Size mismatch... ignored." << endl;
+        *fLog << warn << "MBadPixelsCam::Merge: Size mismatch (" << n << "," << GetSize() << ")... ignored." << endl;
         return;
     }

trunk/MagicSoft/Mars/mcalib/MCalibCalcFromPast.cc

@@ -294 +294 @@
   *fLog << inf << GetDescriptor() << ": Finalize calibration histograms: " << flush;
 
+  // This fills the IntensityCam which are newly created by
+  // ReInitialize with the result of the last calib cycle
   if (Finalize("MHCalibrationChargeCam"))      *fLog << "MHCalibrationChargeCam..." << flush;
   if (Finalize("MHCalibrationChargeBlindCam")) *fLog << "MHCalibrationChargeBlindCam..." << flush;
@@ -305 +307 @@
   if (fChargeCalc)
     {
+        // Finalized Pedestals, Charges, Bad Pixels and all QE cams
         if (!fChargeCalc->Finalize())
         {

trunk/MagicSoft/Mars/mcalib/MCalibrationChargeCalc.cc

@@ -1 +1 @@
 /* ======================================================================== *\
-! $Name: not supported by cvs2svn $:$Id: MCalibrationChargeCalc.cc,v 1.169 2006-10-20 18:50:35 tbretz Exp $
+! $Name: not supported by cvs2svn $:$Id: MCalibrationChargeCalc.cc,v 1.170 2006-10-23 12:27:21 tbretz Exp $
 ! --------------------------------------------------------------------------
 !
@@ -732 +732 @@
     // the real number might change from event to event.
     // (up to 50%!)
+
   fNumHiGainSamples  =  fSignal->GetNumUsedHiGainFADCSlices();
   fNumLoGainSamples  =  fSignal->GetNumUsedLoGainFADCSlices();
@@ -1003 +1004 @@
     return kFALSE;
 
+  const TString desc = Form("%7s%4d: ", what, cal.GetPixId());
+
   if (cal.GetMean() < fChargeLimit*cal.GetPedRms())
     {
-      *fLog << warn
+      *fLog << warn << desc
             << Form("Fitted Charge: %5.2f < %2.1f",cal.GetMean(),fChargeLimit)
-            << Form(" * Pedestal RMS %5.2f in %s%3i",cal.GetPedRms(),what,cal.GetPixId()) << endl;
+            << Form(" * Pedestal RMS %5.2f",cal.GetPedRms()) << endl;
       bad.SetUncalibrated( MBadPixelsPix::kChargeIsPedestal);
     }
@@ -1013 +1016 @@
    if (cal.GetMean() < fChargeRelErrLimit*cal.GetMeanErr()) 
     {
-      *fLog << warn
+      *fLog << warn << desc
             << Form("Fitted Charge: %4.2f < %2.1f",cal.GetMean(),fChargeRelErrLimit)
-            << Form(" * its error %4.2f in %s%3i",cal.GetMeanErr(),what,cal.GetPixId()) << endl;
+            << Form(" * its error %4.2f",cal.GetMeanErr()) << endl;
       bad.SetUncalibrated( MBadPixelsPix::kChargeRelErrNotValid );
     }
@@ -1021 +1024 @@
   if (cal.GetSigma() < cal.GetPedRms())
     {
-      *fLog << warn << "Sigma of Fitted Charge: "
+      *fLog << warn << desc << "Sigma of Fitted Charge: "
             << Form("%6.2f <",cal.GetSigma()) << " Ped. RMS="
-            << Form("%5.2f", cal.GetPedRms()) << " in " << what
-            << Form("%3i",cal.GetPixId()) << endl;
+            << Form("%5.2f", cal.GetPedRms()) << endl;
       bad.SetUncalibrated( MBadPixelsPix::kChargeSigmaNotValid );
       return kFALSE;
@@ -1031 +1033 @@
   if (!cal.CalcReducedSigma())
     {
-      *fLog << warn << "Could not calculate the reduced sigma in " << what
-            << ":                        " << Form("%4i",cal.GetPixId())
-            << endl;
+      *fLog << warn << desc << "Could not calculate the reduced sigma" << endl;
       bad.SetUncalibrated( MBadPixelsPix::kChargeSigmaNotValid );
       return kFALSE;
@@ -1040 +1040 @@
   if (!cal.CalcFFactor())
     {
-      *fLog << warn << "Could not calculate the F-Factor in " << what
-            << ":                             " << Form("%4i",cal.GetPixId())
-            << endl;
+      *fLog << warn << desc << "Could not calculate the F-Factor"<< endl;
       bad.SetUncalibrated(MBadPixelsPix::kDeviatingNumPhes);
       bad.SetUnsuitable(MBadPixelsPix::kUnsuitableRun);
@@ -1058 +1056 @@
   if (!cal.CalcConvFFactor())
     {
-      *fLog << warn << "Could not calculate the Conv. FADC counts to Phes in ";
-      *fLog << what << ":           " << Form("%4i", cal.GetPixId()) << endl;
+      *fLog << warn << desc << "Could not calculate the Conv. FADC counts to Phes"<< endl;
       bad.SetUncalibrated(MBadPixelsPix::kDeviatingNumPhes);
       return kFALSE;
@@ -1069 +1066 @@
   if (!fExtractor)
     {
-      *fLog << err << "Extractor resolution has been chosen, but not extractor is set. Cannot calibrate" << endl;
+      *fLog << err << "Extractor resolution has been chosen, but not extractor is set. Cannot calibrate." << endl;
       return kFALSE;
     }
@@ -1083 +1080 @@
   if (resinfadc > 3.0*cal.GetPedRms() )
     {
-      *fLog << warn << " Extractor Resolution: " << resinfadc << " bigger than 3 Pedestal RMS "
-            << cal.GetPedRms() << endl;
+      *fLog << warn << desc << "Extractor Resolution " << Form("%5.2f", resinfadc) << " bigger than 3 Pedestal RMS "
+            << Form("%4.2f", cal.GetPedRms()) << endl;
       resinfadc = 3.0*cal.GetPedRms();
     }
@@ -1090 +1087 @@
   if (!cal.CalcReducedSigma(resinfadc))
     {
-        *fLog << warn << "Could not calculate the reduced sigma in " << what;
-        *fLog << ":                        " << Form("%4i",cal.GetPixId()) << endl;
+        *fLog << warn << desc << "Could not calculate the reduced sigma" << endl;
         bad.SetUncalibrated( MBadPixelsPix::kChargeSigmaNotValid );
         return kFALSE;
@@ -1098 +1094 @@
   if (!cal.CalcFFactor())
     {
-        *fLog << warn << "Could not calculate the F-Factor in " << what;
-        *fLog << ":                             " << Form("%4i",cal.GetPixId()) << endl;
+        *fLog << warn << desc << "Could not calculate the F-Factor" << endl;
       bad.SetUncalibrated(MBadPixelsPix::kDeviatingNumPhes);
       bad.SetUnsuitable(MBadPixelsPix::kUnsuitableRun);
@@ -1115 +1110 @@
   if (!cal.CalcConvFFactor())
     {
-      *fLog << warn << "Could not calculate the Conv. FADC counts to Phes in "
-            << what << ":           " << Form("%4i",cal.GetPixId())
-            << endl;
+      *fLog << warn << desc << "Could not calculate the Conv. FADC counts to Phes" << endl;
       bad.SetUncalibrated(MBadPixelsPix::kDeviatingNumPhes);
       return kFALSE;
@@ -1135 +1128 @@
         return;
 
+    const TString desc = Form("%7s%4d: ", what, cal.GetPixId());
+
     if (cal.GetAbsTimeRms() > fArrTimeRmsLimit)
     {
         *fLog << warn;
-        *fLog << "RMS of pulse arrival times: " << Form("%2.1f", cal.GetAbsTimeRms());
-        *fLog << " FADC sl. < " << Form("%2.1f", fArrTimeRmsLimit);
-        *fLog << "   in " << what << Form("%3i", cal.GetPixId()) << endl;
+        *fLog << desc << "RMS of pulse arrival times: " << Form("%2.1f", cal.GetAbsTimeRms());
+        *fLog << " FADC sl. < " << Form("%2.1f", fArrTimeRmsLimit) << endl;
         bad.SetUncalibrated( MBadPixelsPix::kFluctuatingArrivalTimes);
     }
@@ -1310 +1304 @@
       if (numareavalid[i] == 1)
         areavars[i] = 0.;
-      else if (numareavalid[i] == 0)
-        {
-          areaphes[i]    = -1.;
-          areaweights[i] = -1.;
-        }
       else
         {
@@ -1323 +1312 @@
       if (areavars[i] < 0.)
         {
-          *fLog << warn << GetDescriptor() << ": No pixels with valid variance of photo-electrons found "
-                << "in area index: " << i << endl;
+          *fLog << warn << "Area   " << setw(4) << i << ": No pixels with valid variance of photo-electrons found." << endl;
           continue;
         }
@@ -1367 +1355 @@
       if (mean < 0.)
         {
-            *fLog << inf << GetDescriptor() << ": Fitted mean number of photo-electrons " << endl;
-            *fLog << " with area idx " << i << ": " << mean << " is smaller than 0. " << endl;
-            *fLog << warn << " Will use the simple mean and rms " << endl;
+            *fLog << inf  << "Area   " << setw(4) << i << ": Fitted mean number of phe smaller 0." << endl;
+            *fLog << warn << "Area   " << setw(4) << i << ": Will use the simple mean and rms " << endl;
             SetPheFitOK(i,kFALSE);
             delete hist;
@@ -1375 +1362 @@
         }
       
-      *fLog << inf << GetDescriptor() << ": Mean number of phes with area idx " << i << ": "
+      *fLog << inf << "Area   " << setw(4) << i << ": Mean number of phes: "
             << Form("%7.2f+-%6.2f",mean,sigma) << endl;
 
@@ -1427 +1414 @@
       if ( nphe < lowlim[aidx] || nphe > upplim[aidx] )
         {
-          *fLog << warn << "Number of phes: "
-                << Form("%7.2f out of +%3.1f-%3.1f sigma limit: ",nphe,fPheErrUpperLimit,fPheErrLowerLimit)
-                << Form("[%7.2f,%7.2f] pixel%4i",lowlim[aidx],upplim[aidx],i) << endl;
+            *fLog << warn << "Pixel  " << setw(4) << i << ": Num of phe "
+                << Form("%7.2f out of +%3.1f-%3.1f sigma limit ",nphe,fPheErrUpperLimit,fPheErrLowerLimit)
+                << Form("[%7.2f,%7.2f]",lowlim[aidx],upplim[aidx]) << endl;
           bad.SetUncalibrated( MBadPixelsPix::kDeviatingNumPhes );
 
@@ -1447 +1434 @@
       sectorphes    [sector] += nphe/area;
       numsectorvalid[sector] ++;
-    } 
+    }
 
   *fLog << endl;
@@ -1469 +1456 @@
           areaphes[aidx]    /=  numareavalid[aidx];
         }
-      
+
       if (areaweights[aidx] < 0. || areaphes[aidx] <= 0.)
         {
-          *fLog << warn << GetDescriptor() 
-                << ": Mean number phes from area index " << aidx << " could not be calculated: "
+          *fLog << warn << "Area   " << setw(4) << aidx << ": Mean number phes could not be calculated: "
                 << " Mean: "  << areaphes[aidx] 
-                << " Variance: " << areaweights[aidx]    << endl;
+                << " Var: " << areaweights[aidx]    << endl;
           apix.SetFFactorMethodValid(kFALSE);
           continue;
         }
-      
-      *fLog << inf << GetDescriptor() 
-            << ": Average total phes for area idx " << aidx << ": "
+
+      *fLog << inf << "Area   " << setw(4) << aidx << ": Average total phes: "
             << Form("%7.2f +- %6.2f",areaphes[aidx],TMath::Sqrt(areaweights[aidx])) << endl;
-                    
+
       apix.SetPheFFactorMethod   ( areaphes[aidx] );
       apix.SetPheFFactorMethodVar( areaweights[aidx] / numareavalid[aidx] );      
@@ -1515 +1500 @@
       if (sectorweights[sector] < 0. || sectorphes[sector] <= 0.)
         {
-          *fLog << warn << GetDescriptor() 
-                <<": Mean number phes/area for sector " << sector << " could not be calculated: "
-                << " Mean: "  << sectorphes[sector] 
-                << " Variance: "             << sectorweights[sector]    << endl;
+          *fLog << warn << "Sector " << setw(4) << sector
+                <<": Mean number phes/area could not be calculated:"
+                << " Mean: "  << sectorphes[sector] << " Var: " << sectorweights[sector]    << endl;
           spix.SetFFactorMethodValid(kFALSE);
           continue;
         }
 
-      *fLog << inf << GetDescriptor() 
-            << ": Avg number phes/mm^2 in sector " << sector << ": "
+      *fLog << inf << "Sector " << setw(4) << sector 
+            << ": Avg number phes/mm^2: "
             << Form("%5.3f+-%4.3f",sectorphes[sector],TMath::Sqrt(sectorweights[sector]))
             << endl;
@@ -1558 +1542 @@
             {
               *fLog << warn << GetDescriptor() 
-                    << ": Could not calculate the Conv. FADC counts to Phes in pixel:  "
-                    << Form("         %4i",pix.GetPixId()) 
+                    << "Pixel  " << setw(4) << pix.GetPixId()
+                    <<": Could not calculate the Conv. FADC counts to Phes"
                     << endl;
               bad.SetUncalibrated( MBadPixelsPix::kDeviatingNumPhes );
@@ -1611 +1595 @@
       if (2.*(lambdacheck-lambda)/(lambdacheck+lambda) > fLambdaCheckLimit)
         {
-          *fLog << warn << GetDescriptor() << ": Lambda="
+          *fLog << warn << "BlindPix " << i << ": Lambda="
                 << Form("%4.2f", lambda) << " and Lambda-Check="
                 << Form("%4.2f", lambdacheck) << " differ by more than "
-                << Form("%4.2f", fLambdaCheckLimit) << " in the Blind Pixel Nr."
-                << Form("%2i", i) << endl;
+                << Form("%4.2f", fLambdaCheckLimit) << endl;
           blindpix.SetValid(kFALSE);
           continue;
@@ -1622 +1605 @@
       if (lambdaerr > fLambdaErrLimit) 
         {
-            *fLog << warn << GetDescriptor() << ": Error of Fitted Lambda="
+            *fLog << warn << "BlindPix " << i << ": Error of Fitted Lambda="
                 << Form("%4.2f", lambdaerr) << " is greater than "
-                << Form("%4.2f", fLambdaErrLimit)
-                << " in Blind Pixel Nr." << Form("%2d", i) << endl;
+                << Form("%4.2f", fLambdaErrLimit) << endl;
           blindpix.SetValid(kFALSE);
           continue;
@@ -1668 +1650 @@
   if (fPINDiode->GetMean() < fChargeLimit*fPINDiode->GetPedRms())
     {
-      *fLog << warn << GetDescriptor() << ": Fitted Charge is smaller than "
-            << fChargeLimit << " Pedestal RMS in PINDiode " << endl;
+      *fLog << warn << "PINDiode   : Fitted Charge is smaller than "
+            << fChargeLimit << " Pedestal RMS." << endl;
       return kFALSE;
     }
@@ -1675 +1657 @@
   if (fPINDiode->GetMeanErr() < fChargeErrLimit) 
     {
-      *fLog << warn << GetDescriptor() << ": Error of Fitted Charge is smaller than "
-            << fChargeErrLimit << " in PINDiode " << endl;
+        *fLog << warn << "PINDiode   : Error of Fitted Charge is smaller than "
+            << fChargeErrLimit << endl;
       return kFALSE;
     }
@@ -1682 +1664 @@
   if (fPINDiode->GetMean() < fChargeRelErrLimit*fPINDiode->GetMeanErr()) 
     {
-      *fLog << warn << GetDescriptor() << ": Fitted Charge is smaller than "
-            << fChargeRelErrLimit << "* its error in PINDiode " << endl;
+        *fLog << warn << "PINDiode   : Fitted Charge is smaller than "
+            << fChargeRelErrLimit << "* its error" << endl;
       return kFALSE;
     }
@@ -1689 +1671 @@
   if (fPINDiode->GetSigma() < fPINDiode->GetPedRms())
     {
-      *fLog << warn << GetDescriptor() 
-            << ": Sigma of Fitted Charge smaller than Pedestal RMS in PINDiode " << endl;
+        *fLog << warn << "PINDiode   : Sigma of Fitted Charge smaller than Pedestal RMS" << endl;
       return kFALSE;
     }
@@ -1697 +1678 @@
   if (!fPINDiode->CalcFluxOutsidePlexiglass())
     {
-      *fLog << warn << "Could not calculate the flux of photons from the PIN Diode, "
+        *fLog << warn << "PINDiode   : Could not calculate the flux of photons, "
             << "will skip PIN Diode Calibration " << endl;
       return kFALSE;
@@ -1905 +1886 @@
         }
 
-      *fLog << inf << GetDescriptor() << ": Mean F-Factor " 
-          << "with area index #" << i << ": " << Form("%4.2f+-%4.2f",mean,sigma) << endl;
+      *fLog << inf << "Area    " << setw(4) << i <<": Mean F-Factor :"
+          << Form("%4.2f+-%4.2f",mean,sigma) << endl;
 
       lowlim  [i] = 1.;
@@ -1932 +1913 @@
       if ( ffactor < lowlim[aidx] || ffactor > upplim[aidx] )
         {
-          *fLog << warn << "Overall F-Factor "
+            *fLog << warn << "Pixel  " << setw(4) << i<< ": Overall F-Factor "
                 << Form("%5.2f",ffactor) << " out of range ["
-                << Form("%5.2f,%5.2f",lowlim[aidx],upplim[aidx]) << "] Pixel " << i << endl;
+                << Form("%5.2f,%5.2f",lowlim[aidx],upplim[aidx]) << "]" << endl;
 
           bad.SetUncalibrated( MBadPixelsPix::kDeviatingFFactor );

trunk/MagicSoft/Mars/mcalib/MCalibrationChargePix.cc

@@ -799 +799 @@
   if (convrelvar > limit || convrelvar < 0.)
     {
-      *fLog << warn << GetDescriptor() << ":  Conv. F-Factor Method Rel. Var.: " 
-            << Form("%4.3f out of limits: [0,%3.2f] in pixel:%4i",convrelvar,limit,fPixId) << endl;
-      return kFALSE;
+        *fLog << warn << "pixel  " << setw(4) << fPixId << ": Conv. F-Factor Method Rel. Var.: "
+            << Form("%4.3f out of limits: [0,%3.2f]",convrelvar,limit) << endl;
+        return kFALSE;
     }
   

trunk/MagicSoft/Mars/mfbase/MFDataPhrase.cc

@@ -116 +116 @@
     *fLog << inf << "found: ";
     fData->Print();
+    *fLog << endl;
 }
 

trunk/MagicSoft/Mars/mhcalib/MHCalibrationChargeCam.cc

@@ -719 +719 @@
       
       const Float_t sumhi = pix.GetExtractedSignalHiGain();
-      const Bool_t  sathi = pix.IsHiGainSaturated();
+      const Int_t   sathi = pix.IsHiGainSaturated() ? 1 : 0;
 
       if (IsOscillations())
@@ -742 +742 @@
         {
           MHCalibrationChargePix &histlo = (MHCalibrationChargePix&)(*this)(i);
-          const Float_t sumlo  = pix.GetExtractedSignalLoGain();
-          const Int_t   satlo = (Int_t)pix.GetNumLoGainSaturated();
+          const Float_t sumlo = pix.GetExtractedSignalLoGain();
+          const Int_t   satlo = pix.IsLoGainSaturated() ? 1 : 0;
           
           if (IsOscillations())
@@ -1130 +1130 @@
     if (mean<lowerlimit)
     {
-        *fLog << warn << "Mean Arr.Time: "
+        *fLog << warn << hist.GetName() << ": Mean Arr.Time: "
             << Form("%4.1f < %4.1f, %3.1f", mean, TMath::Floor(first)+fTimeLowerLimit, fTimeLowerLimit)
-            << " slices below " << Form("%2i", (Int_t)first) << " in "
-            << hist.GetName() << endl;
+            << " slices below " << Form("%2i", (Int_t)first) << endl;
         bad.SetUncalibrated( MBadPixelsPix::kMeanTimeInFirstBin );
     }
@@ -1139 +1138 @@
     if (mean>upperlimit)
     {
-        *fLog << warn << "Mean Arr.Time: "
+        *fLog << warn << hist.GetName() << ": Mean Arr.Time: "
             << Form("%4.1f > %4.1f, %3.1f", mean, TMath::Floor(last)-fTimeUpperLimit, fTimeUpperLimit)
-            << " slices above " << Form("%2i", (Int_t)last) << " in "
-            << hist.GetName() << endl;
+            << " slices above " << Form("%2i", (Int_t)last) << endl;
         bad.SetUncalibrated( MBadPixelsPix::kMeanTimeInLast2Bins );
     }

trunk/MagicSoft/Mars/mhcalib/MHCalibrationPulseTimeCam.cc

@@ -414 +414 @@
       Byte_t *end   = start + pixel.GetNumHiGainSamples();
       Byte_t *p     = start;
-      Byte_t max    = 0;
+      Byte_t *max   = start;
       Int_t  maxpos = 0;
 
       while (p < end)
         {
-          if ((*p > max) && (*p < fSaturationLimit))
+          if (*p > *max)
             {
-              max = *p;
+              max = p;
               maxpos = p-start-1;
             }
@@ -433 +433 @@
       while (p < end)
         {
-          if ((*p > max) && (*p < fSaturationLimit))
+          if (*p > *max)
             {
-              max = *p;
+              max = p;
               maxpos = p-start+pixel.GetNumHiGainSamples() - 1;
             }
@@ -441 +441 @@
         }
 
-      if (max < fLowerSignalLimit)
+      if (*max < fLowerSignalLimit || *max > fSaturationLimit)
         continue;