Changeset 8364

Timestamp:

03/04/07 14:01:14 (18 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• mhist/MHEvent.cc (modified) (2 diffs)
• mraw/MRawEvtData.cc (modified) (3 diffs)
• mraw/MRawEvtPixelIter.cc (modified) (4 diffs)
• mraw/MRawEvtPixelIter.h (modified) (1 diff)
• msignal/MExtractor.cc (modified) (5 diffs)
• msignal/MExtractor.h (modified) (5 diffs)
• msignal/MSignalCalc.cc (modified) (15 diffs)
• msignal/MSignalCalc.h (modified) (1 diff)

trunk/MagicSoft/Mars/mhist/MHEvent.cc

@@ -241 +241 @@
         fHist->SetCamContent(*event, 0);
         break;
-    case kEvtIdxMax:
-        fHist->SetCamContent(*event, 5);
-        break;
+//    case kEvtIdxMax:
+//        fHist->SetCamContent(*event, 3/*5*/);
+//        break;
     case kEvtArrTime:
         fHist->SetCamContent(*event, 6);
@@ -255 +255 @@
     case kEvtIslandIndex:
         fHist->SetCamContent(*event, 5);
-        break; 
+        break;
+    default:
+        *fLog << "ERROR - Case " << (int)fType << " not implemented..." << endl;
     }
 

trunk/MagicSoft/Mars/mraw/MRawEvtData.cc

@@ -550 +550 @@
     const UShort_t nhi  = fRunHeader->GetNumSamplesHiGain();
     const UShort_t npic = fRunHeader->GetNumPixInCrate();
-
-    return (nhi+nlo)*npic;
+    const UShort_t nbps = fRunHeader->GetNumBytesPerSample();
+
+    return (nhi+nlo)*npic*nbps;
 }
 
@@ -566 +567 @@
 Bool_t MRawEvtData::GetPixelContent(Double_t &val, Int_t idx, const MGeomCam &cam, Int_t type) const
 {
+    *fLog << warn << "WARNING - The use of MRawEvtData::GetPixelContent is deprecated!" << endl;
+
+    /*
     MRawEvtPixelIter Next(const_cast<MRawEvtData*>(this));
     if (!Next.Jump(idx))
@@ -592 +596 @@
         return val >= 0;
     }
-
+*/
     return kTRUE;
 }

trunk/MagicSoft/Mars/mraw/MRawEvtPixelIter.cc

@@ -164 +164 @@
 }
 
+/*
 // --------------------------------------------------------------------------
 //
 // Returns the index of the FADC slice the maximum signal in. If the highest
-// slices have the same value the last one is returned.
+// slices have the same value the first one is returned.
 //
 Byte_t MRawEvtPixelIter::GetIdxMaxHiGainSample(const Byte_t hifirst, const Byte_t hilast) const
@@ -188 +189 @@
 //
 // Returns the index of the FADC slice the maximum signal in. If no lo-gains
-// are available -1 is returned. If the highest slices have the same value the
-// last one is returned.
+// are available -1 is returned. If the highest slices have the same value
+// the first one is returned.
 //
 Short_t MRawEvtPixelIter::GetIdxMaxLoGainSample(const Byte_t lofirst, const Byte_t lolast) const
@@ -294 +295 @@
 // If no lo-gains are existing and the hi-gains have saturating values
 // a negative value (-1) is returned.
-// 
+//
 Short_t MRawEvtPixelIter::GetIdxMaxHiLoGainSample() const
 {
@@ -371 +372 @@
     return sum;
 }
+*/

trunk/MagicSoft/Mars/mraw/MRawEvtPixelIter.h

@@ -91 +91 @@
     */
 
-    Byte_t  GetNumHiGainSamples() const { return fNumHiGainSamples ; }// Use is deprecated!
-    Byte_t  GetNumLoGainSamples() const { return fNumLoGainSamples ; }// Use is deprecated!
+//    Byte_t  GetNumHiGainSamples() const { return fNumHiGainSamples ; }// Use is deprecated!
+//    Byte_t  GetNumLoGainSamples() const { return fNumLoGainSamples ; }// Use is deprecated!
     Byte_t  GetNumSamples() const { return fNumHiGainSamples+fNumLoGainSamples; }
 
-    Byte_t  GetIdxMaxHiGainSample(const Byte_t hifirst=0, const Byte_t hilast=0xff) const;
-    Short_t GetIdxMaxLoGainSample(const Byte_t lofirst=0, const Byte_t lolast=0xff) const;
+//    Byte_t  GetIdxMaxHiGainSample(const Byte_t hifirst=0, const Byte_t hilast=0xff) const;
+//    Short_t GetIdxMaxLoGainSample(const Byte_t lofirst=0, const Byte_t lolast=0xff) const;
 
-    Byte_t  GetMaxHiGainSample(const Byte_t hifirst=0, const Byte_t hilast=0xff) const;
+//    Byte_t  GetMaxHiGainSample(const Byte_t hifirst=0, const Byte_t hilast=0xff) const;
 
-    ULong_t GetSumHiGainSamples() const;
-    ULong_t GetSumSqrHiGainSamples() const;
-    Float_t GetVarHiGainSamples() const;
+//    ULong_t GetSumHiGainSamples() const;
+//    ULong_t GetSumSqrHiGainSamples() const;
+//    Float_t GetVarHiGainSamples() const;
 
-    Byte_t  GetMaxLoGainSample() const;
-    Short_t GetIdxMaxHiLoGainSample() const;
+//    Byte_t  GetMaxLoGainSample() const;
+//    Short_t GetIdxMaxHiLoGainSample() const;
 
-    ULong_t GetSumLoGainSamples() const;
-    ULong_t GetSumSqrLoGainSamples() const;
+//    ULong_t GetSumLoGainSamples() const;
+//    ULong_t GetSumSqrLoGainSamples() const;
 
     Bool_t HasLoGain() const { return fNumLoGainSamples>0; }

trunk/MagicSoft/Mars/msignal/MExtractor.cc

@@ -17 +17 @@
 !
 !   Author(s): Markus Gaug, 04/2004 <mailto:markus@ifae.es>
-!
-!   Copyright: MAGIC Software Development, 2000-2004
+!   Author(s): Thomas Bretz <mailto:tbretz@astro.uni-wuerzburg.de>
+!
+!   Copyright: MAGIC Software Development, 2000-2007
 !
 !
@@ -74 +75 @@
 //  - Byte_t fHiLoLast;                // Number of slices in fLoGainSamples counted for the High-Gain signal
 //
+// Class Version 8:
+// ----------------
+//  - Byte_t fSaturationLimit;
+//  + Uint_t fSaturationLimit;
+//
 //
 // Input Containers:
@@ -108 +114 @@
 using namespace std;
 
-const Byte_t  MExtractor::fgSaturationLimit = 245;
+const UInt_t  MExtractor::fgSaturationLimit = 245;
 const TString MExtractor::fgNamePedestalCam = "MPedestalCam";
 const TString MExtractor::fgNameSignalCam   = "MExtractedSignalCam";
@@ -255 +261 @@
     if (numl==0)
     {
-        *fLog << inf << "No lo-gains... resetting lo-gain range and saturation limit." << endl;
+        *fLog << inf << "No lo-gains... resetting lo-gain range";
         fLoGainFirst=0;
         fLoGainLast =0;
-        fSaturationLimit=0xff;
+        if (fSaturationLimit>0xff)
+        {
+            *fLog << " and saturation limit";
+            fSaturationLimit=0xff;
+        }
+        *fLog << "." << endl;
     }
 
@@ -443 +454 @@
     if (IsEnvDefined(env, prefix, "SaturationLimit", print))
     {
-        SetSaturationLimit(GetEnvValue(env, prefix, "SaturationLimit", fSaturationLimit));
+        SetSaturationLimit(GetEnvValue(env, prefix, "SaturationLimit", (Int_t)fSaturationLimit));
         rc = kTRUE;
     }

trunk/MagicSoft/Mars/msignal/MExtractor.h

@@ -32 +32 @@
   
 protected:
-  static const Byte_t  fgSaturationLimit;  //! Default for fSaturationLimit (now set to: 254)
+  static const UInt_t  fgSaturationLimit;  //! Default for fSaturationLimit (now set to: 254)
   static const TString fgNamePedestalCam;  //! "MPedestalCam"
   static const TString fgNameSignalCam;    //! "MExtractedSignalCam"
@@ -59 +59 @@
   Float_t  fSqrtLoGainSamples;             // Sqrt. nr. Low  Gain FADC slices used to extract the signal
 
-  Byte_t   fSaturationLimit;               // Highest FADC slice value until being declared saturated
+  UInt_t   fSaturationLimit;               // Highest FADC slice value until being declared saturated
 
   TString  fNamePedestalCam;               // Name of the 'MPedestalCam' container
@@ -94 +94 @@
   Float_t GetResolutionPerPheHiGain() const { return fResolutionPerPheHiGain; }
   Float_t GetResolutionPerPheLoGain() const { return fResolutionPerPheLoGain; }
-  Byte_t  GetSaturationLimit() const { return fSaturationLimit; }
+  UInt_t  GetSaturationLimit() const { return fSaturationLimit; }
 
   Bool_t  HasLoGain() const { return fLoGainFirst>0 || fLoGainLast>0; }
@@ -106 +106 @@
 
   void SetOffsetLoGain    ( const Float_t  f=fgOffsetLoGain          ) { fOffsetLoGain     = f;    }
-  void SetSaturationLimit ( const Byte_t lim=fgSaturationLimit       ) { fSaturationLimit  = lim;  }
+  void SetSaturationLimit ( const UInt_t lim=fgSaturationLimit       ) { fSaturationLimit  = lim;  }
   void SetNamePedestalCam ( const char *name=fgNamePedestalCam.Data()) { fNamePedestalCam  = name; }
   void SetNameSignalCam   ( const char *name=fgNameSignalCam.Data()  ) { fNameSignalCam    = name; }
@@ -122 +122 @@
   void Print(Option_t *o="") const; //*MENU*
 
-  ClassDef(MExtractor, 7) // Signal Extractor Base Class
+  ClassDef(MExtractor, 8) // Signal Extractor Base Class
 };
 

trunk/MagicSoft/Mars/msignal/MSignalCalc.cc

@@ -46 +46 @@
 
 #include "MRawRunHeader.h"
-#include "MRawEvtData.h"       // MRawEvtData::GetNumPixels
 #include "MSignalCam.h"
 #include "MPedestalPix.h"
 #include "MPedestalCam.h"
 #include "MRawEvtPixelIter.h"
+#include "MPedestalSubtractedEvt.h"
 
 ClassImp(MSignalCalc);
@@ -66 +66 @@
     fName  = name  ? name  : "MSignalCalc";
     fTitle = title ? title : "Task to calculate Cerenkov photons from raw data";
-
-    AddToBranchList("MRawEvtData.fHiGainPixId");
-    AddToBranchList("MRawEvtData.fLoGainPixId");
-    AddToBranchList("MRawEvtData.fHiGainFadcSamples");
-    AddToBranchList("MRawEvtData.fLoGainFadcSamples");
 }
 
@@ -95 +90 @@
     }
 
-    fRawEvt = (MRawEvtData*)pList->FindObject("MRawEvtData");
+    fRawEvt = (MPedestalSubtractedEvt*)pList->FindObject("MPedestalSubtractedEvt");
     if (!fRawEvt)
     {
-        *fLog << dbginf << "MRawEvtData not found... aborting." << endl;
+        *fLog << dbginf << "MPedestalSubtractedEvt not found... aborting." << endl;
         return kFALSE;
     }
@@ -130 +125 @@
 // pixel in the MSignalCam container.
 //
+#include <TSystem.h>
 Int_t MSignalCalc::Process()
 {
-    MRawEvtPixelIter pixel(fRawEvt);
-
-    while (pixel.Next())
+    const Int_t npix = fRawEvt->GetNumPixels();
+    const Int_t nhi  = fRunHeader->GetNumSamplesHiGain();
+    const Int_t nlo  = fRunHeader->GetNumSamplesLoGain();
+
+    for (int i=0; i<npix; i++)
     {
-        Byte_t *ptr   = pixel.GetHiGainSamples();
-        Byte_t *max   = ptr+pixel.GetIdxMaxHiGainSample();
-        Byte_t *end   = ptr+fRunHeader->GetNumSamplesHiGain();
+        Byte_t *raw = fRawEvt->GetSamplesRaw(i);
+
+        Byte_t *ptr   = raw;
+        Byte_t *max   = ptr+fRawEvt->GetMax(i, 0, nhi);
+        Byte_t *end   = ptr+nhi;
         Byte_t *first = max-fBefore;
         Byte_t *last  = max+fAfter;
@@ -144 +144 @@
         ULong_t sumb  = 0;   // sum background
         ULong_t sqb   = 0;   // sum sqares background
-        ULong_t sumsb = 0;   // sum signal+background
+        //ULong_t sumsb = 0;   // sum signal+background
         ULong_t sqsb  = 0;   // sum sqares signal+background
 
@@ -168 +168 @@
             else
             {
-                sumsb += *ptr;
+                //sumsb += *ptr;
                 sqsb  += *ptr* *ptr;
                 nsb++;
@@ -175 +175 @@
         }
 
-        if (sat==0 && ishi)
+        if (nlo>0 && sat==0 && ishi)
         {
             // Area: x9
-            ptr = pixel.GetLoGainSamples();
-            end = ptr+fRunHeader->GetNumSamplesLoGain();
+            ptr = raw+nhi;
+            end = ptr+nlo;
 
             sumb = 0;   // sum background
@@ -187 +187 @@
             while (ptr<end)
             {
-                // Background already calced from hi-gains!
+                // Background already caced from hi-gains!
                 sumb += *ptr;
                 sqb  += *ptr* *ptr;
@@ -195 +195 @@
         }
 
-        if (sat>1 && !ishi)
+        if (nlo>0 && sat>1 && !ishi)
         {
             // Area: x9
-            ptr = pixel.GetLoGainSamples();
-            max = ptr+pixel.GetIdxMaxLoGainSample();
+            ptr = raw+nhi;
+            max = ptr+fRawEvt->GetMax(i, nhi, nhi+nlo);
 
             if (*max>250)
@@ -207 +207 @@
             }
 
-            end   = ptr+fRunHeader->GetNumSamplesLoGain();
+            end   = ptr+nlo;
             first = max-fBefore;
             last  = max+fAfter;
 
-            sumsb = 0;   // sum signal+background
-            sqsb  = 0;   // sum sqares signal+background
-            //sumb  = 0;   // sum background
+            //sumsb = 0;   // sum signal+background
+            //sqsb  = 0;   // sum sqares signal+background
+            sumb  = 0;   // sum background
             //sqb   = 0;   // sum sqares background
 
@@ -230 +230 @@
                 else
                 {
-                    sumsb += *ptr;
+                    //sumsb += *ptr;
                     sqsb  += *ptr* *ptr;
                     nsb++;
@@ -238 +238 @@
         }
 
-        Float_t b  = (float)sumb/nb;       // background
-        Float_t sb = (float)sumsb/nsb;     // signal+background
-
-        Float_t msb  = (float)sqb/nb;      // mean square background
+        Float_t b  = nb==0 ? 0 : (float)sumb/nb;       // background
+        //Float_t sb = (float)sumsb/nsb;     // signal+background
+
+        Float_t msb  = nb==0 ? 0 : (float)sqb/nb;      // mean square background
         //Float_t mssb = (float)sqsb/nsb;    // mean square signal+background
 
@@ -247 +247 @@
         //Float_t sigsb = sqrt(mssb-sb*sb);  // sigma signal+background
 
-        Float_t s   = sb-b;                // signal
+        //Float_t s   = sb-b;                // signal
         //Float_t sqs = sqsb-nsb*b;          // sum squares signal
 
@@ -253 +253 @@
         //Float_t sigs = sqrt(mss-s*s);      // sigma signal
 
-        if (sat>1)
-            s *= 11.3;
-
-        Int_t idx = pixel.GetPixelId();
+        //if (sat>1)
+        //    s *= 11.3;
+
         //fCerPhotEvt->AddPixel(idx, s, sigs);
 
@@ -262 +261 @@
         // MMcPedestalCopy and MMcPedestalNSBAdd
         if (fPedestals)
-            (*fPedestals)[idx].Set(b, sigb);
+            (*fPedestals)[i].Set(b, sigb);
     }
 

trunk/MagicSoft/Mars/msignal/MSignalCalc.h

@@ -6 +6 @@
 #endif
 
-class MRawEvtData;
 class MPedestalCam;
 class MSignalCam;
 class MRawRunHeader;
+class MPedestalSubtractedEvt;
 
 class MSignalCalc : public MTask
 {
 private:
-    MPedestalCam  *fPedestals;  // Pedestals of all pixels in the camera
-    MRawEvtData   *fRawEvt;     // raw event data (time slices)
-    MSignalCam    *fCerPhotEvt; // Cerenkov Photon Event used for calculation
-    MRawRunHeader *fRunHeader;  // RunHeader information
+    MRawRunHeader          *fRunHeader;  // RunHeader information
+    MPedestalSubtractedEvt *fRawEvt;     // raw event data (time slices)
+    MSignalCam             *fCerPhotEvt; // Cerenkov Photon Event used for calculation
+    MPedestalCam           *fPedestals;  // Pedestals of all pixels in the camera
 
     Byte_t fBefore;