Changeset 8673

Timestamp:

08/17/07 11:53:49 (17 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• mbase/MMath.cc (modified) (2 diffs)
• mbase/MStatusDisplay.cc (modified) (3 diffs)
• mhflux/MHCollectionArea.cc (modified) (2 diffs)
• mhflux/MHCollectionArea.h (modified) (1 diff)
• mhflux/MHEnergyEst.cc (modified) (1 diff)
• sponde.cc (modified) (3 diffs)

trunk/MagicSoft/Mars/Changelog

@@ -19 +19 @@
                                                  -*-*- END OF LINE -*-*-
 
+ 2007/08/17 Thomas Bretz
+
+   * sponde.cc:
+     - removed switch for simple and accurate mode
+
+   * mbase/MMath.cc:
+     - fixed a problem in LiMaExc which could result in NaN
+       (if signal and background is 0)
+
+   * mbase/MStatusDisplay.cc:
+     - remove canvases in batch-mode from the global list of canvases,
+       this could result in crahses if two canvases in the display
+       had the same name
+
+   * mhflux/MHCollectionArea.[h,cc]:
+     - output the maximum impact found in Finalize
+
+   * mhflux/MHEnergyEst.cc:
+     - made the y-axis in the Eest vs Emc plot logarithmic
+
+
+
  2007/08/16 Markus Meyer
 
    * resources/calibration.rc:
      - update of muon calibration factors for the periods 41 to 50
-     .
+
+
 
  2007/08/15 Thomas Bretz

trunk/MagicSoft/Mars/mbase/MMath.cc

@@ -1 +1 @@
 /* ======================================================================== *\
-! $Name: not supported by cvs2svn $:$Id: MMath.cc,v 1.36 2007-06-19 11:14:33 tbretz Exp $
+! $Name: not supported by cvs2svn $:$Id: MMath.cc,v 1.37 2007-08-17 10:53:48 tbretz Exp $
 ! --------------------------------------------------------------------------
 !
@@ -153 +153 @@
     Double_t sN = s + alpha*alpha*b;
 
-    return Ns<0 || sN<0 ? 0 : Ns/TMath::Sqrt(sN);
+    if (Ns<0 || sN<0)
+        return 0;
+
+    if (Ns==0 && sN==0)
+        return 0;
+
+    return Ns/TMath::Sqrt(sN);
 }
 

trunk/MagicSoft/Mars/mbase/MStatusDisplay.cc

@@ -1010 +1010 @@
 TCanvas &MStatusDisplay::AddTab(const char *name)
 {
+    /*
+    if (HasCanvas(name))
+    {
+        *fLog << warn;
+        *fLog << "WARNING - A canvas '" << name << "' is already existing in the Status Display." << endl;
+        *fLog << "          This can cause unexpected crahes!" << endl;
+    }*/
+
     if (gROOT->IsBatch())
     {
@@ -1017 +1025 @@
 
         TCanvas *c = new TCanvas(name, name, -cw, ch);
+
+        gROOT->GetListOfCanvases()->Remove(c);
+
         fBatch->Add(c);
         return *c;
@@ -1342 +1353 @@
     if (!c)
         return kFALSE;
+
+    // If you encounter unexpected crashes here, check if
+    // a canvas is existing twice in the list or has been
+    // deleted by accident. (Check AddTab)
 
     if (gROOT->IsBatch())

trunk/MagicSoft/Mars/mhflux/MHCollectionArea.cc

@@ -284 +284 @@
         //                         GetCollectionAreaEff(),
         //                         GetCollectionAreaAbs(), fMcAreaRadius);
-        const TString txt = Form("A_{abs}=%.0fm^{2}  r=%.0fm",
+        const TString txt = Form("r_{max}=%.0fm --> A_{max}=%.0fm^{2}",
                                  GetCollectionAreaAbs(), fMcAreaRadius);
 
@@ -457 +457 @@
     return kTRUE;
 }
+
+Bool_t MHCollectionArea::Finalize()
+{
+    *fLog << all << "Maximum simulated impact found: " << fMcAreaRadius << "m" << endl;
+
+    CalcEfficiency();
+
+    return kTRUE;
+}

trunk/MagicSoft/Mars/mhflux/MHCollectionArea.h

@@ -44 +44 @@
     Bool_t ReInit(MParList *pList);
     Bool_t Fill(const MParContainer *par, const Stat_t weight=1);
-    Bool_t Finalize() { CalcEfficiency(); return kTRUE; }
+    Bool_t Finalize();
 
     void Draw(Option_t *option="");

trunk/MagicSoft/Mars/mhflux/MHEnergyEst.cc

@@ -504 +504 @@
 
     pad2->cd(1);
+    gPad->SetLogy();
     h = MakePlot(fHEnergy, "xy");
     h->SetXTitle("E_{mc} [GeV]");

trunk/MagicSoft/Mars/sponde.cc

@@ -52 +52 @@
     gLog << "   --refill                  Refill the excess histogram from result file" << endl;
     gLog << "                             (usefull to change the binning)" << endl;
-    gLog << "   --accurate                Fill original energy/theta distribution from data" << endl;
-    gLog << "                             (do not weight the histogram)" << endl;
+//    gLog << "   --accurate                Fill original energy/theta distribution from data" << endl;
+//    gLog << "                             (do not weight the histogram)" << endl;
     gLog << "   --raw-mc                  Use the mc sample as it is" << endl << endl;
     gLog << " Options:" << endl;
@@ -121 +121 @@
 
     const Bool_t  kRefill        =  arg.HasOnlyAndRemove("--refill");
-    const Bool_t  kSimple        = !arg.HasOnlyAndRemove("--accurate");
+//    const Bool_t  kSimple        = !arg.HasOnlyAndRemove("--accurate");
     const Bool_t  kRawMc         =  arg.HasOnlyAndRemove("--raw-mc");
 
@@ -224 +224 @@
 
     job.EnableRefilling(kRefill);
-    job.EnableSimpleMode(kSimple);
+//    job.EnableSimpleMode(kSimple);
     job.EnableRawMc(kRawMc);