Changeset 8921

Timestamp:

06/03/08 15:12:40 (16 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars/mgeom

Files:

• MGeomCam.cc (modified) (5 diffs)
• MGeomCam.h (modified) (2 diffs)

trunk/MagicSoft/Mars/mgeom/MGeomCam.cc

@@ -96 +96 @@
     fPixels.SetOwner();
 
+    // For root versions <5.18 AddAt is mandatory, for newer
+    // root-version the []-operator can be used safely
     for (UInt_t i=0; i<npix; i++)
         fPixels.AddAt(new MGeomPix, i);
@@ -354 +356 @@
 }
 
-
 // --------------------------------------------------------------------------
 //
@@ -398 +399 @@
         fPixels.Print();
 } 
-
-// --------------------------------------------------------------------------
-//
-//  Create a clone of this container. This is very easy, because we
-//  simply have to create a new object of the same type.
-//
-TObject *MGeomCam::Clone(const char *newname) const
-{
-    if (IsA()==MGeomCam::Class())
-    {
-        MGeomCam *cam = new MGeomCam(fNumPixels, fCamDist);
-        for (UInt_t i=0; i<fNumPixels; i++)
-        {
-            //if (fPixels.UncheckedAt(i))
-                (*this)[i].Copy((*cam)[i]);
-        }
-        cam->InitGeometry();
-        return cam;
-    }
-
-    return (TObject*)IsA()->New();
-}
 
 // --------------------------------------------------------------------------
@@ -546 +525 @@
 }
 
-#if ROOT_VERSION_CODE >= ROOT_VERSION(5,18,00)
-#include <TClass.h>
-#endif
+// --------------------------------------------------------------------------
+//
+// This workaround reproduces (as much as possible) the contents
+// of fPixels which got lost writing MGeomCam in which the
+// fPixels were filles with the []-operator instead of AddAt
+// and a root version previous to 5.18.
+// You try to read broken contents from file if fNumPixels is empty
+// but fNumPixels>0.
+// If you ever read broken contents from a split branch you
+// MUST call this function after reading.
+//
+void MGeomCam::StreamerWorkaround()
+{
+    if (fNumPixels==0 || !fPixels.IsEmpty())
+        return;
+
+    TObject *cam = (TObject*)IsA()->New();
+    cam->Copy(*this);
+    delete cam;
+}
 
 // --------------------------------------------------------------------------
@@ -566 +562 @@
     {
         MGeomCam::Class()->ReadBuffer(b, this);
-
-#if ROOT_VERSION_CODE >= ROOT_VERSION(5,18,00)
-        if (IsA()!=MGeomCam::Class() && fPixels.GetEntriesFast()==0)
-        {
-            MGeomCam *c = (MGeomCam*)IsA()->New();
-            c->Copy(*this);
-            delete c;
-        }
-#endif
+        StreamerWorkaround();
     }
     else

trunk/MagicSoft/Mars/mgeom/MGeomCam.h

@@ -50 +50 @@
     MGeomCam(UInt_t npix=0, Float_t dist=1, const char *name=NULL, const char *title=NULL);
 
-    TObject *Clone(const char *newname=NULL) const;
     void Copy(TObject &o) const;
 
-    void CalcPixRatio(); 
     // FIXME, workaround: this function is made public just to allow
     // the use of some camera files from the 0.7 beta version in which the 
     // array containing pixel ratios is not initialized.
+    void CalcPixRatio();
+
+    // FIXME, workaround broken streaming
+    void StreamerWorkaround();
+
     void InitGeometry()
     {
@@ -106 +109 @@
     Int_t GetNeighbor(UInt_t idx, Int_t dir) const;
 
-    virtual void Print(Option_t *opt=NULL)   const;
+    void Print(Option_t *opt=NULL) const;
 
     ClassDef(MGeomCam, 5)  // Geometry base class for the camera