Changeset 14599 for trunk/FACT++

Timestamp:

11/10/12 13:03:32 (12 years ago)

Author:

tbretz

Message:

Made lockers const and moved the chck for a valid main thread behin the locker; if the main thread was terminatd already set fThreadId to 0 so that no new thread will run.

File:

• trunk/FACT++/src/InterpreterV8.cc (modified) (7 diffs)

trunk/FACT++/src/InterpreterV8.cc

@@ -34 +34 @@
     fThreadIds.clear();
 
-    if (fThreadId>=0)
-        V8::TerminateExecution(fThreadId);
+    if (fThreadId<0)
+        return;
+
+    V8::TerminateExecution(fThreadId);
+    fThreadId = -1;
 }
 
@@ -51 +54 @@
         // of four using a larger value, but this also means that the
         // JavaScript is locked for a longer time.
+        const Unlocker unlock;
         usleep(1000);
         return Undefined();
@@ -77 +81 @@
 
     return handle_scope.Close(script->Run());
-
-    //JsSleep(args[0]->Int32Value());
-    //return Undefined();
 }
 
 void InterpreterV8::ThreadTimeout(Persistent<Function> func, uint32_t ms)
 {
+    const Locker lock;
+
     if (fThreadId<0)
         return;
 
-    Locker lock;
-
-    const HandleScope handle_scope;
-
-    fGlobalContext->Enter();
-
     const int id = V8::GetCurrentThreadId();
     fThreadIds.insert(id);
+
+    const HandleScope handle_scope;
+
+    fGlobalContext->Enter();
 
     TryCatch exception;
@@ -891 +892 @@
 void InterpreterV8::JsHandleEvent(const EventImp &evt, uint64_t cnt, const string &service)
 {
+    const Locker locker;
+
     if (fThreadId<0)
         return;
-
-    Locker locker;
 
     const auto it = fReverseMap.find(service);
@@ -966 +967 @@
 void InterpreterV8::JsHandleState(const std::string &server, const State &state)
 {
+    const Locker locker;
+
     if (fThreadId<0)
         return;
-
-    Locker locker;
 
     auto it = fStateCallbacks.find(server);
@@ -1482 +1483 @@
 bool InterpreterV8::JsRun(const string &filename, const map<string, string> &map)
 {
-    Locker locker;
+    const Locker locker;
     fThreadId = V8::GetCurrentThreadId();
 
@@ -1571 +1572 @@
     // the signal to terminate. After they are all successfully
     // terminated, just to be sure... we lock again
-    Unlocker unlock;
-
-    for (auto it=fTimeout.begin(); it!=fTimeout.end(); it++)
-        it->join();
-    fTimeout.clear();
-
-    Locker lock2;
+    {
+        const Unlocker unlock;
+
+        for (auto it=fTimeout.begin(); it!=fTimeout.end(); it++)
+            it->join();
+        fTimeout.clear();
+    }
 
     // Now we can dispose all persistent handles from state callbacks