Changeset 14600 for trunk/FACT++

Timestamp:

11/10/12 13:08:18 (12 years ago)

Author:

tbretz

Message:

Made lockers const and moved the chck for a valid main thread behin the locker; if the main thread was terminatd already set fThreadId to 0 so that no new thread will run.

File:

• trunk/FACT++/src/InterpreterV8.cc (modified) (2 diffs)

trunk/FACT++/src/InterpreterV8.cc

@@ -25 +25 @@
 
 // ==========================================================================
+//                           Some documentation
+// ==========================================================================
+//
+// Threads:
+// --------
+// In most cases Js* and other calls to native C++ code could be wrapped
+// with an Unlocker to allow possible other JavaScipt 'threads' to run
+// during that time. However, all of these calls should take much less than
+// the preemption time of 10ms, so it would just be a waste of tim.
+//
+// Termination:
+// ------------
+// Each thread running V8 code needs to be signalled individually for
+// termination.
+//
+
+// ==========================================================================
 //                            Simple interface
 // ==========================================================================
@@ -30 +47 @@
 void InterpreterV8::Terminate()
 {
+    /*
     for (auto it=fThreadIds.begin(); it!=fThreadIds.end(); it++)
         V8::TerminateExecution(*it);
     fThreadIds.clear();
-
+    */
     if (fThreadId<0)
         return;