Changeset 14601 for trunk/FACT++

Timestamp:

11/10/12 13:19:58 (12 years ago)

Author:

tbretz

Message:

Allow 0 timeout, added a check for Locking in Terminate; added some documentatation

File:

• trunk/FACT++/src/InterpreterV8.cc (modified) (3 diffs)

trunk/FACT++/src/InterpreterV8.cc

@@ -38 +38 @@
 // ------------
 // Each thread running V8 code needs to be signalled individually for
-// termination.
+// termination. Therefor a list of V8 thread ids is created.
 //
+// If temrination has already be signalled, no thread should start running
+// anymore (thy could, e.g., wait for their locking). So after locking
+// it has to be checked if the thread was terminated already. Note
+// that all calls to Terminate() must be locked to ensure that fThreadId
+// is correct when it is checked.
+//
+// Empty handles:
+// --------------
+// If exceution is terminated, V8 calls might return with empty handles,
+// e.g. Date::New(). Therefore, the returned handles of these calls have to
+// be checked in all placed to avoid that V8 will core dump.
+//
 
 // ==========================================================================
@@ -47 +59 @@
 void InterpreterV8::Terminate()
 {
-    /*
+    if (!Locker::IsLocked())
+        JsException("***** InterprterV8::Terminate call not locked *****");
+
     for (auto it=fThreadIds.begin(); it!=fThreadIds.end(); it++)
         V8::TerminateExecution(*it);
     fThreadIds.clear();
-    */
-    if (fThreadId<0)
-        return;
-
-    V8::TerminateExecution(fThreadId);
-    fThreadId = -1;
+
+    if (fThreadId>=0)
+    {
+        V8::TerminateExecution(fThreadId);
+        fThreadId = -1;
+    }
 }
 
@@ -118 +132 @@
 
     const Handle<Script> sleep = Script::Compile(String::New(("dim.sleep("+to_string(ms)+");").c_str()));
-    if (!sleep.IsEmpty() && !sleep->Run().IsEmpty())
+    if (ms==0 || (!sleep.IsEmpty() && !sleep->Run().IsEmpty()))
     {
         Handle<Value> args[] = {  };