Changeset 152 for Evidence/DColl.cc

Timestamp:

01/27/10 15:28:06 (15 years ago)

Author:

ogrimm

Message:

Updates

File:

• Evidence/DColl.cc (modified) (13 diffs)

Evidence/DColl.cc

@@ -11 +11 @@
         written to the data file. Only if the new value has changed by a
         minimum amout it will be added to the ring buffer.
+  - The history buffers are written to disk at program termination and
+    are tired to be read when adding a service.
   - The command 'DColl/Log' writes the associated string to the log 
     file specified in the configuration.
@@ -23 +25 @@
 
 #include "Evidence.h"
+
+#include <string>
+#include <sstream>
+#include <vector>
+#include <iomanip>
 
 #include <math.h>
@@ -44 +51 @@
           double LastValue;
           double MinAbsChange;
-        } *List;
-
+        };
+        vector<struct Item> List;
+        
         DimCommand *LogCommand;
                 
-    unsigned int NumItems;
-        char *Filename;
     FILE *DataFile;
     FILE *LogFile;
+        char *Filename;
         float DataSizekB, LogSizekB;
         int DataSizeLastUpdate, LogSizeLastUpdate;
         char *DataDir;
     DimService *LogSizeService, *DataSizeService, *DataFilename;
+        string HistDir;
     int HistSize;
         int SizeUpdateDelay;
@@ -66 +74 @@
     void infoHandler();
     void commandHandler();
-        void AddService(char *);
+        void AddService(string);
         float FileSize(FILE *);
             
@@ -80 +88 @@
 
   // Initialization to prevent freeing unallocated memory 
-  Filename = NULL;
   DataFile = NULL;
   LogFile = NULL;
-  List = NULL;
+  Filename = NULL;
+  
   LogSizeService = NULL;
   DataSizeService = NULL;
@@ -93 +101 @@
   // Request configuration data
   char *Change = GetConfig(SERVER_NAME " minchange");
+
   DataDir = GetConfig(SERVER_NAME " datadir");
+
   char *Logname = GetConfig(SERVER_NAME " logfile");
+
   SizeUpdateDelay = atoi(GetConfig(SERVER_NAME " sizeupdate"));
+
   HistSize = atoi(GetConfig(SERVER_NAME " histsize"));
   if (HistSize < 1) HistSize = 1; // Minimum one items
+
+  HistDir = GetConfig(SERVER_NAME " histdir");
    
   // Open log file
@@ -148 +162 @@
 
   // Subscribe to list of servers at DIS_DNS 
-  AddService((char *) "DIS_DNS/SERVER_LIST");
+  AddService("DIS_DNS/SERVER_LIST");
 
   DimClient::sendCommand("DColl/Log", SERVER_NAME" *** Logging started ***");
@@ -158 +172 @@
 DataHandler::~DataHandler() {
 
-  // Delete DIM services and command first so handlers and not called anymore
-  for (int i=0; i<NumItems; i++) {
+  DimClient::sendCommand("DColl/Log", SERVER_NAME" *** Logging stopped ***");
+
+  // Delete DIM subscriptions and command first so handlers and not called anymore
+  for (int i=0; i<List.size(); i++) {
+    delete List[i].DataItem;
+  }
+  delete LogCommand;
+  
+  // Save history buffers to files (replace '/' by '_')
+  for (int i=0; i<List.size(); i++) {
+    string Name = List[i].HistService->getName();
+        for (int j=0; j<Name.size(); j++) if (Name[j] == '/') Name[j] = '_';
+    FILE *File = fopen((HistDir + "/" + Name).c_str(), "wb");
+        if (File != NULL) {
+      fwrite(&List[i].HistPointer, sizeof(List[i].HistPointer), 1, File);
+      fwrite(List[i].HistBuffer, sizeof(EvidenceHistoryItem), HistSize, File);
+      fclose(File);
+        }
         delete List[i].HistService;
-    delete List[i].DataItem;
     delete[] List[i].HistBuffer;
   }
-  free(List);
 
   delete DataFilename;
+  delete[] Filename;
+  
   //delete LogSizeService; // These create segmentation faults?!
   //delete DataSizeService;
-
-  delete LogCommand;
-  free(Filename);
 
   // Close files
@@ -203 +230 @@
   // If service is DIS_DNS/SERVER_LIST, subscribe to all SERVICE_LIST services
   if (strcmp(Info->getName(), "DIS_DNS/SERVER_LIST") == 0) {    
-        char *Token = strtok(Info->getString(), "+-!|@");       
+        char *Token = strtok(Info->getString(), "@");   
         while (Token != NULL) {
-          char *Buf;
-          if (MakeString(&Buf, "%s/SERVICE_LIST", Token) != -1) {
-            AddService(Buf);
-                free(Buf);
-          }
-          else State(ERROR, "MakeString() failed for server %s", Token);
+          if (isalpha(*Token) == 0) Token++; // Name can start with +,-,!
           
-          Token = strtok(NULL, "|");
-          Token = strtok(NULL, "+-!|@");        
+          AddService(string(Token)+"/SERVICE_LIST");      
+          
+          Token = strtok(NULL, "|");
+          Token = strtok(NULL, "|@");   // ???? Why needed ?????
         }       
         return;
@@ -221 +245 @@
   // Subscribe to all services (but not to commands and RPCs)
   if (strstr(Info->getName(), "/SERVICE_LIST") != NULL) {
-        char *Name = strtok(Info->getString(), "+-!|");
+
+        char *Name = strtok(Info->getString(), "|");
         while (Name != NULL) {
           char *Type = strtok(NULL, "\n");
           if (Type == NULL) return; // for safety, should not happen
+          if (isalpha(*Name) == 0) Name++; // Name can start with +,-,!
       if (strstr(Type, "|CMD")==NULL && strstr(Type, "|RPC")==NULL) {
                 AddService(Name);
           }
-          Name = strtok(NULL, "+-!|");
+          Name = strtok(NULL, "|");
         }
         return;
@@ -245 +271 @@
         time_t Time = time(NULL);
         struct tm *T = localtime(&Time);
-        
+        ostringstream Buf;
+        
+        // Generate file name from date
         if(T->tm_hour >= DATE_ROLLOVER) T->tm_mday++;
         if (mktime(T) == -1) State(ERROR, "mktime() failed, check filename");
-
-        free(Filename);
-        if (MakeString(&Filename, "%s/%d%02d%02d.slow", DataDir, T->tm_year+1900, T->tm_mon+1, T->tm_mday) == -1) State(FATAL, "Could not create filename, MakeString() failed");
+        Buf << DataDir << "/" << T->tm_year+1900 << setw(2) << setfill('0') << T->tm_mon+1 << T->tm_mday << ".slow";
+        
+        // Copy filename to permanent buffer
+        delete[] Filename;
+        Filename = new char [Buf.str().size()+1];
+        strcpy(Filename, Buf.str().c_str());
+        
+        // Open file
         if ((DataFile = fopen(Filename, "a")) == NULL) {
       State(FATAL, "Could not open data file '%s' (%s)", Filename, strerror(errno));
@@ -266 +299 @@
   // Identify index of service
   int Service;  
-  for (Service=0; Service<NumItems; Service++) if (Info == List[Service].DataItem) break;
-  if (Service == NumItems) return;  // Service not found
+  for (Service=0; Service<List.size(); Service++) if (Info == List[Service].DataItem) break;
+  if (Service == List.size()) return;  // Service not found
 
   // If negative value for absolute change, ignore this entry
@@ -360 +393 @@
 // Add service to watch list
 //
-void DataHandler::AddService(char *Name) {
+void DataHandler::AddService(string Name) {
 
   // Do not subscribe to history services (otherwise infinite loop)
-  if (strstr(Name, ".hist") != NULL) return;
+  if (Name.find(".hist") != string::npos) return;
 
   // Check if already subscribed to this service
-  for (int i=0; i<NumItems; i++) {
-        if(strcmp(Name, List[i].DataItem->getName()) == 0) return;
-  }
-
-  // Increase capacity of item list                     
-  struct Item *New = (struct Item *) realloc(List, (NumItems+1)*sizeof(struct Item));
-  if (New != NULL) List = New;
-  else {
-        State(ERROR, "Could not allocate memory for item list, service '' not added (%s)", Name, strerror(errno));
-        return;
-  }
-  
+  for (int i=0; i<List.size(); i++) {
+        if (Name == List[i].DataItem->getName()) return;
+  }
+  
+  // Create new entry in item list
+  struct Item New;
+
   // Set minimum required change by comparing to regular expressions
-  List[NumItems].MinAbsChange = 0;
+  New.MinAbsChange = 0;
   for (int i=0; i<RegExCount; i++) {
-    if (regexec(&RegEx[i], Name, (size_t) 0, NULL, 0) == 0) {
-          List[NumItems].MinAbsChange = MinChange[i];
-        }
-  }
-  
-  List[NumItems].LastValue = DBL_MAX;
-                
+    if (regexec(&RegEx[i], Name.c_str(), (size_t) 0, NULL, 0) == 0) {
+          New.MinAbsChange = MinChange[i];
+        }
+  }
+                
   // Create history service
-  List[NumItems].HistBuffer = new struct EvidenceHistoryItem [HistSize];
-  memset(List[NumItems].HistBuffer, 0, HistSize*sizeof(EvidenceHistoryItem));
-  List[NumItems].HistPointer = 0;
-
-  char *Buf;
-  if (MakeString(&Buf, "%s.hist", Name) == -1) {
-    State(ERROR, "Could not create history service for '%s', MakeString() failed", Name);
-  }
-  else {
-        List[NumItems].HistService = new DimService (Buf, (char *) "C",
-                                          List[NumItems].HistBuffer, HistSize*sizeof(EvidenceHistoryItem));
-    free(Buf);
-  }
-
+  New.HistBuffer = new struct EvidenceHistoryItem [HistSize];
+  memset(New.HistBuffer, 0, HistSize*sizeof(EvidenceHistoryItem));
+  New.HistPointer = 0;
+  New.LastValue = DBL_MAX;
+  New.HistService = new DimService ((Name+".hist").c_str(), (char *) "C",
+                                          New.HistBuffer, HistSize*sizeof(EvidenceHistoryItem));
+        
+  // Load history buffer from file if existing
+  string Filename = New.HistService->getName();
+  for (int j=0; j<Filename.size(); j++) if (Filename[j] == '/') Filename[j] = '_';
+  FILE *File = fopen((HistDir + "/" + Filename).c_str(), "rb");
+  if (File != NULL) {
+    fread(&New.HistPointer, sizeof(New.HistPointer), 1, File);
+    fread(New.HistBuffer, sizeof(EvidenceHistoryItem), HistSize, File);
+    fclose(File);
+  }
+  
   // Subscribe to service
-  List[NumItems].DataItem = new DimStampedInfo(Name, NO_LINK, this);
-
-  // Increase number only after all set-up
-  NumItems++;
+  New.DataItem = new DimStampedInfo(Name.c_str(), NO_LINK, this);
+
+  // Add item to list
+  List.push_back(New);
 }