Changeset 18234 for branches/FACT++_scripts_refactoring/explicit_changelog

Timestamp:

06/18/15 14:21:05 (9 years ago)

Author:

dneise

Message:

info about takeRun.js --> library problems

File:

• branches/FACT++_scripts_refactoring/explicit_changelog (modified) (1 diff)

branches/FACT++_scripts_refactoring/explicit_changelog

@@ -146 +146 @@
 # ----------------------------------------------------------------------
 
-Okay now I look at takeRun.js
+Okay now I look at takeRun.js as it is included in CheckUnderflow.
+I had to create a new function, which would handle the attachment of 
+the inchange function to the FACT_CONTROL/INCOMPLETE subscription.
+I don't know a good name for this, but I think I wrote it correctly.
+
+I don't like that the new function takeRun.attachFadControlIncompleteOnChange 
+has a member named takeRun.attachFadControlIncompleteOnChange.incomplete.
+
+I also don't like, that in CheckUnderflow, I call this new function,
+which will attach a callback function to the FACT_CONTROL/INCOMPLETE subscription.
+But when reading the code, one can hardly understand that.
+
+I mean, this is just like when takeRun.js was included before.
+Nobody could have even guessed, that there was a callback function attached to 
+a Subscription instance made just before takeRun.js was included. 
+
+Okay that's it for the moment. Next is probably CheckUnderflow itself,
+since it is a kind of library itself.
+
+# ----------------------------------------------------------------------