Changeset 8703

Timestamp:

08/23/07 17:37:34 (17 years ago)

Author:

tbretz

Message:

*** empty log message ***

Location:

trunk/MagicSoft/Mars

Files:

• Changelog (modified) (1 diff)
• NEWS (modified) (2 diffs)
• mjobs/MJSpectrum.cc (modified) (5 diffs)

trunk/MagicSoft/Mars/Changelog

@@ -49 +49 @@
      - replaced fFreqSampling by fSamplingFrequency for compatibility
      - increased ClassVersion to 9
+
+   * mraw/MRawEvtData.cc:
+     - initialize fNumBytesPerSample to 1 to make it compatible with reading
+       old MC files.
+
+   * mjobs/MJSpectrum.cc:
+     - added control plot for the residual of Energy
+     - fixed the "Overflow-Bug". It was a loop from o to <n, while histogram
+       bins are from 1 to ==n
 
 

trunk/MagicSoft/Mars/NEWS

@@ -263 +263 @@
      the information is lost.
 
+   - sponde: added a new tab "Energy". It shows the residual of the
+     energy (lg(estimated energy)-lg(monte carlo energy)) versus
+     several parameters and it is meant to judge the quality of the
+     energy estimator. In the ideal case the residual is zero
+     and doesn't depend in the variable. In reality even a good estimator
+     can show residuals versus Monte Carlo energy.
+
    - sponde: added a new tab "EventDist" showing the unweighted real
      absolute number of events of your sample after cuts. This tells
@@ -275 +282 @@
    - sponde: The OriginalMC tree with the events produced by corsika 
      is now processed only once
+
+   - sponde: Finally fixed most annoying bug, which has effected the
+     last bin of the collection area. It was the problem that binnings
+     of root histograms are from 1 to n (included) but there was a C-like
+     loop in sponde from 0 to n (excluded). Now the loop also includes
+     correctly under- and overflow-bins. The worse thing with this is,
+     that for the events in the highest bin not only the bin-content
+     was wrong, but also the weights applied to these events, which could
+     in pricipal effect also other parts of the distribution (eg. due
+     to energy estimation). Fortunately it effected only a few events
+     in most cases.
 
 

trunk/MagicSoft/Mars/mjobs/MJSpectrum.cc

@@ -1496 +1496 @@
     MBinning binsC(50,  0, 0.3,    "BinningLeakage",        "lin");
     MBinning binsB(51, -1, 1,      "BinningEnergyResidual", "lin");
-    MBinning binsD(51, -3, 1,      "BinningResidualDist",   "lin");
+    MBinning binsD(51, -1, 1,      "BinningResidualDist",   "lin");
 
     plist.AddToList(&binsA);
@@ -1506 +1506 @@
     SetupHistEnergyEst(heest);
 
-    MHn hdisp("Disp", "Dist residual (Disp-Dist)");
-    SetupHistDisp(hdisp);
+    //MHn hdisp("Disp", "Dist residual (Disp-Dist)");
+    //SetupHistDisp(hdisp);
 
     MHn henergy("EvtDist");
@@ -1515 +1515 @@
     fill4b.SetWeight();
 
-    MFillH fill4c(&hdisp, "", "FillDispResidual");
-    fill4c.SetWeight();
+    //MFillH fill4c(&hdisp, "", "FillDispResidual");
+    //fill4c.SetWeight();
 
     // ---------------------------------------------------------
@@ -1582 +1582 @@
     tlist2.AddToList(fCut0);
     tlist2.AddToList(&taskenv0);
+    tlist2.AddToList(fCut1);
     tlist2.AddToList(fCutS);
-    tlist2.AddToList(fCut1);
     tlist2.AddToList(fCut2);
     tlist2.AddToList(fCut3);
@@ -1590 +1590 @@
     tlist2.AddToList(&fill4);
     tlist2.AddToList(&fill4b);
-    tlist2.AddToList(&fill4c);
     tlist2.AddToList(&fill5);
     tlist2.AddToList(&fill0a);